From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v6 2/3] net/tap: move fds of Rx/Tx queues to be in process private Date: Thu, 11 Oct 2018 17:19:34 +0100 Message-ID: References: <1539182356-15496-1-git-send-email-rasland@mellanox.com> <1539182356-15496-2-git-send-email-rasland@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Thomas Monjalon , "dev@dpdk.org" , Shahaf Shuler , Ori Kam , Alejandro Lucero To: Raslan Darawsheh , "keith.wiles@intel.com" Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 7A2B41B52A for ; Thu, 11 Oct 2018 18:19:37 +0200 (CEST) In-Reply-To: <1539182356-15496-2-git-send-email-rasland@mellanox.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/10/2018 3:39 PM, Raslan Darawsheh wrote: > fd's cannot be shared between processes, and each process need to have > it's own fd's pointer. > > Signed-off-by: Raslan Darawsheh > --- > drivers/net/tap/rte_eth_tap.c | 93 +++++++++++++++++++++++++++++-------------- > drivers/net/tap/rte_eth_tap.h | 7 +++- > drivers/net/tap/tap_flow.c | 3 +- > drivers/net/tap/tap_intr.c | 5 ++- > 4 files changed, 73 insertions(+), 35 deletions(-) > > diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c > index edfb7da..3372d54 100644 > --- a/drivers/net/tap/rte_eth_tap.c > +++ b/drivers/net/tap/rte_eth_tap.c > @@ -315,6 +315,7 @@ static uint16_t > pmd_rx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts) > { > struct rx_queue *rxq = queue; > + struct pmd_process_private *process_private; > uint16_t num_rx; > unsigned long num_rx_bytes = 0; > uint32_t trigger = tap_trigger; > @@ -323,6 +324,7 @@ pmd_rx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts) > return 0; > if (trigger) > rxq->trigger_seen = trigger; > + process_private = rte_eth_devices[rxq->in_port].process_private; This patch has a dependency to [1] which is waiting for new version, right? Please note these kind of dependencies after "---" part of the commit log. [1] https://patches.dpdk.org/patch/46185/