From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3151BC433F5 for ; Wed, 19 Jan 2022 15:41:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355847AbiASPle (ORCPT ); Wed, 19 Jan 2022 10:41:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355529AbiASPla (ORCPT ); Wed, 19 Jan 2022 10:41:30 -0500 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BC3BC061574; Wed, 19 Jan 2022 07:41:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=pxPDysxsLzRS9m3h8MM0+hZnUy5KDuxOZAnHkZ+LiUU=; b=P6ZwT2AKXUwgwui+4YXZ3+S5JB aHNGnZbcF7P0JjQ2N9a3uww5zTv3szmJXvjflxI/R9cm4iHHtjkTZlZZnN7sPr7B+1C6nCW3p0fqX DYFOssgLzTGUjKwS6687wmMBof+9C3nc7L2X+Ie0WIui7iCrANpuwmi9xVW2ufFYlQIuY4UQusx9I aK7D6KPidQ0p0zcs86E7CjnpH2pWzCpNCPEf30CwVb0ikL3hGDBb+Iqwm4CoClWea/Kn28LragZYK sr7sXjUvS/ffkG8+oNECDa6fOeeafsWYlPwh6Kmn96xrLnm5RgXLjTPl+64wXXpx/WxZoNk1VVkXg ++56dLGA==; Received: from [2601:1c0:6280:3f0::aa0b] by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nAD4n-0026rA-0b; Wed, 19 Jan 2022 15:40:45 +0000 Message-ID: Date: Wed, 19 Jan 2022 07:40:30 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [RFC 2/6] cgroup: gpu: Add a cgroup controller for allocator attribution of GPU memory Content-Language: en-US To: Hridya Valsaraju , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Jonathan Corbet , Greg Kroah-Hartman , =?UTF-8?Q?Arve_Hj=c3=b8nnev=c3=a5g?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Suren Baghdasaryan , Sumit Semwal , Benjamin Gaignard , Liam Mark , Laura Abbott , Brian Starkey , John Stultz , =?UTF-8?Q?Christian_K=c3=b6nig?= , Tejun Heo , Zefan Li , Johannes Weiner , Dave Airlie , Rodrigo Vivi , Matthew Auld , Matthew Brost , Li Li , Marco Ballesio , Hang Lu , Wedson Almeida Filho , Masahiro Yamada , Andrew Morton , Nathan Chancellor , Kees Cook , Nick Desaulniers , Miguel Ojeda , Vipin Sharma , Chris Down , Daniel Borkmann , Vlastimil Babka , Arnd Bergmann , dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, cgroups@vger.kernel.org Cc: Kenny.Ho@amd.com, daniels@collabora.com, kaleshsingh@google.com, tjmercier@google.com References: <20220115010622.3185921-1-hridya@google.com> <20220115010622.3185921-3-hridya@google.com> From: Randy Dunlap In-Reply-To: <20220115010622.3185921-3-hridya@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi-- On 1/14/22 17:06, Hridya Valsaraju wrote: > diff --git a/init/Kconfig b/init/Kconfig > index cd23faa163d1..408910b21387 100644 > --- a/init/Kconfig > +++ b/init/Kconfig > @@ -990,6 +990,13 @@ config BLK_CGROUP > > See Documentation/admin-guide/cgroup-v1/blkio-controller.rst for more information. > > +config CGROUP_GPU > + bool "gpu cgroup controller (EXPERIMENTAL)" > + select PAGE_COUNTER > + help > + Provides accounting and limit setting for memory allocations by the GPU > + and GPU-related subsystems. Please follow coding-style for Kconfig files: (from Documentation/process/coding-style.rst, section 10): For all of the Kconfig* configuration files throughout the source tree, the indentation is somewhat different. Lines under a ``config`` definition are indented with one tab, while help text is indented an additional two spaces. thanks. -- ~Randy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C184C433EF for ; Wed, 19 Jan 2022 16:08:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9FCFB10E28B; Wed, 19 Jan 2022 16:08:39 +0000 (UTC) X-Greylist: delayed 1630 seconds by postgrey-1.36 at gabe; Wed, 19 Jan 2022 16:08:38 UTC Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by gabe.freedesktop.org (Postfix) with ESMTPS id BFEDD10E28B for ; Wed, 19 Jan 2022 16:08:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=pxPDysxsLzRS9m3h8MM0+hZnUy5KDuxOZAnHkZ+LiUU=; b=P6ZwT2AKXUwgwui+4YXZ3+S5JB aHNGnZbcF7P0JjQ2N9a3uww5zTv3szmJXvjflxI/R9cm4iHHtjkTZlZZnN7sPr7B+1C6nCW3p0fqX DYFOssgLzTGUjKwS6687wmMBof+9C3nc7L2X+Ie0WIui7iCrANpuwmi9xVW2ufFYlQIuY4UQusx9I aK7D6KPidQ0p0zcs86E7CjnpH2pWzCpNCPEf30CwVb0ikL3hGDBb+Iqwm4CoClWea/Kn28LragZYK sr7sXjUvS/ffkG8+oNECDa6fOeeafsWYlPwh6Kmn96xrLnm5RgXLjTPl+64wXXpx/WxZoNk1VVkXg ++56dLGA==; Received: from [2601:1c0:6280:3f0::aa0b] by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nAD4n-0026rA-0b; Wed, 19 Jan 2022 15:40:45 +0000 Message-ID: Date: Wed, 19 Jan 2022 07:40:30 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [RFC 2/6] cgroup: gpu: Add a cgroup controller for allocator attribution of GPU memory Content-Language: en-US To: Hridya Valsaraju , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Jonathan Corbet , Greg Kroah-Hartman , =?UTF-8?Q?Arve_Hj=c3=b8nnev=c3=a5g?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Suren Baghdasaryan , Sumit Semwal , Benjamin Gaignard , Liam Mark , Laura Abbott , Brian Starkey , John Stultz , =?UTF-8?Q?Christian_K=c3=b6nig?= , Tejun Heo , Zefan Li , Johannes Weiner , Dave Airlie , Rodrigo Vivi , Matthew Auld , Matthew Brost , Li Li , Marco Ballesio , Hang Lu , Wedson Almeida Filho , Masahiro Yamada , Andrew Morton , Nathan Chancellor , Kees Cook , Nick Desaulniers , Miguel Ojeda , Vipin Sharma , Chris Down , Daniel Borkmann , Vlastimil Babka , Arnd Bergmann , dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, cgroups@vger.kernel.org References: <20220115010622.3185921-1-hridya@google.com> <20220115010622.3185921-3-hridya@google.com> From: Randy Dunlap In-Reply-To: <20220115010622.3185921-3-hridya@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kenny.Ho@amd.com, daniels@collabora.com, tjmercier@google.com, kaleshsingh@google.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi-- On 1/14/22 17:06, Hridya Valsaraju wrote: > diff --git a/init/Kconfig b/init/Kconfig > index cd23faa163d1..408910b21387 100644 > --- a/init/Kconfig > +++ b/init/Kconfig > @@ -990,6 +990,13 @@ config BLK_CGROUP > > See Documentation/admin-guide/cgroup-v1/blkio-controller.rst for more information. > > +config CGROUP_GPU > + bool "gpu cgroup controller (EXPERIMENTAL)" > + select PAGE_COUNTER > + help > + Provides accounting and limit setting for memory allocations by the GPU > + and GPU-related subsystems. Please follow coding-style for Kconfig files: (from Documentation/process/coding-style.rst, section 10): For all of the Kconfig* configuration files throughout the source tree, the indentation is somewhat different. Lines under a ``config`` definition are indented with one tab, while help text is indented an additional two spaces. thanks. -- ~Randy