From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [PATCH 0/2] nvme: Improvements in sysfs entry for NVMe CMBs To: Stephen Bates , linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org References: <1481914491-21456-1-git-send-email-sbates@raithlin.com> Cc: sagi@grimberg.me, james_p_freyensee@linux.intel.com, jonathan.derrick@intel.com From: Jens Axboe Message-ID: Date: Mon, 19 Dec 2016 08:36:48 -0700 MIME-Version: 1.0 In-Reply-To: <1481914491-21456-1-git-send-email-sbates@raithlin.com> Content-Type: text/plain; charset=windows-1252 List-ID: On 12/16/2016 11:54 AM, Stephen Bates wrote: > Hi > > This series adds some more verbosity to the NVMe CMB sysfs entry. > > Jens I based this off v4.9 because for some reason your for-4.10/block > is missing my original CMB commit (202021c1a63c6)? > > Stephen > > Stephen Bates (2): > nvme : Use correct scnprintf in cmb show > nvme: improve cmb sysfs reporting > > drivers/nvme/host/pci.c | 33 ++++++++++++++++++++++++++++++--- > include/linux/nvme.h | 8 ++++++++ > 2 files changed, 38 insertions(+), 3 deletions(-) I have added 1/2, since that one is a no-brainer. For 2/2, not so sure. Generally we try to avoid having sysfs file that aren't single value output. That isn't a super hard rule, but it is preferable. -- Jens Axboe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756218AbcLSPh4 (ORCPT ); Mon, 19 Dec 2016 10:37:56 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:41631 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755534AbcLSPhv (ORCPT ); Mon, 19 Dec 2016 10:37:51 -0500 Subject: Re: [PATCH 0/2] nvme: Improvements in sysfs entry for NVMe CMBs To: Stephen Bates , , , References: <1481914491-21456-1-git-send-email-sbates@raithlin.com> CC: , , From: Jens Axboe Message-ID: Date: Mon, 19 Dec 2016 08:36:48 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1481914491-21456-1-git-send-email-sbates@raithlin.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [66.29.164.166] X-ClientProxiedBy: MWHPR20CA0023.namprd20.prod.outlook.com (10.171.151.161) To BN6PR15MB1185.namprd15.prod.outlook.com (10.172.205.139) X-MS-Office365-Filtering-Correlation-Id: 3d958b5e-5f6c-4614-4cc2-08d42824dd38 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BN6PR15MB1185; X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1185;3:cs8kIUXxZR+kEyotzoFGIT+eSb+q2zzr4ZQEdykgKqRuVKvffiR99NQ8WB07FgVsTxMtLO3WuXK8oauP4s/mIhHE4E3xZ+LW3s+T0eCskHSM5WSC8yH8IY+CqFSBnl7ONEcfdYh8BrOBmFTCWkU4nCD+J2XvHRRxDqu9iqVWZoDBzUE9VWVXUPclhYKlgghiQKQIce5A37f3Dz3stfePEH7wwybcDxHzel7RCLCHATm3ZQUnY25ZBa/eoQx5xtC8FaUtFCOflovcbsa/WcSGjQ== X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1185;25:JtUJV9/y2W8dxyozEYGBREQk7ouDgiprrRUBScklhLjR0xg7j9j4S2S2MLnHwSQCagkktNYKP9HO12xke4ZfH219ZAaTzC/SiEuyRActLS/A9WULjSdxXZRwgOHrqUS9yQEzXV3NoYydZSr072F2SCzJd9PMiylQclZkGJP4J/hd7E4zQFd68uZkXNxKXq/1R4xygmPrTN2ngKsTM4plmebokBeA2eYejgUaZMejKwni/M1a7FUZrLk4V3fbS+NUEjva2Q2/0xlAqa9eiN0ssgckOgy6o2Y0/IePe81vStssfpr0hTeKokrR4Fg266o3h8iVZc/Va1VkXmYIn6zI3Qr2qfyaYsW9MtlsIj8kTaYyqwfBJLs6CLXfHwTpi5mYzGUy42kgkpt/1X8A96uR3+fp3NbPyqLha6YX2jibXUL7vats8QdK1uX7anb4B3u2vODL13e4fzuLHl4eJUf4ON9iUzT3be9bNU/dBBF6sfSOoFd/nvgI0aHBwUPe+8xhxq5neqwCBHaE3MYilC4FzKkVG6N6u94OoPCdDGsyCsV/qsA2qKEMmCH+Fjg4Th7LQSxf3ia7RZ6BYG/QK7opflkqouyFlQ3deO2JHNKzfZY2+CN9SMY3nPj9sBHwuGPnFM1t956KDwL4znKEQLzqBkwaibtGGKzDUf8Phm9uWcHxzy9jNV4kWmJ2ThAqJ14Gr/05q708nJsf8RvGHQ5c9QOBYXEgBr90nwY+gx42fE3XjoS73hidu78PqwaRDIYX X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1185;31:iQkrJSLrsCYr53AqdrS/FgA0+vtonEHM8FN7CjehhgLuPSmb7tSgcp0eBxjLGnauhXYhIE+3KOw6Bwp8MfO4gZp89epRbQCnprrNjrec1eCJ7FKS6vJ1xnllv+TikcsxkjYicE2BSuDd742sPz/IjUg16k8HnyrX+ILFmWMZqWCzXagVCDy5S8JOhuyPdSZdTbuZ4iuyzEJirhnSbrEE0lbQjcObL4s+jyK/ILDM16i2mG634tNoJjHz1Wl2cPCXkTwS0QqVe5IYem0sJqbn2w==;20:qGhoej5OxNVvEBRtWw3GSdCeP3uPtbQ7isCA2lvtb/6XkcLmZchAHC87eua6rEfk9auHiGUgWLyaoVd/Q9E7mtA/x28bpxA4is7S1A0v4XJU1uaJsjorU5VSZy0JazwvZoy3wGa2Y5Ol4YRR4RmFFsslYbzr1TCcEMpJHXfOfOaQA/TO8uIn7F7Qqbr6vroa6Zn6De4OJbMJRiBpWw6cZtdm3PbPUlzKlbQE6zI+aeIlFOIE81hyRGn0/y9Q2e3/xupbGvyCjtJ3mQc6R11jg0MP24h7VMdH1LK1FxlgQN8SqWBL3i58TH4hyIydCd++7ANS1CUg02k4WvQoGHuWanJFDH5vA8hBJvb5g780PBnzST9i2jYhP3Nk5T0pScuu8hTjvqlp8hk23fbkCOzvBIxmNKIi4TMerAY+VKT7Prr1E2TLz3n5Z+TLirHZmf3FMFVV5VGZZpUBKZBwI1/PbeWrknbqroChSeAZPBXm4E+kNLsvBWOZFn+ZWPAzglE3 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(211171220733660); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123555025)(20161123560025)(20161123564025)(20161123562025)(6072148);SRVR:BN6PR15MB1185;BCL:0;PCL:0;RULEID:;SRVR:BN6PR15MB1185; X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1185;4:MBrbJGbJS2MFFpVKkT3IYYr2P2f3gTMAG+oi2qtQHaM9w7AZQ/lVq6l0uncN1g5Pxm1l46Z3KvMFbY7kbHHVDgpoH1KHk6EtAxxsoHwYgKxOw+rOfdME4isTazdrf3iGNFevrr17LTnaDJBCfUlSlgAbmBluVlmCEBhA6yDAGxxyoOr5BQfeuga1I3lcg/HJL/8NNk7dA2DkVyLXpnlcwkyN8oN7pApnJA9qcZt22gxKtZFBfpkzOLPvkOTX+g8jUpta9VWNfnK/7bylSrQC/zfnWwh440T2E/JgAWq7tETSLDcckBRyKdHOvJOx1fju48hfLm/i+xMBwdjJwAOvT4nHj+uTGqfTWonkm3iBMbBovLYZtmVsnHIfCcTxcdUCa8tbCY3JCok6VGu+Z3imtzy0aVRK/8LBXoYRFiDnRWDYSj/xgJaImlb1ppuO4pXVpMCaYxXVZakgzrgnWHJ370uaFlSiIDqANFkYJzi3o7105L0AThObL3uk7JMycXYy/TXm8/pSrAHtoDECFePq4WdkBVjs/XRfo3XjIQVPq3bLhOd6Y84eTvK14FQHkDQZXolJ3EarxkDgKgnmobePsR2dn4TPRqrv80sPqnANtlHTZ6lQgA1f2IY9SvknY7F0 X-Forefront-PRVS: 01613DFDC8 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(39450400003)(24454002)(199003)(377454003)(189002)(92566002)(38730400001)(189998001)(23746002)(7736002)(4326007)(229853002)(31696002)(97736004)(305945005)(2906002)(6116002)(86362001)(64126003)(5001770100001)(3846002)(5660300001)(83506001)(54356999)(65806001)(105586002)(65956001)(66066001)(68736007)(90366009)(101416001)(50466002)(76176999)(106356001)(50986999)(25786008)(77096006)(117156001)(4001350100001)(8676002)(230700001)(2201001)(33646002)(36756003)(47776003)(31686004)(42186005)(6486002)(65826007)(2950100002)(6666003)(81156014)(81166006)(2101003);DIR:OUT;SFP:1102;SCL:1;SRVR:BN6PR15MB1185;H:[192.168.1.176];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BN6PR15MB1185;23:EOJUym8HZBTru5lGK+NEhUiZ0VaR2XbhmUF/e?= =?Windows-1252?Q?tpw6a+forgUnfyr2zXVmiF8o/siT4Vv1PwrYg5qF/+m1zpFUAyW0diLr?= =?Windows-1252?Q?uP4ehQgPWTUodj8zhqTvRoDS6FUaPs/q8f84D0F528uRo9FW8P8Iv504?= =?Windows-1252?Q?9cIVMP0RnB0xyph8tMRUqqw/zW0FLhwiHQHa74xBfr3TGSNbQTB94iZM?= =?Windows-1252?Q?2OfZWNIJxYLaWyNiYpk55oSO5+fXidrI4Gwc+x3blXw0hzbTVwscORF5?= =?Windows-1252?Q?vvt+gWn0fDJgQ4ZPryzevsfs8dQPn6gAGXQNsw2MmKECqi2XElpdMvUd?= =?Windows-1252?Q?DbOrTE4XuvRNOZK/Dpw6ho2H7hva/5IPDIB+dpHW25nnmhQRkEgTjFiB?= =?Windows-1252?Q?DaTsqPTs0tVFejJXopJIH9SYsUHoDmoTf2q3QAKa+DfCJH4VvZTzu01V?= =?Windows-1252?Q?y0wCrbUdnW3923dCYoDlj7lx8PxAy/LVzU9QMss3YFkVycayY1fQzMaf?= =?Windows-1252?Q?j/sWKH3pnz1f3BSIed28fUbSwsWURnVS8jeQQRmu1gqghnmYYFwPEwDj?= =?Windows-1252?Q?+aKVolGipINpeB2MSoZO8TVzeVkv+4r6ySFLGrjr1Ro3DdAUmTZdWgjK?= =?Windows-1252?Q?SobzsAM/gWHpU5jVpuT5GdgQrwFx/dj/bIjfe6zkl1H3HuBa9EVEOT88?= =?Windows-1252?Q?UwqvxFKRtXn0NqeDS7OURKzmkn248cBlhjUzwvniyVpXRTvIwAOHbrnd?= =?Windows-1252?Q?ky8mUf7s7x7uGT2LuPWQnkfEL1OZr9j8aS90cPGeniWhzAnNbcL8m+q4?= =?Windows-1252?Q?GeKC5XUu+8QsTyDNylCU4dWXSaySAKmMpA8G0VsHE35S8PpzKC/KMsH+?= =?Windows-1252?Q?yovFptcoV0ELsJ/PqTQHxIoYLRfanrxVB4jAQzg1EHkf7II8SM4kF8Tz?= =?Windows-1252?Q?7SgxiY1iRRsUVjnfEbIoW96VoBS5wYOSpLEvcXLTVJiJlVdea4cB7L7t?= =?Windows-1252?Q?JcGgaIyIt2JCQcd3jhif3MzFpiwjyPrZ8cthQXejRigJXNh+qCRQ1wMA?= =?Windows-1252?Q?zIoG+IRAB+3Y+KnT9PUTvi1m+WCGUWu6YzuI/O1gqbUCZB1pgK7s+RWb?= =?Windows-1252?Q?VU0CYtPaNozfcmBR1yDIl9uY4PbNUyfVbGT5O+nMnQJbCdoDSSDV/RuZ?= =?Windows-1252?Q?N2yBKoaNfCEOE3oSaHSiNWqP2vK1GCFbKUdbyn8bTeRF8wkptf/OO0dJ?= =?Windows-1252?Q?6FNjhUINO5g0KYuurE8UwuCwsvt8U5tYD9c1IpLEJpbOgT0DzEE3bIuH?= =?Windows-1252?Q?WtgfbINn8uQBSdjDKpOZ4NpYDxUm+IJYzR5J+Z7aL4dYCWrZXUCfyZjY?= =?Windows-1252?Q?khQx1Sb/vEKm/DBFhqtfCp84FSJi8Jcc2ODR6iiY3Ywu1EUspaRvgsxP?= =?Windows-1252?Q?vh3PSujLaFrMw78rHVX/AmivfT1APjL9gSzyLocWXIxTBYHms2LStoEp?= =?Windows-1252?Q?5Zgshmu5LLcQqtkoOuaDIj3wWpT?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1185;6:bJNlrKbPDRmSHUGBstUVbrVd5wvnPe9Z+feDz90jnsLubCdfTIzc1uM7XgupsaYOro49ta3Y21f+jthLSBPFrcfEaRqzdLe9l1vXwmCgTqj/2kag7SVWZ57/Sed9ZAqacUaeMbWJcsUpueMh0Zp5Oca8uxvuBSLivV7lFO7unv8IFe1mBjkREWxYyXvs6qexFvRRWm36B+0gtPADHKJusVya2f7BI+sX8OkjALLtwUE3vTrdKxl5D9sbyihykcOI8YDhCx/3LtymY61selpivCIfGZrwlTrhojuk2S4lP0pMvl5G98Pfqcy0zQY7kPCeq5ZU8Kxzp+8AcTAZN7xwVKi3wv+m93l7EpbW1e7aN63hQGUAsUuJSm6Rk9q56QxQ3YZuX4A3JsFmo4I+8nnlfuUhERMcTfnPLDbM/7Cn13I=;5:pYiitMHdySLScRhegMiV54fxPk3Ic76QAsGJP0AFipc7fiKfTIAJSjivM5A1Xh4iTtosTtqOT0T0iAEqBXFOIoSk096uGMvzNZOQuZOlIhHfZ1AFWBMzRHWdglxw3FwtRRDJ1Pt+c6Rx2ktXm/YS3A==;24:aWUT/3GBudk+7Ky5LC9b0fCO9i/5g9wHxVE8UeBmu6QEtDOuVa/A2TuM/73CWagUz1QQrmX9vdWddPa4FsbJhAB/ZiiO9b4Q8Z8XBlOsMhs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1185;7:DoNIp2gFDCAEKCrGkOUpgbz5UPTuOLQEI+1Ud4r7Iry9d3oDEfEnEm0b/6+wfTzL8Wqye7tg8HLM/TF2/xpWrUluIV6G8sHUs4qSe7T7AZ3Ocds6Ks/BOlPTv3YyyS1VAGNETMtcuOrQyEQapQW8QrkuJrqLjjOT7QWijweFJUXhmOUhzYWSzM4Nm+YOI5w1nvg0Epp+z9ykS4Ol7+VCUG6SviGNLwOMIKE/vVedHs4frjBtw6vL6VJWfkRd8KNvJRZB+lU442RTqG2Nsns6T2XcrCQ6zaq6VA66Aoqq3L2WE1F3g7VCulVGjVOEEcC67Kh4WFlhVv27T96K/Ems3ry9c59t9SuqOvc5yyjJ20q6hi3R4uomBiVJ+UZvZBrTAnTEYkXxuDqHcWxge/+moF5xqGYMxOUZAPBC49qrccVf6hgtHykg8a5dJmWuJFaKpZCYK/ZNJcLN8a0PQfe/5w==;20:SPcWrp2sMiowE2j5dN0R09aQD0fcB3toMyVxTrJxzb6EZ1Jna2FcgyZ9GQDMp+l/kSGjk/VyzvHGBlIRgkV/0t9T/BB8sA8VlddoUeoL1naNND4Rt+e9RM6OO1u4c//b5oNrwOyPueRdv1s5KTMPFzy2kHBvcivyf55FC98eH0Q= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2016 15:36:54.5887 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR15MB1185 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-12-19_11:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/16/2016 11:54 AM, Stephen Bates wrote: > Hi > > This series adds some more verbosity to the NVMe CMB sysfs entry. > > Jens I based this off v4.9 because for some reason your for-4.10/block > is missing my original CMB commit (202021c1a63c6)? > > Stephen > > Stephen Bates (2): > nvme : Use correct scnprintf in cmb show > nvme: improve cmb sysfs reporting > > drivers/nvme/host/pci.c | 33 ++++++++++++++++++++++++++++++--- > include/linux/nvme.h | 8 ++++++++ > 2 files changed, 38 insertions(+), 3 deletions(-) I have added 1/2, since that one is a no-brainer. For 2/2, not so sure. Generally we try to avoid having sysfs file that aren't single value output. That isn't a super hard rule, but it is preferable. -- Jens Axboe From mboxrd@z Thu Jan 1 00:00:00 1970 From: axboe@fb.com (Jens Axboe) Date: Mon, 19 Dec 2016 08:36:48 -0700 Subject: [PATCH 0/2] nvme: Improvements in sysfs entry for NVMe CMBs In-Reply-To: <1481914491-21456-1-git-send-email-sbates@raithlin.com> References: <1481914491-21456-1-git-send-email-sbates@raithlin.com> Message-ID: On 12/16/2016 11:54 AM, Stephen Bates wrote: > Hi > > This series adds some more verbosity to the NVMe CMB sysfs entry. > > Jens I based this off v4.9 because for some reason your for-4.10/block > is missing my original CMB commit (202021c1a63c6)? > > Stephen > > Stephen Bates (2): > nvme : Use correct scnprintf in cmb show > nvme: improve cmb sysfs reporting > > drivers/nvme/host/pci.c | 33 ++++++++++++++++++++++++++++++--- > include/linux/nvme.h | 8 ++++++++ > 2 files changed, 38 insertions(+), 3 deletions(-) I have added 1/2, since that one is a no-brainer. For 2/2, not so sure. Generally we try to avoid having sysfs file that aren't single value output. That isn't a super hard rule, but it is preferable. -- Jens Axboe