From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F03EFC43334 for ; Fri, 24 Jun 2022 10:35:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229834AbiFXKfc (ORCPT ); Fri, 24 Jun 2022 06:35:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229699AbiFXKfb (ORCPT ); Fri, 24 Jun 2022 06:35:31 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B13C7C841 for ; Fri, 24 Jun 2022 03:35:28 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id ge10so3804029ejb.7 for ; Fri, 24 Jun 2022 03:35:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=GeySHEpfB0/asXQLszsfiLjDcMnpUMVH0jqVoWkX/7o=; b=uZ1wC8VHxURHrghX2//skAqQ30um2Rme3cIPNULf/p3DBJwzdeGZCHn64BbW1bwOoh MK7I4FRm4lPVfnOutTChG+9M+lYc4y4yEjHQmcsNNibkepmTc5kqbxTtx/VHfIwqpSFA A7a2fOZ7cvl48zaPYnFMhKsgQgSk6uKOAABQ6m5HcNHn+pYfMPqsOfrhh43gWvLbEKIG AMwez5zF4oib8KlCHUoPbdzUVBf2Mmj6iqKOZO4I2HmkzMfM5iXV86deY5+S7vEL+BT9 wv3F9Puov/5GuHxXic5VvIIGs7RASkq12ilmGiKxF+k5qkfHOarvRWT8G3ev/yK3xUvF FD0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=GeySHEpfB0/asXQLszsfiLjDcMnpUMVH0jqVoWkX/7o=; b=gkAKXf5rXefcQBfeyJJympJjvN0ZG5DETBEzEMVDYvssOmIPw+4fJhhZGFE4esmqUU L1hNUKJesfa5qwdZmYAIoJrac1Ra3rDGFE/x5coBHnS22T35xCwUbv7uhX99lEGd45w+ XFqZjllfo1ZlckQ8LXilTURhzhj6k6VfwMRq3urBYxGNWYwfbCf1KWz3cctU7czN6Qhc q6eePgUm2XUPMSrB+YqKYBw39cRS42kIuFdVLX9jijjXPkljfOocXA4RoPyYq1MDirbk 2T82zyN7Qgz1HDoIuJD8vPFkkKJyv9QfNyJmqITunjjYGZG2ZXrBpaUEjfzpjGuO8/SY RF6Q== X-Gm-Message-State: AJIora9av9QIrXW6XFIijlEGl3uVmDOV7FbeLGYdIUmdQUnqCKmNuVj/ k0pbQZAXZpD9pR8TRzsVuhDLCg== X-Google-Smtp-Source: AGRyM1sqyv+H/bBGuPYg4PIFRLo9cOE04f0nH/20g7zmKiDRIOyqtdjIViwQXday1ZlmdpGjP7k8OA== X-Received: by 2002:a17:907:1694:b0:716:14a4:fba with SMTP id hc20-20020a170907169400b0071614a40fbamr13073900ejc.290.1656066926720; Fri, 24 Jun 2022 03:35:26 -0700 (PDT) Received: from [192.168.0.234] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id q21-20020aa7cc15000000b0042617ba638esm1683916edt.24.2022.06.24.03.35.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Jun 2022 03:35:25 -0700 (PDT) Message-ID: Date: Fri, 24 Jun 2022 12:35:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v3 03/14] dt-bindings: leds: mt6370: Add Mediatek mt6370 current sink type LED indicator Content-Language: en-US To: ChiaEn Wu , lee.jones@linaro.org, daniel.thompson@linaro.org, jingoohan1@gmail.com, pavel@ucw.cz, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, sre@kernel.org, chunfeng.yun@mediatek.com, gregkh@linuxfoundation.org, jic23@kernel.org, lars@metafoo.de, lgirdwood@gmail.com, broonie@kernel.org, linux@roeck-us.net, heikki.krogerus@linux.intel.com, deller@gmx.de Cc: chiaen_wu@richtek.com, alice_chen@richtek.com, cy_huang@richtek.com, dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, linux-iio@vger.kernel.org, linux-fbdev@vger.kernel.org, szunichen@gmail.com References: <20220623115631.22209-1-peterwu.pub@gmail.com> <20220623115631.22209-4-peterwu.pub@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20220623115631.22209-4-peterwu.pub@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On 23/06/2022 13:56, ChiaEn Wu wrote: > From: ChiYuan Huang > > Add Mediatek mt6370 current sink type LED indicator binding documentation. > > Signed-off-by: ChiYuan Huang > --- > > v3 > - Use leds-class-multicolor.yaml instead of common.yaml. > - Split multi-led and led node. > - Add subdevice "led" in "multi-led". > --- > .../bindings/leds/mediatek,mt6370-indicator.yaml | 77 ++++++++++++++++++++++ > 1 file changed, 77 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml > > diff --git a/Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml b/Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml > new file mode 100644 > index 0000000..45030f3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml > @@ -0,0 +1,77 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/leds/mediatek,mt6370-indicator.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: LED driver for MT6370 PMIC from MediaTek Integrated. > + > +maintainers: > + - Alice Chen > + > +description: | > + This module is part of the MT6370 MFD device. > + Add MT6370 LED driver include 4-channel RGB LED support Register/PWM/Breath Mode > + > +allOf: > + - $ref: leds-class-multicolor.yaml# > + > +properties: > + compatible: > + const: mediatek,mt6370-indicator > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > +patternProperties: > + "^multi-led@[0-3]$": > + type: object Here as well unevaluatedProperties:false (on the type level) > + > + properties: > + reg: > + enum: [0, 1, 2, 3] > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > + patternProperties: > + "^led@[0-2]$": > + type: object > + $ref: common.yaml# > + unevaluatedProperties: false > + > + required: > + - reg > + - color > + > + required: > + - reg > + - color > + - "#address-cells" > + - "#size-cells" > + > + "^led@[0-3]$": > + type: object > + $ref: common.yaml# > + unevaluatedProperties: false > + > + properties: > + reg: > + enum: [0, 1, 2, 3] > + > + required: > + - reg > + - color > + > +required: > + - compatible > + - "#address-cells" > + - "#size-cells" > + > +additionalProperties: false Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22ECFC43334 for ; Fri, 24 Jun 2022 10:35:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1F46910E68A; Fri, 24 Jun 2022 10:35:29 +0000 (UTC) Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 46B4510E525 for ; Fri, 24 Jun 2022 10:35:28 +0000 (UTC) Received: by mail-ej1-x62f.google.com with SMTP id sb34so3760950ejc.11 for ; Fri, 24 Jun 2022 03:35:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=GeySHEpfB0/asXQLszsfiLjDcMnpUMVH0jqVoWkX/7o=; b=uZ1wC8VHxURHrghX2//skAqQ30um2Rme3cIPNULf/p3DBJwzdeGZCHn64BbW1bwOoh MK7I4FRm4lPVfnOutTChG+9M+lYc4y4yEjHQmcsNNibkepmTc5kqbxTtx/VHfIwqpSFA A7a2fOZ7cvl48zaPYnFMhKsgQgSk6uKOAABQ6m5HcNHn+pYfMPqsOfrhh43gWvLbEKIG AMwez5zF4oib8KlCHUoPbdzUVBf2Mmj6iqKOZO4I2HmkzMfM5iXV86deY5+S7vEL+BT9 wv3F9Puov/5GuHxXic5VvIIGs7RASkq12ilmGiKxF+k5qkfHOarvRWT8G3ev/yK3xUvF FD0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=GeySHEpfB0/asXQLszsfiLjDcMnpUMVH0jqVoWkX/7o=; b=b5uGI88MMJD/dv5GHLyPRFF+g7aLqRw24rdkbyXEGPQ1uubn/so2jb+g7eACOuX4k+ 7Ha0ygT7CM7eBx1bnRRKo/vqjFzjgw0Ln629ixTk6AxT8Bem0VM8NMymVzVaDU2kokbo 6TehkaPl52Zi7fVXBt/Q1srh6h3g07CMbyqzpQ+gKYjz6Rsr/6k2nt0EvpnqVVxDZlY2 JoN7e11M4pLigAZiZwwNdh+Yt7I65MR15bzw8QugDkve+jD/MrUczw6KQeyw5w5aNGp8 DLrt3UJC5kxLqP3c5K/xqB4+xSj1GCJ5UI3MFHXeI4xybP1KuJtQkSJCUQRoSnnqf3bZ 8tLg== X-Gm-Message-State: AJIora/r2BpxY5QTK0FG+g3CUqOu4EpVeLtWNzS8yOrV0IOGnCJu2ZNs DMqo0EQYMJJv3MAcVz8o4W9t2Q== X-Google-Smtp-Source: AGRyM1sqyv+H/bBGuPYg4PIFRLo9cOE04f0nH/20g7zmKiDRIOyqtdjIViwQXday1ZlmdpGjP7k8OA== X-Received: by 2002:a17:907:1694:b0:716:14a4:fba with SMTP id hc20-20020a170907169400b0071614a40fbamr13073900ejc.290.1656066926720; Fri, 24 Jun 2022 03:35:26 -0700 (PDT) Received: from [192.168.0.234] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id q21-20020aa7cc15000000b0042617ba638esm1683916edt.24.2022.06.24.03.35.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Jun 2022 03:35:25 -0700 (PDT) Message-ID: Date: Fri, 24 Jun 2022 12:35:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v3 03/14] dt-bindings: leds: mt6370: Add Mediatek mt6370 current sink type LED indicator Content-Language: en-US To: ChiaEn Wu , lee.jones@linaro.org, daniel.thompson@linaro.org, jingoohan1@gmail.com, pavel@ucw.cz, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, sre@kernel.org, chunfeng.yun@mediatek.com, gregkh@linuxfoundation.org, jic23@kernel.org, lars@metafoo.de, lgirdwood@gmail.com, broonie@kernel.org, linux@roeck-us.net, heikki.krogerus@linux.intel.com, deller@gmx.de References: <20220623115631.22209-1-peterwu.pub@gmail.com> <20220623115631.22209-4-peterwu.pub@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20220623115631.22209-4-peterwu.pub@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-fbdev@vger.kernel.org, szunichen@gmail.com, alice_chen@richtek.com, linux-pm@vger.kernel.org, linux-iio@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, cy_huang@richtek.com, chiaen_wu@richtek.com, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-leds@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 23/06/2022 13:56, ChiaEn Wu wrote: > From: ChiYuan Huang > > Add Mediatek mt6370 current sink type LED indicator binding documentation. > > Signed-off-by: ChiYuan Huang > --- > > v3 > - Use leds-class-multicolor.yaml instead of common.yaml. > - Split multi-led and led node. > - Add subdevice "led" in "multi-led". > --- > .../bindings/leds/mediatek,mt6370-indicator.yaml | 77 ++++++++++++++++++++++ > 1 file changed, 77 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml > > diff --git a/Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml b/Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml > new file mode 100644 > index 0000000..45030f3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml > @@ -0,0 +1,77 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/leds/mediatek,mt6370-indicator.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: LED driver for MT6370 PMIC from MediaTek Integrated. > + > +maintainers: > + - Alice Chen > + > +description: | > + This module is part of the MT6370 MFD device. > + Add MT6370 LED driver include 4-channel RGB LED support Register/PWM/Breath Mode > + > +allOf: > + - $ref: leds-class-multicolor.yaml# > + > +properties: > + compatible: > + const: mediatek,mt6370-indicator > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > +patternProperties: > + "^multi-led@[0-3]$": > + type: object Here as well unevaluatedProperties:false (on the type level) > + > + properties: > + reg: > + enum: [0, 1, 2, 3] > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > + patternProperties: > + "^led@[0-2]$": > + type: object > + $ref: common.yaml# > + unevaluatedProperties: false > + > + required: > + - reg > + - color > + > + required: > + - reg > + - color > + - "#address-cells" > + - "#size-cells" > + > + "^led@[0-3]$": > + type: object > + $ref: common.yaml# > + unevaluatedProperties: false > + > + properties: > + reg: > + enum: [0, 1, 2, 3] > + > + required: > + - reg > + - color > + > +required: > + - compatible > + - "#address-cells" > + - "#size-cells" > + > +additionalProperties: false Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F108C43334 for ; Fri, 24 Jun 2022 10:36:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xfFucHCNiR8Ss5/oBKiF5PoP7xt+c1+Is2CeD+3OnKo=; b=DjB2HxOpiwB2BQ xJpUJEvzfTtgW71+tlQ51uNLvIK8lAs+0Q1BegEg79CtHhLSfZUauQIff0VrTlMjmt5rSEHOOI+tV 1zY698A5KiGiAqA8pdJ5uEJNum/gPiIhvzQvYsVS1zKFecFI1s1mtWkPAgIPzjjow4/I/JBo6R3YT yS4LrVCvEFulxqSIyXKHoZO48I52eifdNQ6XnFviwLO5DXX8gSmRlO/EF1j/ULZLOMwtNvu6+je+W qFKVQm3FCM3BUgEOM76ahdnMetAegpb+sXPgzi02nM9620LKFseg7S+vw6vvyzAukjTwyJyRYSBNN 6IxEj5hQBIPkwKnnbz/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4gez-001nuo-Qp; Fri, 24 Jun 2022 10:35:34 +0000 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4gew-001nsw-Ad for linux-arm-kernel@lists.infradead.org; Fri, 24 Jun 2022 10:35:31 +0000 Received: by mail-ej1-x633.google.com with SMTP id u15so3774564ejc.10 for ; Fri, 24 Jun 2022 03:35:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=GeySHEpfB0/asXQLszsfiLjDcMnpUMVH0jqVoWkX/7o=; b=uZ1wC8VHxURHrghX2//skAqQ30um2Rme3cIPNULf/p3DBJwzdeGZCHn64BbW1bwOoh MK7I4FRm4lPVfnOutTChG+9M+lYc4y4yEjHQmcsNNibkepmTc5kqbxTtx/VHfIwqpSFA A7a2fOZ7cvl48zaPYnFMhKsgQgSk6uKOAABQ6m5HcNHn+pYfMPqsOfrhh43gWvLbEKIG AMwez5zF4oib8KlCHUoPbdzUVBf2Mmj6iqKOZO4I2HmkzMfM5iXV86deY5+S7vEL+BT9 wv3F9Puov/5GuHxXic5VvIIGs7RASkq12ilmGiKxF+k5qkfHOarvRWT8G3ev/yK3xUvF FD0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=GeySHEpfB0/asXQLszsfiLjDcMnpUMVH0jqVoWkX/7o=; b=SMo9OwfmqvCT1z00M3mMMEIammJ7zFT+Th6kjDZMemUfmyNn3vz9eXAJaWoP0dbA++ 06TVz44vk6+h/rwTP5YSPCDpdTz/l4oi9o1PVgl5msopmy6N5T/34eMj6RKPshlwByt+ wleO/rJIS5Z4rMXP5k6eNx8Sr1jALDjvm+8wPKGQOe5Ku1nWeDzjsjI7bfIJ1wPkAEB+ L0XwTcIahvdms8Ht26DWuxohRRaP2yNLDoimEfni+EVubUhsRfP0R/1bpJnOJ9ID5rXf MgGzX+vjMy8PC32O3yZffW67ZMzC7wVLtUBkEGoI14JCdEI4NiGMli3oJ1RLdejqGEY9 wWRQ== X-Gm-Message-State: AJIora/HmFaMbc47tuUPZu4tNAzvHTsg0ALGQJllotxU2xjE2DBjK0xd 9F5tNWops0qy24bUvHgDT2RRIg== X-Google-Smtp-Source: AGRyM1sqyv+H/bBGuPYg4PIFRLo9cOE04f0nH/20g7zmKiDRIOyqtdjIViwQXday1ZlmdpGjP7k8OA== X-Received: by 2002:a17:907:1694:b0:716:14a4:fba with SMTP id hc20-20020a170907169400b0071614a40fbamr13073900ejc.290.1656066926720; Fri, 24 Jun 2022 03:35:26 -0700 (PDT) Received: from [192.168.0.234] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id q21-20020aa7cc15000000b0042617ba638esm1683916edt.24.2022.06.24.03.35.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Jun 2022 03:35:25 -0700 (PDT) Message-ID: Date: Fri, 24 Jun 2022 12:35:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v3 03/14] dt-bindings: leds: mt6370: Add Mediatek mt6370 current sink type LED indicator Content-Language: en-US To: ChiaEn Wu , lee.jones@linaro.org, daniel.thompson@linaro.org, jingoohan1@gmail.com, pavel@ucw.cz, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, sre@kernel.org, chunfeng.yun@mediatek.com, gregkh@linuxfoundation.org, jic23@kernel.org, lars@metafoo.de, lgirdwood@gmail.com, broonie@kernel.org, linux@roeck-us.net, heikki.krogerus@linux.intel.com, deller@gmx.de Cc: chiaen_wu@richtek.com, alice_chen@richtek.com, cy_huang@richtek.com, dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, linux-iio@vger.kernel.org, linux-fbdev@vger.kernel.org, szunichen@gmail.com References: <20220623115631.22209-1-peterwu.pub@gmail.com> <20220623115631.22209-4-peterwu.pub@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20220623115631.22209-4-peterwu.pub@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220624_033530_398525_DE5851B3 X-CRM114-Status: GOOD ( 16.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23/06/2022 13:56, ChiaEn Wu wrote: > From: ChiYuan Huang > > Add Mediatek mt6370 current sink type LED indicator binding documentation. > > Signed-off-by: ChiYuan Huang > --- > > v3 > - Use leds-class-multicolor.yaml instead of common.yaml. > - Split multi-led and led node. > - Add subdevice "led" in "multi-led". > --- > .../bindings/leds/mediatek,mt6370-indicator.yaml | 77 ++++++++++++++++++++++ > 1 file changed, 77 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml > > diff --git a/Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml b/Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml > new file mode 100644 > index 0000000..45030f3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml > @@ -0,0 +1,77 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/leds/mediatek,mt6370-indicator.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: LED driver for MT6370 PMIC from MediaTek Integrated. > + > +maintainers: > + - Alice Chen > + > +description: | > + This module is part of the MT6370 MFD device. > + Add MT6370 LED driver include 4-channel RGB LED support Register/PWM/Breath Mode > + > +allOf: > + - $ref: leds-class-multicolor.yaml# > + > +properties: > + compatible: > + const: mediatek,mt6370-indicator > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > +patternProperties: > + "^multi-led@[0-3]$": > + type: object Here as well unevaluatedProperties:false (on the type level) > + > + properties: > + reg: > + enum: [0, 1, 2, 3] > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > + patternProperties: > + "^led@[0-2]$": > + type: object > + $ref: common.yaml# > + unevaluatedProperties: false > + > + required: > + - reg > + - color > + > + required: > + - reg > + - color > + - "#address-cells" > + - "#size-cells" > + > + "^led@[0-3]$": > + type: object > + $ref: common.yaml# > + unevaluatedProperties: false > + > + properties: > + reg: > + enum: [0, 1, 2, 3] > + > + required: > + - reg > + - color > + > +required: > + - compatible > + - "#address-cells" > + - "#size-cells" > + > +additionalProperties: false Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel