From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DEECC3A59D for ; Fri, 16 Aug 2019 19:52:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3CF482077C for ; Fri, 16 Aug 2019 19:52:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ljlDUQJD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727574AbfHPTwb (ORCPT ); Fri, 16 Aug 2019 15:52:31 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:40328 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726527AbfHPTwb (ORCPT ); Fri, 16 Aug 2019 15:52:31 -0400 Received: by mail-wm1-f65.google.com with SMTP id v19so4970549wmj.5; Fri, 16 Aug 2019 12:52:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=NFDNTV+DcBXCXR6V43G44/tvOJ5WKvqNFr4X8/n+eMA=; b=ljlDUQJDb/LaeKa/Pasm3ij3mBNJHxej/3LDw25w2WqBz+KxcfkE7Y0fSFvFerVCf1 PMhHlyAg3pQqJLPqge6pYQItyykVsT7YfX9wcF6n3MhlX9HEhmrAEMAhCBqu/SnOpZj/ reTGSHDn+rcABp8coZV+cHr14TTIYKxXrcDOatU2djytO1VNm28PeT8wzohgFf0eXEb5 oYYNLrDINI27gcm7zZIFIr6OqFFbk5dDIKL5jmC/g1gwtONyMx4NWBNEhUJbM7EbiaIt YG1Gx9rCs3q0puMZRGxaChiNoGXOpSMXOO5U5TVyyqEFAGTcd8zbQ1G9tq26hEjLKL4J NX7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=NFDNTV+DcBXCXR6V43G44/tvOJ5WKvqNFr4X8/n+eMA=; b=lKptRELFO325rzmfc1LZioSoS/I6VBiTOYcPky51Mpnd6zjxLARii9a3dcd7cIeFjT IlJJcrlnBz75VbWx7nggQULB/erSA+IFbY1PVbiYyVJMotv9pBbSNnlguaq8D3JGcVhJ YpKJiXqJ3XYmdV5mRoWJvJKQwjKQV2oF79UA7tjdOyrTmS+hgaowHsE8sUJECQoZurNT RadE81P9I4WBJ1NI5eZF447YB1rG0quZhEw3b4jHeYL6Gku5H+xGzS2YcBU7DqT52P/c ulwZReX9HP5cqvIK3MFAorDoYbcCZDUQ5+/Kz+saAvmG3g2/20NFeunIHMseA+i2KCQq 1F0g== X-Gm-Message-State: APjAAAUVz9QclPUpl3uuZoEmB78QWp99WrKtsogetbmWf15FtVILGWS0 vGJxE6L5fqiJpOLsatp3+Cs= X-Google-Smtp-Source: APXvYqybYgGnUGioZ6fpOWG2paejsSTYsmbsAmKhoxrzuFb+0F55MiB7llm1MWv5f36LTb45oXLDqQ== X-Received: by 2002:a1c:c5c2:: with SMTP id v185mr9372661wmf.161.1565985147985; Fri, 16 Aug 2019 12:52:27 -0700 (PDT) Received: from [192.168.1.19] (blc39.neoplus.adsl.tpnet.pl. [83.28.196.39]) by smtp.gmail.com with ESMTPSA id r17sm16311692wrg.93.2019.08.16.12.52.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Aug 2019 12:52:27 -0700 (PDT) Subject: Re: [PATCH v4 5/5] scsi: sd: stop polling disk stats by ledtrig-blk during runtime suspend To: Akinobu Mita , linux-block@vger.kernel.org, linux-leds@vger.kernel.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org Cc: Frank Steiner , Pavel Machek , Dan Murphy , Jens Axboe , "James E.J. Bottomley" , "Martin K. Petersen" , Hannes Reinecke References: <1565888399-21550-1-git-send-email-akinobu.mita@gmail.com> <1565888399-21550-6-git-send-email-akinobu.mita@gmail.com> From: Jacek Anaszewski Openpgp: preference=signencrypt Autocrypt: addr=jacek.anaszewski@gmail.com; prefer-encrypt=mutual; keydata= mQINBFWjfaEBEADd66EQbd6yd8YjG0kbEDT2QIkx8C7BqMXR8AdmA1OMApbfSvEZFT1D/ECR eWFBS8XtApKQx1xAs1j5z70k3zebk2eeNs5ahxi6vM4Qh89vBM46biSKeeX5fLcv7asmGb/a FnHPAfQaKFyG/Bj9V+//ef67hpjJWR3s74C6LZCFLcbZM0z/wTH+baA5Jwcnqr4h/ygosvhP X3gkRzJLSFYekmEv+WHieeKXLrJdsUPUvPJTZtvi3ELUxHNOZwX2oRJStWpmL2QGMwPokRNQ 29GvnueQdQrIl2ylhul6TSrClMrKZqOajDFng7TLgvNfyVZE8WQwmrkTrdzBLfu3kScjE14Q Volq8OtQpTsw5570D4plVKh2ahlhrwXdneSot0STk9Dh1grEB/Jfw8dknvqkdjALUrrM45eF FM4FSMxIlNV8WxueHDss9vXRbCUxzGw37Ck9JWYo0EpcpcvwPf33yntYCbnt+RQRjv7vy3w5 osVwRR4hpbL/fWt1AnZ+RvbP4kYSptOCPQ+Pp1tCw16BOaPjtlqSTcrlD2fo2IbaB5D21SUa IsdZ/XkD+V2S9jCrN1yyK2iKgxtDoUkWiqlfRgH2Ep1tZtb4NLF/S0oCr7rNLO7WbqLZQh1q ShfZR16h7YW//1/NFwnyCVaG1CP/L/io719dPWgEd/sVSKT2TwARAQABtC1KYWNlayBBbmFz emV3c2tpIDxqYWNlay5hbmFzemV3c2tpQGdtYWlsLmNvbT6JAlgEEwEIAEICGwMHCwkIBwMC AQYVCAIJCgsDFgIBAh4BAheABQkJZgNMFiEEvx38ClaPBfeVdXCQvWpQHLeLfCYFAl05/9sC GQEACgkQvWpQHLeLfCarMQ/9FN/WqJdN2tf6xkP0RFyS4ft0sT04zkOCFfOMxs8mZ+KZoMU+ X3a+fEppDL7xgRFpHyGaEel7lSi1eqtzsqZ5JiHbDS1Ht1G8TtATb8q8id68qeSeW2mfzaLQ 98NPELGfUXFoUqUQkG5z2p92UrGF4Muj1vOIW93pwvE4uDpNsl+jriwHomLtjIUoZtIRjGfZ RCyUQI0vi5LYzXCebuzAjGD7Jh2YAp7fDGrv3qTq8sX+DUJ4H/+I8PiL+jXKkEeppqIhlBJJ l4WcgggMu3c2uljYDuqRYghte33BXyCPAocfO2/sN+yJRUTVuRFlOxUk4srz/W8SQDwOAwtK V7TzdyF1/jOGBxWwS13EjMb4u3XwPMzcPlEQNdIqz76NFmJ99xYEvgkAmFmRioxuBTRv8Fs1 c1jQ00WWJ5vezqY6lccdDroPalXWeFzfPjIhKbV3LAYTlqv0It75GW9+0TBhPqdTM15DrCVX B7Ues7UnD5FBtWwewTnwr+cu8te449VDMzN2I+a9YKJ1s6uZmzh5HnuKn6tAfGyQh8MujSOM lZrNHrRsIsLXOjeGVa84Qk/watEcOoyQ7d+YaVosU0OCZl0GldvbGp1z2u8cd2N/HJ7dAgFh Q7dtGXmdXpt2WKQvTvQXhIrCWVQErNYbDZDD2V0TZtlPBaZP4fkUDkvH+Sy5Ag0EVaN9oQEQ AMPNymBNoCWc13U6qOztXrIKBVsLGZXq/yOaR2n7gFbFACD0TU7XuH2UcnwvNR+uQFwSrRqa EczX2V6iIy2CITXKg5Yvg12yn09gTmafuoIyKoU16XvC3aZQQ2Bn3LO2sRP0j/NuMD9GlO37 pHCVRpI2DPxFE39TMm1PLbHnDG8+lZql+dpNwWw8dDaRgyXx2Le542CcTBT52VCeeWDtqd2M wOr4LioYlfGfAqmwcwucBdTEBUxklQaOR3VbJQx6ntI2oDOBlNGvjnVDzZe+iREd5l40l+Oj TaiWvBGXkv6OI+wx5TFPp+BM6ATU+6UzFRTUWbj+LqVA/JMqYHQp04Y4H5GtjbHCa8abRvBw IKEvpwTyWZlfXPtp8gRlNmxYn6gQlTyEZAWodXwE7CE+KxNnq7bPHeLvrSn8bLNK682PoTGr 0Y00bguYLfyvEwuDYek1/h9YSXtHaCR3CEj4LU1B561G1j7FVaeYbX9bKBAoy/GxAW8J5O1n mmw7FnkSHuwO/QDe0COoO0QZ620Cf9IBWYHW4m2M2yh5981lUaiMcNM2kPgsJFYloFo2XGn6 lWU9BrWjEoNDhHZtF+yaPEuwjZo6x/3E2Tu3E5Jj0VpVcE9U1Zq/fquDY79l2RJn5ENogOs5 +Pi0GjVpEYQVWfm0PTCxNPOzOzGR4QB3BNFvABEBAAGJAiUEGAEIAA8FAlWjfaECGwwFCQlm AYAACgkQvWpQHLeLfCZqGxAAlWBWVvjU6xj70GwengiqYZwmW1i8gfS4TNibQT/KRq0zkBnE wgKwXRbVoW38pYVuGa5x/JDQMJDrLAJ0wrCOS3XxbSHCWOl/k2ZD9OaxUeXq6N+OmGTzfrYv PUvWS1Hy04q9AD1dIaMNruZQmvnRfkOk2UDncDIg0166/NTHiYI09H5mpWGpHn/2aT6dmpVw uoM9/rHlF5s5qAAo95tZ0QW2BtIceG9/rbYlL57waSMPF49awvwLQX5RhWoF8mPS5LsBrXXK hmizIsn40tLbi2RtWjzDWgZYitqmmqijeCnDvISN4qJ/nCLO4DjiSGs59w5HR+l0nwePDhOC A4RYZqS1e2Clx1VSkDXFpL3egabcIsqK7CZ6a21r8lXVpo4RnMlQsmXZTnRx4SajFvX7PrRg /02C811fLfh2r5O5if8sKQ6BKKlHpuuioqfj/w9z3B0aQ71e4n1zNJBO1kcdznikPLAbr7jG gkBUXT1yJiwpTfRQr5y2Uo12IJsKxohnNFVYtK8X/R6S0deKPjrZWvAkllgIPcHjMi2Va8yw KTj/JgcpUO5KN906Pf7ywZISe7Kbcc/qnE0YjPPSqFOvoeZvHe6EZCMW9+xZsaipvlqpByQV UHnVg09K9YFvjUBsBPdC8ef6YwgfR9o6AnPmxl0oMUIXkCCC5c99fzJY/k+JAq0EGAEIACAW IQS/HfwKVo8F95V1cJC9alAct4t8JgUCWwqKhgIbAgCBCRC9alAct4t8JnYgBBkWCAAdFiEE FMMcSshOZf56bfAEYhBsURv0pdsFAlsKioYACgkQYhBsURv0pdvELgD/U+y3/hsz0bIjMQJY 0LLxM/rFY9Vz1L43+lQHXjL3MPsA/1lNm5sailsY7aFBVJxAzTa8ZAGWBdVaGo6KCvimDB8G 7joP/jx+oGOmdRogs7mG//H+w9DTnBfPpnfkeiiokGYo/+huWO5V0Ac9tTqZeFc//t/YuYJn wWvS0Rx+KL0fT3eh9BQo47uF4yDiZIiWLNh4Agpup1MUSVsz4MjD0lW6ghtnLcGlIgoVHW0v tPW1m9jATYyJSOG/MC1iDrcYcp9uVYn5tKfkEeQNspuG6iSfS0q3tajPKnT1nJxMTxVOD2RW EIGfaV9Scrou92VD/eC+/8INRsiWS93j3hOKIAV5XRNINFqtzkagPYAP8r6wksjSjh01fSTB p5zxjfsIwWDDzDrqgzwv83CvrLXRV3OlG1DNUDYA52qJr47paH5QMWmHW5TNuoBX8qb6RW/H M3DzPgT+l+r1pPjMPfvL1t7civZUoPuNzoyFpQRj6TvWi2bGGMQKryeYksXG2zi2+avMFnLe lOxGdUZ7jn1SJ6Abba5WL3VrXCP+TUE6bZLgfw8kYa8QSXP3ysyeMI0topHFntBZ8a0KXBNs qqFCBWmTHXfwsfW0VgBmRtPO7eXVBybjJ1VXKR2RZxwSq/GoNXh/yrRXQxbcpZ+QP3/Tttsb FdKciZ4u3ts+5UwYra0BRuvb51RiZR2wRNnUeBnXWagJVTlG7RHBO/2jJOE6wrcdCMjs0Iiw PNWmiVoZA930TvHA5UeGENxdGqo2MvMdRJ54YaIR Message-ID: Date: Fri, 16 Aug 2019 21:52:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <1565888399-21550-6-git-send-email-akinobu.mita@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Hi Akinobu, Thank you for the update. Previously I forgot to mention one more thing - this patch does more than it declares in the commit message, i.e. in addition to what is declared it uses new ledtrig-blk trigger by calling ledtrig_blk_enable()/ledtrig_blk_disable(). Those should be definitely split into a separate patch, preceding the changes required for stopping polling disk stats. Best regards, Jacek Anaszewski On 8/15/19 6:59 PM, Akinobu Mita wrote: > The LED block device activity trigger periodically polls the disk stats > to collect the activity. However, it is pointless to poll while the > scsi device is in runtime suspend. > > This stops polling disk stats when the device is successfully runtime > suspended, and restarts polling when the device is successfully runtime > resumed. > > Cc: Frank Steiner > Cc: Jacek Anaszewski > Cc: Pavel Machek > Cc: Dan Murphy > Cc: Jens Axboe > Cc: "James E.J. Bottomley" > Cc: "Martin K. Petersen" > Cc: Hannes Reinecke > Signed-off-by: Akinobu Mita > --- > drivers/scsi/sd.c | 40 +++++++++++++++++++++++----------------- > 1 file changed, 23 insertions(+), 17 deletions(-) > > diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c > index 149d406..5f73142 100644 > --- a/drivers/scsi/sd.c > +++ b/drivers/scsi/sd.c > @@ -3538,7 +3538,7 @@ static int sd_suspend_common(struct device *dev, bool ignore_stop_errors) > { > struct scsi_disk *sdkp = dev_get_drvdata(dev); > struct scsi_sense_hdr sshdr; > - int ret = 0; > + int ret; > > if (!sdkp) /* E.g.: runtime suspend following sd_remove() */ > return 0; > @@ -3550,18 +3550,16 @@ static int sd_suspend_common(struct device *dev, bool ignore_stop_errors) > if (ret) { > /* ignore OFFLINE device */ > if (ret == -ENODEV) > - return 0; > - > - if (!scsi_sense_valid(&sshdr) || > - sshdr.sense_key != ILLEGAL_REQUEST) > - return ret; > + goto success; > > /* > * sshdr.sense_key == ILLEGAL_REQUEST means this drive > * doesn't support sync. There's not much to do and > * suspend shouldn't fail. > */ > - ret = 0; > + if (!scsi_sense_valid(&sshdr) || > + sshdr.sense_key != ILLEGAL_REQUEST) > + return ret; > } > } > > @@ -3569,11 +3567,14 @@ static int sd_suspend_common(struct device *dev, bool ignore_stop_errors) > sd_printk(KERN_NOTICE, sdkp, "Stopping disk\n"); > /* an error is not worth aborting a system sleep */ > ret = sd_start_stop_device(sdkp, 0); > - if (ignore_stop_errors) > - ret = 0; > + if (ret && !ignore_stop_errors) > + return ret; > } > > - return ret; > +success: > + ledtrig_blk_disable(sdkp->disk); > + > + return 0; > } > > static int sd_suspend_system(struct device *dev) > @@ -3589,19 +3590,24 @@ static int sd_suspend_runtime(struct device *dev) > static int sd_resume(struct device *dev) > { > struct scsi_disk *sdkp = dev_get_drvdata(dev); > - int ret; > > if (!sdkp) /* E.g.: runtime resume at the start of sd_probe() */ > return 0; > > - if (!sdkp->device->manage_start_stop) > - return 0; > + if (sdkp->device->manage_start_stop) { > + int ret; > + > + sd_printk(KERN_NOTICE, sdkp, "Starting disk\n"); > + ret = sd_start_stop_device(sdkp, 1); > + if (ret) > + return ret; > > - sd_printk(KERN_NOTICE, sdkp, "Starting disk\n"); > - ret = sd_start_stop_device(sdkp, 1); > - if (!ret) > opal_unlock_from_suspend(sdkp->opal_dev); > - return ret; > + } > + > + ledtrig_blk_enable(sdkp->disk); > + > + return 0; > } > > /** > From mboxrd@z Thu Jan 1 00:00:00 1970 From: jacek.anaszewski@gmail.com (Jacek Anaszewski) Date: Fri, 16 Aug 2019 21:52:25 +0200 Subject: [PATCH v4 5/5] scsi: sd: stop polling disk stats by ledtrig-blk during runtime suspend In-Reply-To: <1565888399-21550-6-git-send-email-akinobu.mita@gmail.com> References: <1565888399-21550-1-git-send-email-akinobu.mita@gmail.com> <1565888399-21550-6-git-send-email-akinobu.mita@gmail.com> Message-ID: Hi Akinobu, Thank you for the update. Previously I forgot to mention one more thing - this patch does more than it declares in the commit message, i.e. in addition to what is declared it uses new ledtrig-blk trigger by calling ledtrig_blk_enable()/ledtrig_blk_disable(). Those should be definitely split into a separate patch, preceding the changes required for stopping polling disk stats. Best regards, Jacek Anaszewski On 8/15/19 6:59 PM, Akinobu Mita wrote: > The LED block device activity trigger periodically polls the disk stats > to collect the activity. However, it is pointless to poll while the > scsi device is in runtime suspend. > > This stops polling disk stats when the device is successfully runtime > suspended, and restarts polling when the device is successfully runtime > resumed. > > Cc: Frank Steiner > Cc: Jacek Anaszewski > Cc: Pavel Machek > Cc: Dan Murphy > Cc: Jens Axboe > Cc: "James E.J. Bottomley" > Cc: "Martin K. Petersen" > Cc: Hannes Reinecke > Signed-off-by: Akinobu Mita > --- > drivers/scsi/sd.c | 40 +++++++++++++++++++++++----------------- > 1 file changed, 23 insertions(+), 17 deletions(-) > > diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c > index 149d406..5f73142 100644 > --- a/drivers/scsi/sd.c > +++ b/drivers/scsi/sd.c > @@ -3538,7 +3538,7 @@ static int sd_suspend_common(struct device *dev, bool ignore_stop_errors) > { > struct scsi_disk *sdkp = dev_get_drvdata(dev); > struct scsi_sense_hdr sshdr; > - int ret = 0; > + int ret; > > if (!sdkp) /* E.g.: runtime suspend following sd_remove() */ > return 0; > @@ -3550,18 +3550,16 @@ static int sd_suspend_common(struct device *dev, bool ignore_stop_errors) > if (ret) { > /* ignore OFFLINE device */ > if (ret == -ENODEV) > - return 0; > - > - if (!scsi_sense_valid(&sshdr) || > - sshdr.sense_key != ILLEGAL_REQUEST) > - return ret; > + goto success; > > /* > * sshdr.sense_key == ILLEGAL_REQUEST means this drive > * doesn't support sync. There's not much to do and > * suspend shouldn't fail. > */ > - ret = 0; > + if (!scsi_sense_valid(&sshdr) || > + sshdr.sense_key != ILLEGAL_REQUEST) > + return ret; > } > } > > @@ -3569,11 +3567,14 @@ static int sd_suspend_common(struct device *dev, bool ignore_stop_errors) > sd_printk(KERN_NOTICE, sdkp, "Stopping disk\n"); > /* an error is not worth aborting a system sleep */ > ret = sd_start_stop_device(sdkp, 0); > - if (ignore_stop_errors) > - ret = 0; > + if (ret && !ignore_stop_errors) > + return ret; > } > > - return ret; > +success: > + ledtrig_blk_disable(sdkp->disk); > + > + return 0; > } > > static int sd_suspend_system(struct device *dev) > @@ -3589,19 +3590,24 @@ static int sd_suspend_runtime(struct device *dev) > static int sd_resume(struct device *dev) > { > struct scsi_disk *sdkp = dev_get_drvdata(dev); > - int ret; > > if (!sdkp) /* E.g.: runtime resume at the start of sd_probe() */ > return 0; > > - if (!sdkp->device->manage_start_stop) > - return 0; > + if (sdkp->device->manage_start_stop) { > + int ret; > + > + sd_printk(KERN_NOTICE, sdkp, "Starting disk\n"); > + ret = sd_start_stop_device(sdkp, 1); > + if (ret) > + return ret; > > - sd_printk(KERN_NOTICE, sdkp, "Starting disk\n"); > - ret = sd_start_stop_device(sdkp, 1); > - if (!ret) > opal_unlock_from_suspend(sdkp->opal_dev); > - return ret; > + } > + > + ledtrig_blk_enable(sdkp->disk); > + > + return 0; > } > > /** >