From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 131BA11CA9; Thu, 28 Mar 2024 13:45:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711633534; cv=none; b=r37jiDkhSGh/vpSJA0fr7iwuA4YOaU1swujhaTaznMFLpcPUXWiudi5e2hCIR9Kce7ZqF+nZhfT8bmeQDgvsYYHUMlWdA4RjEm0p2/CnGtBGCJzM56kz/WBIpE1JuIcsZJqTTL4lpXd1qefbPeskh5qQaxXrJtk4HNNOTFMMzP0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711633534; c=relaxed/simple; bh=MFAXdOaG8IIYPpPqn+fadq88X4T0bNFsHUij/Byl2l8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SRKn3+CRVgecsgrSThEihB1InWQ5mi5d+MKgB7iFhX4DE3Tv4KPuzAlTduWbvEPTLFZJMk56e3enjLhQKGFXSyQblpMROlVdqsA/XFPtb3XkYmPnK9KTPeNIYVDgDhZi/dCJDyafRbE9Z2o08o5rtL8FN3VZY1BICCdDdLlNSUY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dBe+Yn3L; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dBe+Yn3L" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 149B2C433C7; Thu, 28 Mar 2024 13:45:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711633533; bh=MFAXdOaG8IIYPpPqn+fadq88X4T0bNFsHUij/Byl2l8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dBe+Yn3LhADOFryjYxU0YHm2Ov3d36otcpmHlaE6/JXWkUaNe51GLtPOobxKTcWPX dcxIvvhctvJ54NbEOiDazdjSRY+/Te9yOKpWLcbd0Haaao7WGkSv7dTme0HzzAZGit pi6kp97eOCNY+tr1b8k8i6WTIjliXvDy+ULv8stjOaq7eKkixq+vaZB0BAnUiawUVN a1l5w+OV3v4Pw9YaW9clwc15VG7Lx8WD1vjb9GGkK+RAIvGr17g7kNi4oW7UKVQMUB SEUwnXUpMp81sIqF+qH2aCZW8MFOlgWFEJ7vOMSCgUGzZgKcBCPM28VpEiCnGk84zQ gHDeRactzp+ig== Date: Thu, 28 Mar 2024 13:45:28 +0000 From: Mark Brown To: Conor Dooley Cc: Mihai Sain , robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, claudiu.beznea@tuxon.dev, lgirdwood@gmail.com, andrei.simion@microchip.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/7] regulator: mcp16502: Update the names from buck regulators Message-ID: References: <20240327101724.2982-1-mihai.sain@microchip.com> <20240327101724.2982-8-mihai.sain@microchip.com> <20240327-agreed-routine-0cc60186876b@spud> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="3xvy50Unb7ZcoSWS" Content-Disposition: inline In-Reply-To: <20240327-agreed-routine-0cc60186876b@spud> X-Cookie: Yes, but which self do you want to be? --3xvy50Unb7ZcoSWS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Mar 27, 2024 at 04:28:49PM +0000, Conor Dooley wrote: > On Wed, Mar 27, 2024 at 12:17:24PM +0200, Mihai Sain wrote: > > Use generic names for buck regulators to avoid any confusion. > > Update the names from buck regulators in order to match > > the datasheet block diagram for the buck regulators. > I know the regulator core will create dummy regulators when they are not > provided in the devicetree, so I am not 100% on how backwards > compatibility works here. > You'll end up with a bunch of dummies and therefore the regulator-names > and constraints on the regulator will be lost, no? > Can you explain how is this backwards compatible with the old > devicetrees? It quite simply isn't backwards compatible. The original driver looks to be pretty broken but this breaks compatibility, we'd need a transition plan of some kind which probably needs some core work to cope with fallback names. --3xvy50Unb7ZcoSWS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmYFdHcACgkQJNaLcl1U h9BZ6Qf7BKNHdl8v6RMF5pRZyZ7vMKhs3CzyTeHe56lT/zejkrG4sHEsOQmV0dEG gVWKyDlpXzD+z5yrfTxadrPb3u72NEnFS0PEMBh0WgyuJ6YSVy8QaQe6jvKeJlMY +jsh7bXzm9YKiBVya1gudts97wrILFiI54yEpsHt+hAyVHiQkaoceEAwMRoprUJR 3nxMQIn/fUIAsXCtEjPHHFGDCu6EjsHVS7pU0D/6gasATd++yCdnWgSk3GBR6HOV ahuAjSBE09Nws1mo275I83sFix1FyemBdxvual2iRBekMpTyl4hsz3EhuhU6o6bW My2Qzamr67YowDrsd2oEqYGVTJuBoQ== =t1ua -----END PGP SIGNATURE----- --3xvy50Unb7ZcoSWS-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3392DC54E67 for ; Thu, 28 Mar 2024 13:45:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jg6bmhAGCIMTEouYH/VN86JeJ46tA3f/zRi6wNq0UjA=; b=Y5+emqrGvkyLC9VnhcyCQB51eJ nIlOpazdxGL9fli/GcqSy5939A/l/5hp3hklTljd9q8UfgpPHS/utR2LaRPqni3sETRHfG6zJQ7es gfuBmzU7hH6XNFLxy5eSkkbHo0F7BIgKWHgYj8w14d364TxV/HXZu8sFnDLKwkGtwGuPvfEr9xIcQ gctP63Z88Rcs0/z0xA8+caKQdGucbnh0WKmTrR3xupOLbT499dsH/nyPM9162Bcye/Oh0wSyuOslb 6osC2W5nsJ3w+vyk4LFiRqDVpD+CRQyESlcw+7PdyYBEZAtGSjF/r0OzZCX03eOH+AWvSrk40BpWh 7p1B2pDA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpq4b-0000000EAkX-1SfV; Thu, 28 Mar 2024 13:45:41 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpq4V-0000000EAfp-17rl for linux-arm-kernel@lists.infradead.org; Thu, 28 Mar 2024 13:45:36 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E5E9F61781; Thu, 28 Mar 2024 13:45:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 149B2C433C7; Thu, 28 Mar 2024 13:45:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711633533; bh=MFAXdOaG8IIYPpPqn+fadq88X4T0bNFsHUij/Byl2l8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dBe+Yn3LhADOFryjYxU0YHm2Ov3d36otcpmHlaE6/JXWkUaNe51GLtPOobxKTcWPX dcxIvvhctvJ54NbEOiDazdjSRY+/Te9yOKpWLcbd0Haaao7WGkSv7dTme0HzzAZGit pi6kp97eOCNY+tr1b8k8i6WTIjliXvDy+ULv8stjOaq7eKkixq+vaZB0BAnUiawUVN a1l5w+OV3v4Pw9YaW9clwc15VG7Lx8WD1vjb9GGkK+RAIvGr17g7kNi4oW7UKVQMUB SEUwnXUpMp81sIqF+qH2aCZW8MFOlgWFEJ7vOMSCgUGzZgKcBCPM28VpEiCnGk84zQ gHDeRactzp+ig== Date: Thu, 28 Mar 2024 13:45:28 +0000 From: Mark Brown To: Conor Dooley Subject: Re: [PATCH 7/7] regulator: mcp16502: Update the names from buck regulators Message-ID: References: <20240327101724.2982-1-mihai.sain@microchip.com> <20240327101724.2982-8-mihai.sain@microchip.com> <20240327-agreed-routine-0cc60186876b@spud> MIME-Version: 1.0 In-Reply-To: <20240327-agreed-routine-0cc60186876b@spud> X-Cookie: Yes, but which self do you want to be? X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240328_064535_467955_1E8D70A4 X-CRM114-Status: GOOD ( 15.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: robh@kernel.org, conor+dt@kernel.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, alexandre.belloni@bootlin.com, Mihai Sain , devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org, claudiu.beznea@tuxon.dev, andrei.simion@microchip.com, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============7475090490282563880==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7475090490282563880== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="3xvy50Unb7ZcoSWS" Content-Disposition: inline --3xvy50Unb7ZcoSWS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Mar 27, 2024 at 04:28:49PM +0000, Conor Dooley wrote: > On Wed, Mar 27, 2024 at 12:17:24PM +0200, Mihai Sain wrote: > > Use generic names for buck regulators to avoid any confusion. > > Update the names from buck regulators in order to match > > the datasheet block diagram for the buck regulators. > I know the regulator core will create dummy regulators when they are not > provided in the devicetree, so I am not 100% on how backwards > compatibility works here. > You'll end up with a bunch of dummies and therefore the regulator-names > and constraints on the regulator will be lost, no? > Can you explain how is this backwards compatible with the old > devicetrees? It quite simply isn't backwards compatible. The original driver looks to be pretty broken but this breaks compatibility, we'd need a transition plan of some kind which probably needs some core work to cope with fallback names. --3xvy50Unb7ZcoSWS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmYFdHcACgkQJNaLcl1U h9BZ6Qf7BKNHdl8v6RMF5pRZyZ7vMKhs3CzyTeHe56lT/zejkrG4sHEsOQmV0dEG gVWKyDlpXzD+z5yrfTxadrPb3u72NEnFS0PEMBh0WgyuJ6YSVy8QaQe6jvKeJlMY +jsh7bXzm9YKiBVya1gudts97wrILFiI54yEpsHt+hAyVHiQkaoceEAwMRoprUJR 3nxMQIn/fUIAsXCtEjPHHFGDCu6EjsHVS7pU0D/6gasATd++yCdnWgSk3GBR6HOV ahuAjSBE09Nws1mo275I83sFix1FyemBdxvual2iRBekMpTyl4hsz3EhuhU6o6bW My2Qzamr67YowDrsd2oEqYGVTJuBoQ== =t1ua -----END PGP SIGNATURE----- --3xvy50Unb7ZcoSWS-- --===============7475090490282563880== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7475090490282563880==--