From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com ([192.55.52.115]:22008 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750979AbeDPXWa (ORCPT ); Mon, 16 Apr 2018 19:22:30 -0400 Subject: Re: [PATCH v3 07/10] Documentation: dt-bindings: Add documents for PECI hwmon client drivers To: Rob Herring Cc: Alan Cox , Andrew Jeffery , Andrew Lunn , Andy Shevchenko , Arnd Bergmann , Benjamin Herrenschmidt , Fengguang Wu , Greg KH , Guenter Roeck , Haiyue Wang , James Feist , Jason M Biils , Jean Delvare , Joel Stanley , Julia Cartwright , Miguel Ojeda , Milton Miller II , Pavel Machek , Randy Dunlap , Stef van Os , Sumeet R Pawnikar , Vernon Mauery , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-arm-kernel@lists.infradead.org, openbmc@lists.ozlabs.org References: <20180410183212.16787-1-jae.hyun.yoo@linux.intel.com> <20180410183212.16787-8-jae.hyun.yoo@linux.intel.com> <20180416181423.t4vf7sugv6z3aw5h@rob-hp-laptop> From: Jae Hyun Yoo Message-ID: Date: Mon, 16 Apr 2018 16:22:29 -0700 MIME-Version: 1.0 In-Reply-To: <20180416181423.t4vf7sugv6z3aw5h@rob-hp-laptop> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-hwmon-owner@vger.kernel.org List-Id: linux-hwmon@vger.kernel.org On 4/16/2018 11:14 AM, Rob Herring wrote: > On Tue, Apr 10, 2018 at 11:32:09AM -0700, Jae Hyun Yoo wrote: >> This commit adds dt-bindings documents for PECI cputemp and dimmtemp client >> drivers. > > "dt-bindings: hwmon: ..." for the subject. > I'll change the subject. >> >> Signed-off-by: Jae Hyun Yoo >> Reviewed-by: Haiyue Wang >> Reviewed-by: James Feist >> Reviewed-by: Vernon Mauery >> Cc: Alan Cox >> Cc: Andrew Jeffery >> Cc: Andrew Lunn >> Cc: Andy Shevchenko >> Cc: Arnd Bergmann >> Cc: Benjamin Herrenschmidt >> Cc: Fengguang Wu >> Cc: Greg KH >> Cc: Guenter Roeck >> Cc: Jason M Biils >> Cc: Jean Delvare >> Cc: Joel Stanley >> Cc: Julia Cartwright >> Cc: Miguel Ojeda >> Cc: Milton Miller II >> Cc: Pavel Machek >> Cc: Randy Dunlap >> Cc: Stef van Os >> Cc: Sumeet R Pawnikar >> --- >> .../devicetree/bindings/hwmon/peci-cputemp.txt | 24 +++++++++++++++++++++ >> .../devicetree/bindings/hwmon/peci-dimmtemp.txt | 25 ++++++++++++++++++++++ >> 2 files changed, 49 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/hwmon/peci-cputemp.txt >> create mode 100644 Documentation/devicetree/bindings/hwmon/peci-dimmtemp.txt >> >> diff --git a/Documentation/devicetree/bindings/hwmon/peci-cputemp.txt b/Documentation/devicetree/bindings/hwmon/peci-cputemp.txt >> new file mode 100644 >> index 000000000000..d5530ef9cfd2 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/hwmon/peci-cputemp.txt >> @@ -0,0 +1,24 @@ >> +Bindings for Intel PECI (Platform Environment Control Interface) cputemp driver. >> + >> +Required properties: >> +- compatible : Should be "intel,peci-cputemp". >> +- reg : Should contain address of a client CPU. Address range of CPU >> + clients is starting from 0x30 based on PECI specification. >> + <0x30> .. <0x37> (depends on the PECI_OFFSET_MAX definition) > > Again, where is PECI_OFFSET_MAX defined? It can't depend on something in > the kernel. > I'll remove the unnecessary description. >> + >> +Example: >> + peci-bus@0 { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + < more properties > >> + >> + peci-cputemp@cpu0 { >> + compatible = "intel,peci-cputemp"; >> + reg = <0x30>; >> + }; >> + >> + peci-cputemp@cpu1 { >> + compatible = "intel,peci-cputemp"; >> + reg = <0x31>; >> + }; >> + }; >> diff --git a/Documentation/devicetree/bindings/hwmon/peci-dimmtemp.txt b/Documentation/devicetree/bindings/hwmon/peci-dimmtemp.txt >> new file mode 100644 >> index 000000000000..56e5deb61e5c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/hwmon/peci-dimmtemp.txt >> @@ -0,0 +1,25 @@ >> +Bindings for Intel PECI (Platform Environment Control Interface) dimmtemp >> +driver. >> + >> +Required properties: >> +- compatible : Should be "intel,peci-dimmtemp". >> +- reg : Should contain address of a client CPU. Address range of CPU >> + clients is starting from 0x30 based on PECI specification. >> + <0x30> .. <0x37> (depends on the PECI_OFFSET_MAX definition) >> + >> +Example: >> + peci-bus@0 { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + < more properties > >> + >> + peci-dimmtemp@cpu0 { > > unit-address is wrong. > Will fix it using the reg value. > It is a different bus from cputemp? Otherwise, you have conflicting > addresses. If that's the case, probably should make it clear by showing > different host adapters for each example. > It could be the same bus with cputemp. Also, client address sharing is possible by PECI core if the functionality is different. I mean, cputemp and dimmtemp targeting the same client is possible case like this. peci-cputemp@30 peci-dimmtemp@30 >> + compatible = "intel,peci-dimmtemp"; >> + reg = <0x30>; >> + }; >> + >> + peci-dimmtemp@cpu1 { >> + compatible = "intel,peci-dimmtemp"; >> + reg = <0x31>; >> + }; >> + }; >> -- >> 2.16.2 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe devicetree" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jae Hyun Yoo Subject: Re: [PATCH v3 07/10] Documentation: dt-bindings: Add documents for PECI hwmon client drivers Date: Mon, 16 Apr 2018 16:22:29 -0700 Message-ID: References: <20180410183212.16787-1-jae.hyun.yoo@linux.intel.com> <20180410183212.16787-8-jae.hyun.yoo@linux.intel.com> <20180416181423.t4vf7sugv6z3aw5h@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180416181423.t4vf7sugv6z3aw5h@rob-hp-laptop> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring Cc: Alan Cox , Andrew Jeffery , Andrew Lunn , Andy Shevchenko , Arnd Bergmann , Benjamin Herrenschmidt , Fengguang Wu , Greg KH , Guenter Roeck , Haiyue Wang , James Feist , Jason M Biils , Jean Delvare , Joel Stanley , Julia Cartwright , Miguel Ojeda , Milton Miller II , Pavel Machek , Randy Dunlap , Stef van Os List-Id: devicetree@vger.kernel.org On 4/16/2018 11:14 AM, Rob Herring wrote: > On Tue, Apr 10, 2018 at 11:32:09AM -0700, Jae Hyun Yoo wrote: >> This commit adds dt-bindings documents for PECI cputemp and dimmtemp client >> drivers. > > "dt-bindings: hwmon: ..." for the subject. > I'll change the subject. >> >> Signed-off-by: Jae Hyun Yoo >> Reviewed-by: Haiyue Wang >> Reviewed-by: James Feist >> Reviewed-by: Vernon Mauery >> Cc: Alan Cox >> Cc: Andrew Jeffery >> Cc: Andrew Lunn >> Cc: Andy Shevchenko >> Cc: Arnd Bergmann >> Cc: Benjamin Herrenschmidt >> Cc: Fengguang Wu >> Cc: Greg KH >> Cc: Guenter Roeck >> Cc: Jason M Biils >> Cc: Jean Delvare >> Cc: Joel Stanley >> Cc: Julia Cartwright >> Cc: Miguel Ojeda >> Cc: Milton Miller II >> Cc: Pavel Machek >> Cc: Randy Dunlap >> Cc: Stef van Os >> Cc: Sumeet R Pawnikar >> --- >> .../devicetree/bindings/hwmon/peci-cputemp.txt | 24 +++++++++++++++++++++ >> .../devicetree/bindings/hwmon/peci-dimmtemp.txt | 25 ++++++++++++++++++++++ >> 2 files changed, 49 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/hwmon/peci-cputemp.txt >> create mode 100644 Documentation/devicetree/bindings/hwmon/peci-dimmtemp.txt >> >> diff --git a/Documentation/devicetree/bindings/hwmon/peci-cputemp.txt b/Documentation/devicetree/bindings/hwmon/peci-cputemp.txt >> new file mode 100644 >> index 000000000000..d5530ef9cfd2 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/hwmon/peci-cputemp.txt >> @@ -0,0 +1,24 @@ >> +Bindings for Intel PECI (Platform Environment Control Interface) cputemp driver. >> + >> +Required properties: >> +- compatible : Should be "intel,peci-cputemp". >> +- reg : Should contain address of a client CPU. Address range of CPU >> + clients is starting from 0x30 based on PECI specification. >> + <0x30> .. <0x37> (depends on the PECI_OFFSET_MAX definition) > > Again, where is PECI_OFFSET_MAX defined? It can't depend on something in > the kernel. > I'll remove the unnecessary description. >> + >> +Example: >> + peci-bus@0 { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + < more properties > >> + >> + peci-cputemp@cpu0 { >> + compatible = "intel,peci-cputemp"; >> + reg = <0x30>; >> + }; >> + >> + peci-cputemp@cpu1 { >> + compatible = "intel,peci-cputemp"; >> + reg = <0x31>; >> + }; >> + }; >> diff --git a/Documentation/devicetree/bindings/hwmon/peci-dimmtemp.txt b/Documentation/devicetree/bindings/hwmon/peci-dimmtemp.txt >> new file mode 100644 >> index 000000000000..56e5deb61e5c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/hwmon/peci-dimmtemp.txt >> @@ -0,0 +1,25 @@ >> +Bindings for Intel PECI (Platform Environment Control Interface) dimmtemp >> +driver. >> + >> +Required properties: >> +- compatible : Should be "intel,peci-dimmtemp". >> +- reg : Should contain address of a client CPU. Address range of CPU >> + clients is starting from 0x30 based on PECI specification. >> + <0x30> .. <0x37> (depends on the PECI_OFFSET_MAX definition) >> + >> +Example: >> + peci-bus@0 { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + < more properties > >> + >> + peci-dimmtemp@cpu0 { > > unit-address is wrong. > Will fix it using the reg value. > It is a different bus from cputemp? Otherwise, you have conflicting > addresses. If that's the case, probably should make it clear by showing > different host adapters for each example. > It could be the same bus with cputemp. Also, client address sharing is possible by PECI core if the functionality is different. I mean, cputemp and dimmtemp targeting the same client is possible case like this. peci-cputemp@30 peci-dimmtemp@30 >> + compatible = "intel,peci-dimmtemp"; >> + reg = <0x30>; >> + }; >> + >> + peci-dimmtemp@cpu1 { >> + compatible = "intel,peci-dimmtemp"; >> + reg = <0x31>; >> + }; >> + }; >> -- >> 2.16.2 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe devicetree" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-5.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id E19E17DE74 for ; Mon, 16 Apr 2018 23:22:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751059AbeDPXWb (ORCPT ); Mon, 16 Apr 2018 19:22:31 -0400 Received: from mga14.intel.com ([192.55.52.115]:22008 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750979AbeDPXWa (ORCPT ); Mon, 16 Apr 2018 19:22:30 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Apr 2018 16:22:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,461,1517904000"; d="scan'208";a="192003509" Received: from yoojae-mobl1.amr.corp.intel.com (HELO [10.7.153.150]) ([10.7.153.150]) by orsmga004.jf.intel.com with ESMTP; 16 Apr 2018 16:22:29 -0700 Subject: Re: [PATCH v3 07/10] Documentation: dt-bindings: Add documents for PECI hwmon client drivers To: Rob Herring Cc: Alan Cox , Andrew Jeffery , Andrew Lunn , Andy Shevchenko , Arnd Bergmann , Benjamin Herrenschmidt , Fengguang Wu , Greg KH , Guenter Roeck , Haiyue Wang , James Feist , Jason M Biils , Jean Delvare , Joel Stanley , Julia Cartwright , Miguel Ojeda , Milton Miller II , Pavel Machek , Randy Dunlap , Stef van Os , Sumeet R Pawnikar , Vernon Mauery , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-arm-kernel@lists.infradead.org, openbmc@lists.ozlabs.org References: <20180410183212.16787-1-jae.hyun.yoo@linux.intel.com> <20180410183212.16787-8-jae.hyun.yoo@linux.intel.com> <20180416181423.t4vf7sugv6z3aw5h@rob-hp-laptop> From: Jae Hyun Yoo Message-ID: Date: Mon, 16 Apr 2018 16:22:29 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180416181423.t4vf7sugv6z3aw5h@rob-hp-laptop> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On 4/16/2018 11:14 AM, Rob Herring wrote: > On Tue, Apr 10, 2018 at 11:32:09AM -0700, Jae Hyun Yoo wrote: >> This commit adds dt-bindings documents for PECI cputemp and dimmtemp client >> drivers. > > "dt-bindings: hwmon: ..." for the subject. > I'll change the subject. >> >> Signed-off-by: Jae Hyun Yoo >> Reviewed-by: Haiyue Wang >> Reviewed-by: James Feist >> Reviewed-by: Vernon Mauery >> Cc: Alan Cox >> Cc: Andrew Jeffery >> Cc: Andrew Lunn >> Cc: Andy Shevchenko >> Cc: Arnd Bergmann >> Cc: Benjamin Herrenschmidt >> Cc: Fengguang Wu >> Cc: Greg KH >> Cc: Guenter Roeck >> Cc: Jason M Biils >> Cc: Jean Delvare >> Cc: Joel Stanley >> Cc: Julia Cartwright >> Cc: Miguel Ojeda >> Cc: Milton Miller II >> Cc: Pavel Machek >> Cc: Randy Dunlap >> Cc: Stef van Os >> Cc: Sumeet R Pawnikar >> --- >> .../devicetree/bindings/hwmon/peci-cputemp.txt | 24 +++++++++++++++++++++ >> .../devicetree/bindings/hwmon/peci-dimmtemp.txt | 25 ++++++++++++++++++++++ >> 2 files changed, 49 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/hwmon/peci-cputemp.txt >> create mode 100644 Documentation/devicetree/bindings/hwmon/peci-dimmtemp.txt >> >> diff --git a/Documentation/devicetree/bindings/hwmon/peci-cputemp.txt b/Documentation/devicetree/bindings/hwmon/peci-cputemp.txt >> new file mode 100644 >> index 000000000000..d5530ef9cfd2 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/hwmon/peci-cputemp.txt >> @@ -0,0 +1,24 @@ >> +Bindings for Intel PECI (Platform Environment Control Interface) cputemp driver. >> + >> +Required properties: >> +- compatible : Should be "intel,peci-cputemp". >> +- reg : Should contain address of a client CPU. Address range of CPU >> + clients is starting from 0x30 based on PECI specification. >> + <0x30> .. <0x37> (depends on the PECI_OFFSET_MAX definition) > > Again, where is PECI_OFFSET_MAX defined? It can't depend on something in > the kernel. > I'll remove the unnecessary description. >> + >> +Example: >> + peci-bus@0 { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + < more properties > >> + >> + peci-cputemp@cpu0 { >> + compatible = "intel,peci-cputemp"; >> + reg = <0x30>; >> + }; >> + >> + peci-cputemp@cpu1 { >> + compatible = "intel,peci-cputemp"; >> + reg = <0x31>; >> + }; >> + }; >> diff --git a/Documentation/devicetree/bindings/hwmon/peci-dimmtemp.txt b/Documentation/devicetree/bindings/hwmon/peci-dimmtemp.txt >> new file mode 100644 >> index 000000000000..56e5deb61e5c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/hwmon/peci-dimmtemp.txt >> @@ -0,0 +1,25 @@ >> +Bindings for Intel PECI (Platform Environment Control Interface) dimmtemp >> +driver. >> + >> +Required properties: >> +- compatible : Should be "intel,peci-dimmtemp". >> +- reg : Should contain address of a client CPU. Address range of CPU >> + clients is starting from 0x30 based on PECI specification. >> + <0x30> .. <0x37> (depends on the PECI_OFFSET_MAX definition) >> + >> +Example: >> + peci-bus@0 { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + < more properties > >> + >> + peci-dimmtemp@cpu0 { > > unit-address is wrong. > Will fix it using the reg value. > It is a different bus from cputemp? Otherwise, you have conflicting > addresses. If that's the case, probably should make it clear by showing > different host adapters for each example. > It could be the same bus with cputemp. Also, client address sharing is possible by PECI core if the functionality is different. I mean, cputemp and dimmtemp targeting the same client is possible case like this. peci-cputemp@30 peci-dimmtemp@30 >> + compatible = "intel,peci-dimmtemp"; >> + reg = <0x30>; >> + }; >> + >> + peci-dimmtemp@cpu1 { >> + compatible = "intel,peci-dimmtemp"; >> + reg = <0x31>; >> + }; >> + }; >> -- >> 2.16.2 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe devicetree" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: jae.hyun.yoo@linux.intel.com (Jae Hyun Yoo) Date: Mon, 16 Apr 2018 16:22:29 -0700 Subject: [PATCH v3 07/10] Documentation: dt-bindings: Add documents for PECI hwmon client drivers In-Reply-To: <20180416181423.t4vf7sugv6z3aw5h@rob-hp-laptop> References: <20180410183212.16787-1-jae.hyun.yoo@linux.intel.com> <20180410183212.16787-8-jae.hyun.yoo@linux.intel.com> <20180416181423.t4vf7sugv6z3aw5h@rob-hp-laptop> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 4/16/2018 11:14 AM, Rob Herring wrote: > On Tue, Apr 10, 2018 at 11:32:09AM -0700, Jae Hyun Yoo wrote: >> This commit adds dt-bindings documents for PECI cputemp and dimmtemp client >> drivers. > > "dt-bindings: hwmon: ..." for the subject. > I'll change the subject. >> >> Signed-off-by: Jae Hyun Yoo >> Reviewed-by: Haiyue Wang >> Reviewed-by: James Feist >> Reviewed-by: Vernon Mauery >> Cc: Alan Cox >> Cc: Andrew Jeffery >> Cc: Andrew Lunn >> Cc: Andy Shevchenko >> Cc: Arnd Bergmann >> Cc: Benjamin Herrenschmidt >> Cc: Fengguang Wu >> Cc: Greg KH >> Cc: Guenter Roeck >> Cc: Jason M Biils >> Cc: Jean Delvare >> Cc: Joel Stanley >> Cc: Julia Cartwright >> Cc: Miguel Ojeda >> Cc: Milton Miller II >> Cc: Pavel Machek >> Cc: Randy Dunlap >> Cc: Stef van Os >> Cc: Sumeet R Pawnikar >> --- >> .../devicetree/bindings/hwmon/peci-cputemp.txt | 24 +++++++++++++++++++++ >> .../devicetree/bindings/hwmon/peci-dimmtemp.txt | 25 ++++++++++++++++++++++ >> 2 files changed, 49 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/hwmon/peci-cputemp.txt >> create mode 100644 Documentation/devicetree/bindings/hwmon/peci-dimmtemp.txt >> >> diff --git a/Documentation/devicetree/bindings/hwmon/peci-cputemp.txt b/Documentation/devicetree/bindings/hwmon/peci-cputemp.txt >> new file mode 100644 >> index 000000000000..d5530ef9cfd2 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/hwmon/peci-cputemp.txt >> @@ -0,0 +1,24 @@ >> +Bindings for Intel PECI (Platform Environment Control Interface) cputemp driver. >> + >> +Required properties: >> +- compatible : Should be "intel,peci-cputemp". >> +- reg : Should contain address of a client CPU. Address range of CPU >> + clients is starting from 0x30 based on PECI specification. >> + <0x30> .. <0x37> (depends on the PECI_OFFSET_MAX definition) > > Again, where is PECI_OFFSET_MAX defined? It can't depend on something in > the kernel. > I'll remove the unnecessary description. >> + >> +Example: >> + peci-bus at 0 { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + < more properties > >> + >> + peci-cputemp at cpu0 { >> + compatible = "intel,peci-cputemp"; >> + reg = <0x30>; >> + }; >> + >> + peci-cputemp at cpu1 { >> + compatible = "intel,peci-cputemp"; >> + reg = <0x31>; >> + }; >> + }; >> diff --git a/Documentation/devicetree/bindings/hwmon/peci-dimmtemp.txt b/Documentation/devicetree/bindings/hwmon/peci-dimmtemp.txt >> new file mode 100644 >> index 000000000000..56e5deb61e5c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/hwmon/peci-dimmtemp.txt >> @@ -0,0 +1,25 @@ >> +Bindings for Intel PECI (Platform Environment Control Interface) dimmtemp >> +driver. >> + >> +Required properties: >> +- compatible : Should be "intel,peci-dimmtemp". >> +- reg : Should contain address of a client CPU. Address range of CPU >> + clients is starting from 0x30 based on PECI specification. >> + <0x30> .. <0x37> (depends on the PECI_OFFSET_MAX definition) >> + >> +Example: >> + peci-bus at 0 { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + < more properties > >> + >> + peci-dimmtemp at cpu0 { > > unit-address is wrong. > Will fix it using the reg value. > It is a different bus from cputemp? Otherwise, you have conflicting > addresses. If that's the case, probably should make it clear by showing > different host adapters for each example. > It could be the same bus with cputemp. Also, client address sharing is possible by PECI core if the functionality is different. I mean, cputemp and dimmtemp targeting the same client is possible case like this. peci-cputemp at 30 peci-dimmtemp at 30 >> + compatible = "intel,peci-dimmtemp"; >> + reg = <0x30>; >> + }; >> + >> + peci-dimmtemp at cpu1 { >> + compatible = "intel,peci-dimmtemp"; >> + reg = <0x31>; >> + }; >> + }; >> -- >> 2.16.2 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe devicetree" in >> the body of a message to majordomo at vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html