From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F26BEC07E95 for ; Fri, 16 Jul 2021 07:34:13 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9EE41613E9 for ; Fri, 16 Jul 2021 07:34:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9EE41613E9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.157057.289871 (Exim 4.92) (envelope-from ) id 1m4IME-0000mI-VY; Fri, 16 Jul 2021 07:34:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 157057.289871; Fri, 16 Jul 2021 07:34:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m4IME-0000mB-SN; Fri, 16 Jul 2021 07:34:02 +0000 Received: by outflank-mailman (input) for mailman id 157057; Fri, 16 Jul 2021 07:34:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m4IMD-0000m5-OD for xen-devel@lists.xenproject.org; Fri, 16 Jul 2021 07:34:01 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m4IM9-0006rO-Pf; Fri, 16 Jul 2021 07:33:57 +0000 Received: from [54.239.6.184] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1m4IM9-0004Ua-Ip; Fri, 16 Jul 2021 07:33:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=5xaAwP3IC9yXeEouZ/YfdS2OMY75k8DVB5cIyF7d08o=; b=N+VkwmeJo+5sB92+jHZTqguTI1 kr3WNzBjdDpozIe9rAVVgVl5UXOuASgXOxY39cHTQvgEuMbF4e2R1GynLXwNRJYOpoidbEAMifbLg WkVeQwtZgAwB1FXg6K1M0OOAKNt6qj1/y9hOYEaVtid+nqdCttYzYBOMQKxcfBkt0ps0=; Subject: Re: [PATCH v2 2/4] build: use common stubs for debugger_trap_* functions if !CONFIG_CRASH_DEBUG To: Jan Beulich , Bobby Eshleman Cc: Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Wei Liu , Elena Ufimtseva , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Jun Nakajima , Kevin Tian , xen-devel@lists.xenproject.org References: From: Julien Grall Message-ID: Date: Fri, 16 Jul 2021 08:33:54 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi, On 15/07/2021 16:18, Jan Beulich wrote: > On 14.07.2021 22:37, Bobby Eshleman wrote: >> --- a/xen/arch/arm/traps.c >> +++ b/xen/arch/arm/traps.c >> @@ -16,6 +16,7 @@ >> * GNU General Public License for more details. >> */ >> >> +#include > > I don't think this is needed here; instead I think ... > >> @@ -41,7 +42,6 @@ >> #include >> #include >> #include >> -#include > > ... this wants to be done in patch 1 already. +1. I was actually going to ask in patch 1 to drop as there should be no more callers of the debugger helpers. Cheers, -- Julien Grall