All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heinrich Schuchardt <xypron.glpk@gmx.de>
To: Heiko Thiery <heiko.thiery@gmail.com>,
	Tom Rini <trini@konsulko.com>, Simon Glass <sjg@chromium.org>
Cc: Stefano Babic <sbabic@denx.de>,
	Fabio Estevam <festevam@gmail.com>, Peng Fan <peng.fan@nxp.com>,
	u-boot@lists.denx.de
Subject: Re: [PATCH v2] board: kontron: increase the CONFIG_SYS_MALLOC_F_LEN
Date: Tue, 22 Mar 2022 10:25:12 +0100	[thread overview]
Message-ID: <aee8166f-bd69-a905-5875-6d960ca9cc59@gmx.de> (raw)
In-Reply-To: <20220321142631.63704-1-heiko.thiery@gmail.com>

On 3/21/22 15:26, Heiko Thiery wrote:
> It was observed that enabling additional DM modules the configured
> malloc value is not sufficient. So lets increase the value.
>
> Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
> ---
> v2:
>   - add a more proper commit message to explan why the value was increased
>
>   configs/kontron_pitx_imx8m_defconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/configs/kontron_pitx_imx8m_defconfig b/configs/kontron_pitx_imx8m_defconfig
> index 76430213e3..30c3586937 100644
> --- a/configs/kontron_pitx_imx8m_defconfig
> +++ b/configs/kontron_pitx_imx8m_defconfig
> @@ -2,6 +2,7 @@ CONFIG_ARM=y
>   CONFIG_ARCH_IMX8M=y
>   CONFIG_SYS_TEXT_BASE=0x40200000
>   CONFIG_SYS_MALLOC_LEN=0x600000
> +CONFIG_SYS_MALLOC_F_LEN=0x10000

@Heiko
Should we really adjust this on board level? Won't we have the same
problem on all imx8m boards?

Why don't you change the default for all i.mx8 boards in /Kconfig?

@Tom, @Simon
Shouldn't we replace the default of 0x400 by 0x2000 generally?

Best regards

Heinrich

>   CONFIG_SPL_GPIO=y
>   CONFIG_SPL_LIBCOMMON_SUPPORT=y
>   CONFIG_SPL_LIBGENERIC_SUPPORT=y


  parent reply	other threads:[~2022-03-22  9:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-21 14:26 [PATCH v2] board: kontron: increase the CONFIG_SYS_MALLOC_F_LEN Heiko Thiery
2022-03-21 14:30 ` Fabio Estevam
2022-03-22  9:25 ` Heinrich Schuchardt [this message]
2022-03-22 12:25   ` Tom Rini
2022-03-22 12:34     ` Heiko Thiery
2022-03-23 13:14       ` Tom Rini
2022-03-23 14:09         ` Adam Ford
2022-03-23 18:04   ` Simon Glass
2022-03-23 18:26     ` Heiko Thiery
2022-03-23 18:33       ` Sean Anderson
2022-03-23 18:49         ` Tom Rini
2022-03-23 18:53           ` Simon Glass
2022-03-23 18:59             ` Tom Rini
2022-03-23 19:38               ` Simon Glass
2022-03-23 18:53         ` Simon Glass
2022-03-23 19:19           ` Sean Anderson
2022-03-23 19:38             ` Simon Glass
2022-03-23 20:03             ` Adam Ford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aee8166f-bd69-a905-5875-6d960ca9cc59@gmx.de \
    --to=xypron.glpk@gmx.de \
    --cc=festevam@gmail.com \
    --cc=heiko.thiery@gmail.com \
    --cc=peng.fan@nxp.com \
    --cc=sbabic@denx.de \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.