From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0055C11D3D for ; Thu, 27 Feb 2020 16:09:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CBC062469F for ; Thu, 27 Feb 2020 16:09:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729959AbgB0QJC (ORCPT ); Thu, 27 Feb 2020 11:09:02 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:14450 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729134AbgB0QJB (ORCPT ); Thu, 27 Feb 2020 11:09:01 -0500 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 01RG0O2X096132 for ; Thu, 27 Feb 2020 11:09:00 -0500 Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99]) by mx0a-001b2d01.pphosted.com with ESMTP id 2ydq6jehpt-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 27 Feb 2020 11:08:59 -0500 Received: from localhost by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 27 Feb 2020 16:08:57 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp03.uk.ibm.com (192.168.101.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 27 Feb 2020 16:08:56 -0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 01RG8tST58982572 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 27 Feb 2020 16:08:55 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 734714C052; Thu, 27 Feb 2020 16:08:55 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2B7DE4C040; Thu, 27 Feb 2020 16:08:55 +0000 (GMT) Received: from [9.145.6.242] (unknown [9.145.6.242]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 27 Feb 2020 16:08:55 +0000 (GMT) Subject: Re: [RFC net-next] net/smc: update peer ID on device changes To: Hans Wippel Cc: ubraun@linux.ibm.com, davem@davemloft.net, netdev@vger.kernel.org References: <20200227113902.318060-1-ndev@hwipl.net> <20200227150946.60f12541f7541a64150afe2a@hwipl.net> <4c3b6802-7b27-73ec-f53c-ec1326aecb2b@linux.ibm.com> <20200227160328.30726cdf8b639fc3512c9b18@hwipl.net> From: Karsten Graul Organization: IBM Deutschland Research & Development GmbH Date: Thu, 27 Feb 2020 17:08:54 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200227160328.30726cdf8b639fc3512c9b18@hwipl.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 20022716-0012-0000-0000-0000038ADDD2 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 20022716-0013-0000-0000-000021C787BB Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572 definitions=2020-02-27_05:2020-02-26,2020-02-27 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 spamscore=0 impostorscore=0 suspectscore=0 bulkscore=0 mlxlogscore=912 clxscore=1015 priorityscore=1501 malwarescore=0 mlxscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002270124 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 27/02/2020 16:03, Hans Wippel wrote: > On Thu, 27 Feb 2020 15:44:52 +0100 > Karsten Graul wrote: > >> On 27/02/2020 15:09, Hans Wippel wrote: >>> On Thu, 27 Feb 2020 14:13:48 +0100 >>> Karsten Graul wrote: >>> >>>> On 27/02/2020 12:39, Hans Wippel wrote: >>>>> From: hwipl >>>>> >>>>> A SMC host's peer ID contains the MAC address of the first active RoCE >>>>> device. However, if this device becomes inactive or is removed, the peer >>>>> ID is not updated. This patch adds peer ID updates on device changes. >>>> >>>> The peer ID is used to uniquely identify an SMC host and to check if there >>>> are already established link groups to the peer which can be reused. >>>> In failover scenarios RoCE devices can go down and get active again later, >>>> but this must not change the current peer ID of the host. >>>> The part of the MAC address that is included in the peer ID is not used for >>>> other purposes than the identification of an SMC host. >>> >>> Is it OK to keep the peer ID if, for example, the device is removed and >>> used in a different VM? >>> >>> Hans >>> >> >> Yes, exactly this case is described in the RFC (instance id): >> >> https://tools.ietf.org/html/rfc7609#page-93 > > OK, thanks for clarifying. I guess, you can ignore the RFC/patch then ;) > Hans > Thanks for taking care Hans! -- Karsten (I'm a dude)