From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AA5CC433B4 for ; Fri, 14 May 2021 17:44:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B4CCC613E9 for ; Fri, 14 May 2021 17:43:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B4CCC613E9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46674 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhbqv-0004CK-Th for qemu-devel@archiver.kernel.org; Fri, 14 May 2021 13:43:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60126) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhb96-0006BL-DC for qemu-devel@nongnu.org; Fri, 14 May 2021 12:58:40 -0400 Received: from mail-qt1-x82f.google.com ([2607:f8b0:4864:20::82f]:39804) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lhb93-00035f-Gg for qemu-devel@nongnu.org; Fri, 14 May 2021 12:58:40 -0400 Received: by mail-qt1-x82f.google.com with SMTP id f8so60093qth.6 for ; Fri, 14 May 2021 09:58:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=PmDYKICtH4Ujp3wMWVxCuXwCS+IWoxy1wuBQpOUjRxs=; b=XWcFnpvpgvQIGl2z2gh6AX2F+Xr8O3mn289OEKMKO7/+n/l7seeE3EmJnhPJbRwMdN r8pp/RA+SLyLP/Eh5JHUsWxU0SBjPgsPE/fOWUdn6DoJeOiY6gQj7Z8VGaI5kcDBorch Heoi9lN9mZ/vGAI3p/qZD99/3haM1S1soncekS6xoYYVHahrUB/VBAJWvERvTbrHgeMq rTkZQZgm+Ro5DATuLTuK5/ag5w4xPEBCUI5SSRRJXBlly+XTxgDguKKFTQP3wwZBdg5/ nuz+XN+QbV65Kgx4Fam+ac17gCyml7itvBTQsmZGHuuhaPwIPf56Z0qNg/cx5eNebjHj QDjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=PmDYKICtH4Ujp3wMWVxCuXwCS+IWoxy1wuBQpOUjRxs=; b=Ujpa1sh1naeypevGcEktRVUHm27ytddxf/4Da5Nbw1/A1jgPZ9dnXWWxl2+ADb7FbJ hMrrx2TMCzDHl+u0wmKeOzl22IoCU+eiLwdLRPRelKB3grGOaFZmNaBsx5qVAG7jnQLC gkCbcXX1CryCwDZaVqrdmpXXgquTI/6OORxLOHCMUk71n9t/PVTd6q19+foOvzBW2QhM mKfm86lkJpzXOJNhtyz0Fmhg+EP//oBScmkV90AUNaantC92FwBe84nvVMEtUgIvRJnQ SZNOp4KimD+MDhoOSNhM3OsKlL4e4yFAETE0fdlBt0ePzGCcX4LRn0G5FJbJpxkv2DXo vqnQ== X-Gm-Message-State: AOAM533sTGC1Uy7Qwf9avJIIclQ6dcuGXG/VsTDTXptVXb6wL/2Linna 7MyFZuxDWcvK334XolrtYlBMsQ== X-Google-Smtp-Source: ABdhPJw94QNg5nXxZyu628uC5f96nibWEs6Sct8yaifzuMutOwrHBIu+K2Kjddc8h/Dr6XX7kB4yEg== X-Received: by 2002:ac8:7544:: with SMTP id b4mr10447700qtr.368.1621011516429; Fri, 14 May 2021 09:58:36 -0700 (PDT) Received: from [192.168.183.76] (163.189-204-200.bestelclientes.com.mx. [189.204.200.163]) by smtp.gmail.com with ESMTPSA id x142sm5103490qkb.136.2021.05.14.09.58.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 May 2021 09:58:36 -0700 (PDT) Subject: Re: [PATCH v6 80/82] target/arm: Implement integer matrix multiply accumulate To: Peter Maydell References: <20210430202610.1136687-1-richard.henderson@linaro.org> <20210430202610.1136687-81-richard.henderson@linaro.org> From: Richard Henderson Message-ID: Date: Fri, 14 May 2021 11:58:34 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::82f; envelope-from=richard.henderson@linaro.org; helo=mail-qt1-x82f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/13/21 2:49 PM, Peter Maydell wrote: > On Fri, 30 Apr 2021 at 22:36, Richard Henderson > wrote: >> >> This is {S,U,US}MMLA for both AArch64 AdvSIMD and SVE, >> and V{S,U,US}MMLA.S8 for AArch32 NEON. >> >> Signed-off-by: Richard Henderson >> --- >> target/arm/helper.h | 7 ++++ >> target/arm/neon-shared.decode | 7 ++++ >> target/arm/sve.decode | 6 +++ >> target/arm/translate-a64.c | 18 ++++++++ >> target/arm/translate-neon.c | 27 ++++++++++++ >> target/arm/translate-sve.c | 27 ++++++++++++ >> target/arm/vec_helper.c | 77 +++++++++++++++++++++++++++++++++++ >> 7 files changed, 169 insertions(+) > > I have to say the decode parts for SVE and A32 (using decodetree > were much easier to review than the A64 part... Indeed, this was painful enough to write that I'm on the verge of converting a64 to decodetree as well. r~