From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 438D1C433F5 for ; Tue, 5 Oct 2021 18:59:08 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 876036124D for ; Tue, 5 Oct 2021 18:59:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 876036124D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8608482D7E; Tue, 5 Oct 2021 20:59:05 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="VRHIqugp"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3A0D3820E3; Tue, 5 Oct 2021 20:59:03 +0200 (CEST) Received: from mail-ot1-x335.google.com (mail-ot1-x335.google.com [IPv6:2607:f8b0:4864:20::335]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 16FC882D7E for ; Tue, 5 Oct 2021 20:58:59 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mr.nuke.me@gmail.com Received: by mail-ot1-x335.google.com with SMTP id 97-20020a9d006a000000b00545420bff9eso101260ota.8 for ; Tue, 05 Oct 2021 11:58:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1tzYKgOZfKTs98TaJPxUQ8FCuWtKTFMCSVzLjk15nC0=; b=VRHIqugp/eK7H7z/BfPiAHvrxabopgJPgXIBINsIfjPNvUkcDj4o1/jFi+RZVM0rr1 tg0HYmcR3IRzj55b8PhS0z9OYswXUfJ9tpVnqU4lyUITAw6jBWWpEcp+ihkeWDnnPqRQ 7Cbcsry9Wvn+S3WGXhj3cX+RE6k2fYB6pIW5Uxfaw+si6v2RmCb+lqNOOuRDON8wjEYP 1OMWz2SxV0/YHoc5mgtr9WnC7SdJE30xnevRxNIaSL8On0gWL6SBQvQ+Ukx0mCVZ8TM+ 1kS/hO+tJTs2FpKAoQgnq/v02al+aINF542KpUUe1qfYnHuJkmSico6PzT63ZqggIV5s 9FFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1tzYKgOZfKTs98TaJPxUQ8FCuWtKTFMCSVzLjk15nC0=; b=TrGrUeqLrvyg7SCuq2MEf4zN1AhJF6YpfYj3VSrcP3cCfuiyF96TYxkcwGKNBjrQx+ QrkANWOdQWvlD92n3ERa4c/Vs2hwusnD7EIpOEaG0l6wc5OJd7pkzP1+r//m6qMBzgVR LR+Fad5sFxJKCisr3TFvg8WsQas47Xs1PU/mqH3bbOBuOLH/lVFbjcjKDTyj2HBtatTk ivxgOyazzuq/Xv3JAKejlwEBVfZVxj4c5KWKsXno4PciTPfjESGFMYBqleehmtN2PFST jDaTkhjyWn8E3Eo79vTWqMzLbCsGp/hp5Bu8lvF+dPlgmISDyudeIkQigX39+0OTmOer ysww== X-Gm-Message-State: AOAM5302V2IlsqUnDM93d8BVRYGI7KSsvhTSfQqGH+qqjESRgfo76mUW C793bbR14/faO4uLbwPX1dA= X-Google-Smtp-Source: ABdhPJyivn9hSLi0Ip/UaU8ScusQv4aY4MlJRrd0obWVZFNPj42YQ/D0wSAdYrSko62vohO+HiwjPg== X-Received: by 2002:a05:6830:2685:: with SMTP id l5mr16016259otu.9.1633460337867; Tue, 05 Oct 2021 11:58:57 -0700 (PDT) Received: from nuclearis3.gtech (c-98-195-139-126.hsd1.tx.comcast.net. [98.195.139.126]) by smtp.gmail.com with ESMTPSA id l25sm3422067oic.54.2021.10.05.11.58.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Oct 2021 11:58:56 -0700 (PDT) Subject: Re: [PATCH v5 15/29] image: Drop IMAGE_ENABLE_IGNORE To: Simon Glass , U-Boot Mailing List Cc: Andre Przywara , Rasmus Villemoes , Robert Marko , Masahiro Yamada , Tom Rini , Joe Hershberger , Marek Vasut References: <20210926014342.127913-1-sjg@chromium.org> <20210926014342.127913-9-sjg@chromium.org> From: "Alex G." Message-ID: Date: Tue, 5 Oct 2021 13:58:53 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210926014342.127913-9-sjg@chromium.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 9/25/21 8:43 PM, Simon Glass wrote: > We can use the new host_build() function for this, so drop it. s/host_build/tools_build/ > Signed-off-by: Simon Glass Reviewed-by: Alexandru Gagniuc > --- > > (no changes since v1) > > common/image-fit.c | 2 +- > include/image.h | 3 --- > 2 files changed, 1 insertion(+), 4 deletions(-) > > diff --git a/common/image-fit.c b/common/image-fit.c > index 17c6d4e7813..f44f5527b9f 100644 > --- a/common/image-fit.c > +++ b/common/image-fit.c > @@ -1277,7 +1277,7 @@ static int fit_image_check_hash(const void *fit, int noffset, const void *data, > } > printf("%s", algo); > > - if (IMAGE_ENABLE_IGNORE) { > + if (!tools_build()) { > fit_image_hash_get_ignore(fit, noffset, &ignore); > if (ignore) { > printf("-skipped "); > diff --git a/include/image.h b/include/image.h > index e190f59232d..a236180ccdd 100644 > --- a/include/image.h > +++ b/include/image.h > @@ -27,7 +27,6 @@ struct fdt_region; > #include > #include > > -#define IMAGE_ENABLE_IGNORE 0 > #define IMAGE_INDENT_STRING "" > > #else > @@ -37,8 +36,6 @@ struct fdt_region; > #include > #include > > -/* Take notice of the 'ignore' property for hashes */ > -#define IMAGE_ENABLE_IGNORE 1 > #define IMAGE_INDENT_STRING " " > > #endif /* USE_HOSTCC */ >