From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 015F6C07E99 for ; Mon, 12 Jul 2021 11:10:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CDAD560FED for ; Mon, 12 Jul 2021 11:10:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233610AbhGLLM4 (ORCPT ); Mon, 12 Jul 2021 07:12:56 -0400 Received: from szxga08-in.huawei.com ([45.249.212.255]:11262 "EHLO szxga08-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231955AbhGLLMz (ORCPT ); Mon, 12 Jul 2021 07:12:55 -0400 Received: from dggeme703-chm.china.huawei.com (unknown [172.30.72.56]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4GNgrX6KKwz1CJ5j; Mon, 12 Jul 2021 19:04:28 +0800 (CST) Received: from [10.174.178.125] (10.174.178.125) by dggeme703-chm.china.huawei.com (10.1.199.99) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Mon, 12 Jul 2021 19:10:03 +0800 Subject: Re: [PATCH 2/5] mm/vmscan: remove misleading setting to sc->priority To: Michal Hocko CC: , , , , , , , , , , , , , References: <20210710100329.49174-1-linmiaohe@huawei.com> <20210710100329.49174-3-linmiaohe@huawei.com> From: Miaohe Lin Message-ID: Date: Mon, 12 Jul 2021 19:10:03 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.125] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggeme703-chm.china.huawei.com (10.1.199.99) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/7/12 15:24, Michal Hocko wrote: > On Sat 10-07-21 18:03:26, Miaohe Lin wrote: >> The priority field of sc is used to control how many pages we should scan >> at once while we always traverse the list to shrink the pages in these >> functions. So these settings are unneeded and misleading. > > I dunno. I agree that priority is not really used as these operate on > page lists but I am not sure this is worth touching. When I investigated the vmscan code, I thought the order here would control the proportion of the pages in the list to shrink. So I prefer to remove these. Thanks a lot for review and reply! > >> Signed-off-by: Miaohe Lin >> --- >> mm/vmscan.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/mm/vmscan.c b/mm/vmscan.c >> index 6483fe0e2065..fbe53e60b248 100644 >> --- a/mm/vmscan.c >> +++ b/mm/vmscan.c >> @@ -1702,7 +1702,6 @@ unsigned int reclaim_clean_pages_from_list(struct zone *zone, >> { >> struct scan_control sc = { >> .gfp_mask = GFP_KERNEL, >> - .priority = DEF_PRIORITY, >> .may_unmap = 1, >> }; >> struct reclaim_stat stat; >> @@ -2327,7 +2326,6 @@ unsigned long reclaim_pages(struct list_head *page_list) >> unsigned int noreclaim_flag; >> struct scan_control sc = { >> .gfp_mask = GFP_KERNEL, >> - .priority = DEF_PRIORITY, >> .may_writepage = 1, >> .may_unmap = 1, >> .may_swap = 1, >> -- >> 2.23.0 >