From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lionel Landwerlin Subject: Re: [PATCH v2 2/3] drm/i915/perf: enable OAR context save/restore of performance counters Date: Sat, 19 Oct 2019 10:18:41 +0300 Message-ID: References: <20191018005028.47441-1-umesh.nerlige.ramappa@intel.com> <20191018005028.47441-2-umesh.nerlige.ramappa@intel.com> <157144096767.13645.15277004190598810445@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id A65DE89CD5 for ; Sat, 19 Oct 2019 07:18:44 +0000 (UTC) In-Reply-To: <157144096767.13645.15277004190598810445@skylake-alporthouse-com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Umesh Nerlige Ramappa , intel-gfx@lists.freedesktop.org Cc: Lucas De Marchi List-Id: intel-gfx@lists.freedesktop.org T24gMTkvMTAvMjAxOSAwMjoyMiwgQ2hyaXMgV2lsc29uIHdyb3RlOgo+IFF1b3RpbmcgVW1lc2gg TmVybGlnZSBSYW1hcHBhICgyMDE5LTEwLTE4IDAxOjUwOjI3KQo+PiBGcm9tOiBMaW9uZWwgTGFu ZHdlcmxpbiA8bGlvbmVsLmcubGFuZHdlcmxpbkBpbnRlbC5jb20+Cj4+Cj4+IFdlIHdhbnQgdGhp cyBzbyB3ZSBjYW4gcHJlZW1wdCBwZXJmb3JtYW5jZSBxdWVyaWVzIGFuZCBrZWVwIHRoZSBzeXN0 ZW0KPj4gcmVzcG9uc2l2ZSBldmVuIHdoZW4gbG9uZyBydW5uaW5nIHF1ZXJpZXMgYXJlIG9uZ29p bmcuIFdlIGF2b2lkIGRvaW5nCj4+IGl0IGZvciBhbGwgY29udGV4dHMuCj4+Cj4+IHYyOiB1c2Ug TFJJIHRvIG1vZGlmeSBjb250ZXh0IGNvbnRyb2wgKENocmlzKQo+PiB2MzogdXNlIE1BU0tFRF9G SUVMRCB0byBwcm9ncmFtIGp1c3QgdGhlIG1hc2tlZCBiaXRzIChDaHJpcykKPj4gdjQ6IHJldXNl IHJlcXVlc3QgY3JlYXRlZCBkdXJpbmcgZW1pdF9vYV9jb25maWcgKExpb25lbCkKPj4KPj4gU2ln bmVkLW9mZi1ieTogTGlvbmVsIExhbmR3ZXJsaW4gPGxpb25lbC5nLmxhbmR3ZXJsaW5AaW50ZWwu Y29tPgo+PiBTaWduZWQtb2ZmLWJ5OiBVbWVzaCBOZXJsaWdlIFJhbWFwcGEgPHVtZXNoLm5lcmxp Z2UucmFtYXBwYUBpbnRlbC5jb20+Cj4+IC0tLQo+PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2d0 L2ludGVsX2xyYy5oIHwgIDEgKwo+PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcGVyZi5j ICAgIHwgMzUgKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0KPj4gICAyIGZpbGVzIGNoYW5n ZWQsIDM1IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2d0L2ludGVsX2xyYy5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv Z3QvaW50ZWxfbHJjLmgKPj4gaW5kZXggOTlkYzU3NmE0ZTI1Li5iNmRhYWM3MTJjOWUgMTAwNjQ0 Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L2ludGVsX2xyYy5oCj4+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2d0L2ludGVsX2xyYy5oCj4+IEBAIC00Myw2ICs0Myw3IEBAIHN0 cnVjdCBpbnRlbF9lbmdpbmVfY3M7Cj4+ICAgI2RlZmluZSAgICAgICAgICBDVFhfQ1RSTF9FTkdJ TkVfQ1RYX1JFU1RPUkVfSU5ISUJJVCAgICgxIDw8IDApCj4+ICAgI2RlZmluZSAgIENUWF9DVFJM X1JTX0NUWF9FTkFCTEUgICAgICAgICAgICAgICAoMSA8PCAxKQo+PiAgICNkZWZpbmUgICAgICAg ICAgQ1RYX0NUUkxfRU5HSU5FX0NUWF9TQVZFX0lOSElCSVQgICAgICAoMSA8PCAyKQo+PiArI2Rl ZmluZSAgICAgICAgICBHRU4xMl9DVFhfQ1RSTF9PQVJfQ09OVEVYVF9FTkFCTEUgICAgICgxIDw8 IDgpCj4+ICAgI2RlZmluZSBSSU5HX0NPTlRFWFRfU1RBVFVTX1BUUihiYXNlKSAgICAgICAgICBf TU1JTygoYmFzZSkgKyAweDNhMCkKPj4gICAjZGVmaW5lIFJJTkdfRVhFQ0xJU1RfU1FfQ09OVEVO VFMoYmFzZSkgICAgICAgICAgICAgICAgX01NSU8oKGJhc2UpICsgMHg1MTApCj4+ICAgI2RlZmlu ZSBSSU5HX0VYRUNMSVNUX0NPTlRST0woYmFzZSkgICAgICAgICAgICBfTU1JTygoYmFzZSkgKyAw eDU1MCkKPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcGVyZi5jIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9wZXJmLmMKPj4gaW5kZXggOTE3MDc1NThhMGY1Li5j ZTk3YWY0ODRhMzIgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcGVy Zi5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcGVyZi5jCj4+IEBAIC0xODYy LDE0ICsxODYyLDM2IEBAIGdldF9vYV92bWEoc3RydWN0IGk5MTVfcGVyZl9zdHJlYW0gKnN0cmVh bSwgc3RydWN0IGk5MTVfb2FfY29uZmlnICpvYV9jb25maWcpCj4+ICAgICAgICAgIHJldHVybiBp OTE1X3ZtYV9nZXQob2FfYm8tPnZtYSk7Cj4+ICAgfQo+PiAgIAo+PiArc3RhdGljIGludCBnZW4x Ml9lbWl0X29hcl9jb25maWcoc3RydWN0IGk5MTVfcmVxdWVzdCAqcnEsCj4+ICsgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCBpbnRlbF9jb250ZXh0ICpjZSwKPj4gKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgYm9vbCBlbmFibGUpCj4+ICt7Cj4+ICsgICAgICAg dTMyICpjczsKPj4gKwo+PiArICAgICAgIGNzID0gaW50ZWxfcmluZ19iZWdpbihycSwgNCk7Cj4+ ICsgICAgICAgaWYgKElTX0VSUihjcykpCj4+ICsgICAgICAgICAgICAgICByZXR1cm4gUFRSX0VS Uihjcyk7Cj4+ICsKPj4gKyAgICAgICAqY3MrKyA9IE1JX0xPQURfUkVHSVNURVJfSU1NKDEpOwo+ PiArICAgICAgICpjcysrID0gaTkxNV9tbWlvX3JlZ19vZmZzZXQoUklOR19DT05URVhUX0NPTlRS T0woY2UtPmVuZ2luZS0+bW1pb19iYXNlKSk7Cj4+ICsgICAgICAgKmNzKysgPSBfTUFTS0VEX0ZJ RUxEKEdFTjEyX0NUWF9DVFJMX09BUl9DT05URVhUX0VOQUJMRSwKPj4gKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgZW5hYmxlID8gR0VOMTJfQ1RYX0NUUkxfT0FSX0NPTlRFWFRfRU5BQkxF IDogMCk7Cj4+ICsgICAgICAgKmNzKysgPSBNSV9OT09QOwo+PiArCj4+ICsgICAgICAgaW50ZWxf cmluZ19hZHZhbmNlKHJxLCBjcyk7Cj4+ICsKPj4gKyAgICAgICByZXR1cm4gMDsKPj4gK30KPj4g Kwo+PiAgIHN0YXRpYyBpbnQgZW1pdF9vYV9jb25maWcoc3RydWN0IGk5MTVfcGVyZl9zdHJlYW0g KnN0cmVhbSwKPj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IGludGVsX2NvbnRl eHQgKmNlKQo+PiAgIHsKPj4gKyAgICAgICBzdHJ1Y3QgaTkxNV9vYV9jb25maWcgKm9hX2NvbmZp ZyA9IHN0cmVhbS0+b2FfY29uZmlnOwo+PiAgICAgICAgICBzdHJ1Y3QgaTkxNV9yZXF1ZXN0ICpy cTsKPj4gICAgICAgICAgc3RydWN0IGk5MTVfdm1hICp2bWE7Cj4+ICAgICAgICAgIGludCBlcnI7 Cj4+ICAgCj4+IC0gICAgICAgdm1hID0gZ2V0X29hX3ZtYShzdHJlYW0sIHN0cmVhbS0+b2FfY29u ZmlnKTsKPj4gKyAgICAgICB2bWEgPSBnZXRfb2Ffdm1hKHN0cmVhbSwgb2FfY29uZmlnKTsKPj4g ICAgICAgICAgaWYgKElTX0VSUih2bWEpKQo+PiAgICAgICAgICAgICAgICAgIHJldHVybiBQVFJf RVJSKHZtYSk7Cj4+ICAgCj4+IEBAIC0xODkxLDYgKzE5MTMsMTcgQEAgc3RhdGljIGludCBlbWl0 X29hX2NvbmZpZyhzdHJ1Y3QgaTkxNV9wZXJmX3N0cmVhbSAqc3RyZWFtLAo+PiAgICAgICAgICBp ZiAoZXJyKQo+PiAgICAgICAgICAgICAgICAgIGdvdG8gZXJyX2FkZF9yZXF1ZXN0Owo+PiAgIAo+ PiArICAgICAgIC8qCj4+ICsgICAgICAgICogRm9yIEdlbjEyLCBwZXJmb3JtYW5jZSBjb3VudGVy cyBhcmUgY29udGV4dCBzYXZlZC9yZXN0b3JlZC4KPj4gKyAgICAgICAgKiBPbmx5IGVuYWJsZSBp dCBmb3IgdGhlIGNvbnRleHQgdGhhdCByZXF1ZXN0ZWQgdGhpcy4KPj4gKyAgICAgICAgKi8KPj4g KyAgICAgICBpZiAoY2UgPT0gc3RyZWFtLT5waW5uZWRfY3R4ICYmIElTX0dFTihzdHJlYW0tPnBl cmYtPmk5MTUsIDEyKSkgewo+PiArICAgICAgICAgICAgICAgZXJyID0gZ2VuMTJfZW1pdF9vYXJf Y29uZmlnKHJxLCBjZSwgb2FfY29uZmlnICE9IE5VTEwpOwo+PiArICAgICAgICAgICAgICAgaWYg KGVycikKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgZ290byBlcnJfYWRkX3JlcXVlc3Q7Cj4+ ICsKPj4gKyAgICAgICB9Cj4gRG8gd2UgbmVlZCB0byBkbyBlbWl0X29hX2NvbmZpZyhzdHJlYW0s IE5VTEwpIGluCj4gZ2VuOF9kaXNhYmxlX21ldHJpY19zZXQoKT8KPiAtQ2hyaXMKPgpPaCBjcmFw Li4uIEkgbXVzdCBoYXZlIHBvaW50ZWQgdG8gdGhlIHdyb25nIGZ1bmN0aW9uIHRoZW4uLi4KCkkg dGhvdWdodCB0aGlzIHdhcyBjYWxsZWQgZnJvbSBlbmFibGUvZGlzYWJsZV9tZXRyaWNfc2V0KCku CgoKSSBndWVzcyB0aGUgYmVzdCB0aGluZyB3b3VsZCBiZSB0byBjYWxsIHRoaXMgZnJvbSAKZ2Vu MTJfZW5hYmxlL2Rpc2FibGVfbWV0cmljX3NldCgpLgoKQnV0IHRoZW4gd2Ugd291bGQgbmVlZCB0 byBjcmVhdGUgYSByZXF1ZXN0IGZvciB0aGUgcGlubmVkX2N0eC4KClNvcnJ5IDooCgoKLUxpb25l bAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4