From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1f1DSy-0006ZI-BY for mharc-grub-devel@gnu.org; Wed, 28 Mar 2018 11:58:24 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33940) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f1DSw-0006Xt-Mv for grub-devel@gnu.org; Wed, 28 Mar 2018 11:58:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f1DSt-0002jE-KX for grub-devel@gnu.org; Wed, 28 Mar 2018 11:58:22 -0400 Received: from mail-wr0-f178.google.com ([209.85.128.178]:39471) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f1DSt-0002iq-E8 for grub-devel@gnu.org; Wed, 28 Mar 2018 11:58:19 -0400 Received: by mail-wr0-f178.google.com with SMTP id c24so2732512wrc.6 for ; Wed, 28 Mar 2018 08:58:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=t5CMhRE0WnxfiShYeXv6mBpKSE/kADcDm3OWwmVWzXA=; b=oF6pOE4eMcghjcINJODfRC+cS3OzT5GCEeAG3zivIymd9mL0YWWvSmd0E6j+JgNt0X hpzG4cOt5x2VUkvnf5wWOwN+oz08ZmYwZdGb35Sr54jJrF/RXHXBgbfrLGeba+aMEJhK oGK4nDb4X2bnurktSKPg0dU9z3cloHzOZwpewocb0Wn1xVv0maG22VmNQ2c9Hu2e4vcZ MBmnrzSnRQhkDMTV83cwzTF5IUFqoNvvR7bufY3coDTUnfhXKaUQ1ElENW6z2+pgyYo1 ffV0TCtz6G91XrQ47d/f5arV5Jj1IkUuRZYeij6otaEa4oxjh7Y2utSjRdB+R8BUu7Cj EFHA== X-Gm-Message-State: AElRT7FzKNbuPv7iUIi09ffjJt68EwLEjJEelkRKg7Df1Z/AKzdAAIVk lWK+TNkSf41ZsFS9LzUJx9WXFA== X-Google-Smtp-Source: AIpwx4+i7E2QkoZg9AP8kkRlWWbDjtc+6rx2Q87BSVI4lV8SMTQ94tbwVpQ8PQSRjLZI0o1JTKyuSg== X-Received: by 10.223.188.135 with SMTP id g7mr3659672wrh.69.1522252698169; Wed, 28 Mar 2018 08:58:18 -0700 (PDT) Received: from shalem.localdomain (546A5441.cm-12-3b.dynamic.ziggo.nl. [84.106.84.65]) by smtp.gmail.com with ESMTPSA id k1sm5457800wrf.66.2018.03.28.08.58.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Mar 2018 08:58:17 -0700 (PDT) Subject: Re: [PATCH 2/4] Accept Both ESC and F8 as user interrupt keys To: Lennart Sorensen Cc: The development of GNU GRUB , Daniel Kiper References: <20180328145028.21555-1-hdegoede@redhat.com> <20180328145028.21555-3-hdegoede@redhat.com> <20180328145631.7rqxej4yrn5keydr@csclub.uwaterloo.ca> <551a4dfe-9ed6-ef5e-196a-b8e3fc0d3f54@redhat.com> <20180328151152.iat3ti3hxiehrreb@csclub.uwaterloo.ca> From: Hans de Goede Message-ID: Date: Wed, 28 Mar 2018 17:58:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180328151152.iat3ti3hxiehrreb@csclub.uwaterloo.ca> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.128.178 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Mar 2018 15:58:24 -0000 Hi, On 28-03-18 17:11, Lennart Sorensen wrote: > On Wed, Mar 28, 2018 at 05:06:53PM +0200, Hans de Goede wrote: >> Hmm, well people will still be able to use ESC to get the grub boot >> menu, rather then the firmware boot-menu on those. >> >> The problem is that our current check for ESC only approach is problematic >> because it conflicts with the enter firmware-setup key on almost all Bay Trail, >> Cherry Trail and Apollo Lake devices. You need to try hard to find a device >> in one of those 3 categories which does not use ESC for this. Note I'm >> aware some devices exist, but using ESC for this is really really common >> among these devices. >> >> I'm open to other suggestions, but I think we really need to add another >> key to avoid the pressing ESC at boot already has another meaning problem >> and F8 seems like an ok choice. >> >> Either way thank you for the input on this. > > I don't disagree about having another key, I just disagree that F8 is > a good choice. > > Looking at https://kb.wisc.edu/page.php?id=58779#here it appears no one > uses F4 for anything. That would seem like a better choice than F8 > at least. F6 also seems to be free but F4 seems nicer on desktop > keyboards. Looking at that table I have to agree that F4 seems like the best second key to use. Actually looking at that table ESC seems like a poor choice, but I guess it makes sense for serial-terminals as well as from a general UI pov (and we're stuck with it now anyways). I'm going to wait for Daniel's review of the other patches before I do a v2 of this patch-set. I will switch to F4 for v2. Regards, Hans