From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFF09C43331 for ; Mon, 11 Nov 2019 08:12:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A7C3F20818 for ; Mon, 11 Nov 2019 08:12:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=xenosoft.de header.i=@xenosoft.de header.b="THKFvyK+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726878AbfKKIMZ (ORCPT ); Mon, 11 Nov 2019 03:12:25 -0500 Received: from mo4-p01-ob.smtp.rzone.de ([85.215.255.53]:30796 "EHLO mo4-p01-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726793AbfKKIMZ (ORCPT ); Mon, 11 Nov 2019 03:12:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1573459939; s=strato-dkim-0002; d=xenosoft.de; h=In-Reply-To:Date:Message-ID:References:Cc:To:From:Subject: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=3/MqObd2KBYhkLHMy8MLFEFld3owrwS9kDyklpFMgIE=; b=THKFvyK+BA2J7h+Us/oJFGZdjASlGSrN9LU1gCtEjpy6bbugIvGMK9eso0XW8pLE0T ukwCMw5Yq4ii8C1l71nnXsV6CPT1omxfNpqyBSWQlwpUiU23JA6P3+9dmHym0FBQ/eE8 thv/DASfyOqkUxg2X7jL/Ar+mIhcnvgq1ys3JJT6V6jjFesBT8yu/uH7+bobiFkSvAJB rtjWq4GNEPUPWtas/w9hO0DsCbPv240sf/lQUFU5LSFnfFak4wMbClpUL5F596Yq4OKL r3sh0483H1rL1YCot9U/4cNMmyu9kr6ZmosH5SJxXa00Jp/utaxg3G7cGzUnm/do/4zc MdeQ== X-RZG-AUTH: ":L2QefEenb+UdBJSdRCXu93KJ1bmSGnhMdmOod1DhGM4l4Hio94KKxRySfLxnHfJ+Dkjp5DdBJSrwuuqxvPhUdStcud4ztdvxL67fR7ahIrEKaw==" X-RZG-CLASS-ID: mo00 Received: from [IPv6:2a02:8109:89c0:ebfc:7cd8:48a4:7aa4:e860] by smtp.strato.de (RZmta 44.29.0 AUTH) with ESMTPSA id q007c8vAB8CCS3t (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Mon, 11 Nov 2019 09:12:12 +0100 (CET) Subject: Re: Bug 205201 - overflow of DMA mask and bus mask From: Christian Zigotzky To: Christoph Hellwig Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, Benjamin Herrenschmidt , paulus@samba.org, darren@stevens-zone.net, "contact@a-eon.com" , rtd2@xtra.co.nz, mad skateman , Rob Herring , linuxppc-dev References: <20181213112511.GA4574@lst.de> <008c981e-bdd2-21a7-f5f7-c57e4850ae9a@xenosoft.de> <20190103073622.GA24323@lst.de> <71A251A5-FA06-4019-B324-7AED32F7B714@xenosoft.de> <1b0c5c21-2761-d3a3-651b-3687bb6ae694@xenosoft.de> <3504ee70-02de-049e-6402-2d530bf55a84@xenosoft.de> <46025f1b-db20-ac23-7dcd-10bc43bbb6ee@xenosoft.de> <20191105162856.GA15402@lst.de> <2f3c81bd-d498-066a-12c0-0a7715cda18f@xenosoft.de> Message-ID: Date: Mon, 11 Nov 2019 09:12:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: de-DE Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10 November 2019 at 08:27 am, Christian Zigotzky wrote: > On 07 November 2019 at 10:53 am, Christian Zigotzky wrote: >> On 05 November 2019 at 05:28 pm, Christoph Hellwig wrote: >>> On Tue, Nov 05, 2019 at 08:56:27AM +0100, Christian Zigotzky wrote: >>>> Hi All, >>>> >>>> We still have DMA problems with some PCI devices. Since the PowerPC >>>> updates >>>> 4.21-1 [1] we need to decrease the RAM to 3500MB (mem=3500M) if we >>>> want to >>>> work with our PCI devices. The FSL P5020 and P5040 have these problems >>>> currently. >>>> >>>> Error message: >>>> >>>> [   25.654852] bttv 1000:04:05.0: overflow 0x00000000fe077000+4096 >>>> of DMA >>>> mask ffffffff bus mask df000000 >>>> >>>> All 5.x Linux kernels can't initialize a SCSI PCI card anymore so >>>> booting >>>> of a Linux userland isn't possible. >>>> >>>> PLEASE check the DMA changes in the PowerPC updates 4.21-1 [1]. The >>>> kernel >>>> 4.20 works with all PCI devices without limitation of RAM. >>> Can you send me the .config and a dmesg?  And in the meantime try the >>> patch below? >>> >>> --- >>> >From 4d659b7311bd4141fdd3eeeb80fa2d7602ea01d4 Mon Sep 17 00:00:00 2001 >>> From: Nicolas Saenz Julienne >>> Date: Fri, 18 Oct 2019 13:00:43 +0200 >>> Subject: dma-direct: check for overflows on 32 bit DMA addresses >>> >>> As seen on the new Raspberry Pi 4 and sta2x11's DMA implementation >>> it is >>> possible for a device configured with 32 bit DMA addresses and a >>> partial >>> DMA mapping located at the end of the address space to overflow. It >>> happens when a higher physical address, not DMAable, is translated to >>> it's DMA counterpart. >>> >>> For example the Raspberry Pi 4, configurable up to 4 GB of memory, has >>> an interconnect capable of addressing the lower 1 GB of physical memory >>> with a DMA offset of 0xc0000000. It transpires that, any attempt to >>> translate physical addresses higher than the first GB will result in an >>> overflow which dma_capable() can't detect as it only checks for >>> addresses bigger then the maximum allowed DMA address. >>> >>> Fix this by verifying in dma_capable() if the DMA address range >>> provided >>> is at any point lower than the minimum possible DMA address on the bus. >>> >>> Signed-off-by: Nicolas Saenz Julienne >>> --- >>>   include/linux/dma-direct.h | 8 ++++++++ >>>   1 file changed, 8 insertions(+) >>> >>> diff --git a/include/linux/dma-direct.h b/include/linux/dma-direct.h >>> index adf993a3bd58..6ad9e9ea7564 100644 >>> --- a/include/linux/dma-direct.h >>> +++ b/include/linux/dma-direct.h >>> @@ -3,6 +3,7 @@ >>>   #define _LINUX_DMA_DIRECT_H 1 >>>     #include >>> +#include /* for min_low_pfn */ >>>   #include >>>     #ifdef CONFIG_ARCH_HAS_PHYS_TO_DMA >>> @@ -27,6 +28,13 @@ static inline bool dma_capable(struct device >>> *dev, dma_addr_t addr, size_t size) >>>       if (!dev->dma_mask) >>>           return false; >>>   +#ifndef CONFIG_ARCH_DMA_ADDR_T_64BIT >>> +    /* Check if DMA address overflowed */ >>> +    if (min(addr, addr + size - 1) < >>> +        __phys_to_dma(dev, (phys_addr_t)(min_low_pfn << PAGE_SHIFT))) >>> +        return false; >>> +#endif >>> + >>>       return addr + size - 1 <= >>>           min_not_zero(*dev->dma_mask, dev->bus_dma_mask); >>>   } >> Hello Christoph, >> >> Thanks a lot for your patch! Unfortunately this patch doesn't solve >> the issue. >> >> Error messages: >> >> [    6.041163] bttv: driver version 0.9.19 loaded >> [    6.041167] bttv: using 8 buffers with 2080k (520 pages) each for >> capture >> [    6.041559] bttv: Bt8xx card found (0) >> [    6.041609] bttv: 0: Bt878 (rev 17) at 1000:04:05.0, irq: 19, >> latency: 128, mmio: 0xc20001000 >> [    6.041622] bttv: 0: using: Typhoon TView RDS + FM Stereo / KNC1 >> TV Station RDS [card=53,insmod option] >> [    6.042216] bttv: 0: tuner type=5 >> [    6.111994] bttv: 0: audio absent, no audio device found! >> [    6.176425] bttv: 0: Setting PLL: 28636363 => 35468950 (needs up >> to 100ms) >> [    6.200005] bttv: PLL set ok >> [    6.209351] bttv: 0: registered device video0 >> [    6.211576] bttv: 0: registered device vbi0 >> [    6.214897] bttv: 0: registered device radio0 >> [  114.218806] bttv 1000:04:05.0: overflow 0x00000000ff507000+4096 of >> DMA mask ffffffff bus mask df000000 >> [  114.218848] Modules linked in: rfcomm bnep tuner_simple >> tuner_types tea5767 tuner tda7432 tvaudio msp3400 bttv tea575x >> tveeprom videobuf_dma_sg videobuf_core rc_core videodev mc btusb >> btrtl btbcm btintel bluetooth uio_pdrv_genirq uio ecdh_generic ecc >> [  114.219012] [c0000001ecddf720] [80000000008ff6e8] >> .buffer_prepare+0x150/0x268 [bttv] >> [  114.219029] [c0000001ecddf860] [80000000008fff6c] >> .bttv_qbuf+0x50/0x64 [bttv] >> >> ----- >> >> Trace: >> >> [  462.783184] Call Trace: >> [  462.783187] [c0000001c6c67420] [c0000000000b3358] >> .report_addr+0xb8/0xc0 (unreliable) >> [  462.783192] [c0000001c6c67490] [c0000000000b351c] >> .dma_direct_map_page+0xf0/0x128 >> [  462.783195] [c0000001c6c67530] [c0000000000b35b0] >> .dma_direct_map_sg+0x5c/0xac >> [  462.783205] [c0000001c6c675e0] [8000000000862e88] >> .__videobuf_iolock+0x660/0x6d8 [videobuf_dma_sg] >> [  462.783220] [c0000001c6c676b0] [8000000000854274] >> .videobuf_iolock+0x98/0xb4 [videobuf_core] >> [  462.783271] [c0000001c6c67720] [80000000008686e8] >> .buffer_prepare+0x150/0x268 [bttv] >> [  462.783276] [c0000001c6c677c0] [8000000000854afc] >> .videobuf_qbuf+0x2b8/0x428 [videobuf_core] >> [  462.783288] [c0000001c6c67860] [8000000000868f6c] >> .bttv_qbuf+0x50/0x64 [bttv] >> [  462.783383] [c0000001c6c678e0] [80000000007bf208] >> .v4l_qbuf+0x54/0x60 [videodev] >> [  462.783402] [c0000001c6c67970] [80000000007c1eac] >> .__video_do_ioctl+0x30c/0x3f8 [videodev] >> [  462.783421] [c0000001c6c67a80] [80000000007c3c08] >> .video_usercopy+0x18c/0x3dc [videodev] >> [  462.783440] [c0000001c6c67c00] [80000000007bb14c] >> .v4l2_ioctl+0x60/0x78 [videodev] >> [  462.783460] [c0000001c6c67c90] [80000000007d3c48] >> .v4l2_compat_ioctl32+0x9b4/0x1850 [videodev] >> [  462.783468] [c0000001c6c67d70] [c0000000001ad9cc] >> .__se_compat_sys_ioctl+0x284/0x127c >> [  462.783473] [c0000001c6c67e20] [c00000000000067c] >> system_call+0x60/0x6c >> [  462.783475] Instruction dump: >> [  462.783477] 40fe0044 60000000 892255d0 2f890000 40fe0020 3c82ffc5 >> 39200001 60000000 >> [  462.783483] 38842029 992255d0 485ad0d9 60000000 <0fe00000> >> 38210070 e8010010 7c0803a6 >> [  462.783490] ---[ end trace b677d4a00458e277 ]--- >> >> ----- >> >> dmesg fsl p5040: https://bugzilla.kernel.org/attachment.cgi?id=285813 >> >> Kernel 5.4-rc6 config for the Cyrus+ board and for the QEMU ppce500 >> board (CPU: P5040 and P5020): >> https://bugzilla.kernel.org/attachment.cgi?id=285815 >> >> Bug report: https://bugzilla.kernel.org/show_bug.cgi?id=205201 >> >> Thanks for your help, >> >> Christian > > Christoph, > > Do you have another patch for testing or shall I bisect? > > Thanks, > Christian Hi Christoph, I have seen that I have activated the kernel config option CONFIG_ARCH_DMA_ADDR_T_64BIT. That means your code in your patch won't work if this kernel option is enabled. +#ifndef CONFIG_ARCH_DMA_ADDR_T_64BIT +    /* Check if DMA address overflowed */ +    if (min(addr, addr + size - 1) < +        __phys_to_dma(dev, (phys_addr_t)(min_low_pfn << PAGE_SHIFT))) +        return false; +#endif I will delete the lines with ifndef and endif and will try it again. Cheers, Christian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F462C43331 for ; Mon, 11 Nov 2019 08:15:13 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E0EA42075C for ; Mon, 11 Nov 2019 08:15:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=xenosoft.de header.i=@xenosoft.de header.b="pwN+pob8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E0EA42075C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xenosoft.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 47BNwF2ZYKzF3m6 for ; Mon, 11 Nov 2019 19:15:09 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.helo=mo6-p01-ob.smtp.rzone.de (client-ip=2a01:238:20a:202:5301::7; helo=mo6-p01-ob.smtp.rzone.de; envelope-from=chzigotzky@xenosoft.de; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=xenosoft.de Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=xenosoft.de header.i=@xenosoft.de header.b="pwN+pob8"; dkim-atps=neutral Received: from mo6-p01-ob.smtp.rzone.de (mo6-p01-ob.smtp.rzone.de [IPv6:2a01:238:20a:202:5301::7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 47BNsz4yhMzF1wq for ; Mon, 11 Nov 2019 19:13:10 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1573459982; s=strato-dkim-0002; d=xenosoft.de; h=In-Reply-To:Date:Message-ID:References:Cc:To:From:Subject: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=3/MqObd2KBYhkLHMy8MLFEFld3owrwS9kDyklpFMgIE=; b=pwN+pob8lO9IgKyFpytU6W73/KDlV0u6ofj9RCEgidFFiu0EvBV+d4pde9RKbyWmmq jvISl+aFbRlg4ZhzJe7v5Dq7TM8ZD9eH1A+AaMqVVcngCUxnbyZJDAj8r3+P+nPDoRwi 8rIlWDMJVmsLR9G5ZwTUjs5RutxfhvmBVju3cO9jbCAu/mUXB4JJPuTbAFfdU9e4aY6j X5FhEZPFCA6a5IeYKV4rJcROtGyw5eELfPJ3o1t3DblZnwwU/Yb0aG/oPJLFJ38wy7gj /JNM+iiKGy6G0iD109BsQsXcCYnuNTFlCEapt6nex9/Zbwp1J0E7k2026h6opSJ/cHOR 6zKQ== X-RZG-AUTH: ":L2QefEenb+UdBJSdRCXu93KJ1bmSGnhMdmOod1DhGM4l4Hio94KKxRySfLxnHfJ+Dkjp5DdBJSrwuuqxvPhUdStcud4ztdvxL67fR7ahIrEKaw==" X-RZG-CLASS-ID: mo00 Received: from [IPv6:2a02:8109:89c0:ebfc:7cd8:48a4:7aa4:e860] by smtp.strato.de (RZmta 44.29.0 AUTH) with ESMTPSA id q007c8vAB8CCS3t (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Mon, 11 Nov 2019 09:12:12 +0100 (CET) Subject: Re: Bug 205201 - overflow of DMA mask and bus mask From: Christian Zigotzky To: Christoph Hellwig References: <20181213112511.GA4574@lst.de> <008c981e-bdd2-21a7-f5f7-c57e4850ae9a@xenosoft.de> <20190103073622.GA24323@lst.de> <71A251A5-FA06-4019-B324-7AED32F7B714@xenosoft.de> <1b0c5c21-2761-d3a3-651b-3687bb6ae694@xenosoft.de> <3504ee70-02de-049e-6402-2d530bf55a84@xenosoft.de> <46025f1b-db20-ac23-7dcd-10bc43bbb6ee@xenosoft.de> <20191105162856.GA15402@lst.de> <2f3c81bd-d498-066a-12c0-0a7715cda18f@xenosoft.de> Message-ID: Date: Mon, 11 Nov 2019 09:12:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: de-DE X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, darren@stevens-zone.net, mad skateman , linux-kernel@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, Rob Herring , paulus@samba.org, rtd2@xtra.co.nz, "contact@a-eon.com" , linuxppc-dev Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 10 November 2019 at 08:27 am, Christian Zigotzky wrote: > On 07 November 2019 at 10:53 am, Christian Zigotzky wrote: >> On 05 November 2019 at 05:28 pm, Christoph Hellwig wrote: >>> On Tue, Nov 05, 2019 at 08:56:27AM +0100, Christian Zigotzky wrote: >>>> Hi All, >>>> >>>> We still have DMA problems with some PCI devices. Since the PowerPC >>>> updates >>>> 4.21-1 [1] we need to decrease the RAM to 3500MB (mem=3500M) if we >>>> want to >>>> work with our PCI devices. The FSL P5020 and P5040 have these problems >>>> currently. >>>> >>>> Error message: >>>> >>>> [   25.654852] bttv 1000:04:05.0: overflow 0x00000000fe077000+4096 >>>> of DMA >>>> mask ffffffff bus mask df000000 >>>> >>>> All 5.x Linux kernels can't initialize a SCSI PCI card anymore so >>>> booting >>>> of a Linux userland isn't possible. >>>> >>>> PLEASE check the DMA changes in the PowerPC updates 4.21-1 [1]. The >>>> kernel >>>> 4.20 works with all PCI devices without limitation of RAM. >>> Can you send me the .config and a dmesg?  And in the meantime try the >>> patch below? >>> >>> --- >>> >From 4d659b7311bd4141fdd3eeeb80fa2d7602ea01d4 Mon Sep 17 00:00:00 2001 >>> From: Nicolas Saenz Julienne >>> Date: Fri, 18 Oct 2019 13:00:43 +0200 >>> Subject: dma-direct: check for overflows on 32 bit DMA addresses >>> >>> As seen on the new Raspberry Pi 4 and sta2x11's DMA implementation >>> it is >>> possible for a device configured with 32 bit DMA addresses and a >>> partial >>> DMA mapping located at the end of the address space to overflow. It >>> happens when a higher physical address, not DMAable, is translated to >>> it's DMA counterpart. >>> >>> For example the Raspberry Pi 4, configurable up to 4 GB of memory, has >>> an interconnect capable of addressing the lower 1 GB of physical memory >>> with a DMA offset of 0xc0000000. It transpires that, any attempt to >>> translate physical addresses higher than the first GB will result in an >>> overflow which dma_capable() can't detect as it only checks for >>> addresses bigger then the maximum allowed DMA address. >>> >>> Fix this by verifying in dma_capable() if the DMA address range >>> provided >>> is at any point lower than the minimum possible DMA address on the bus. >>> >>> Signed-off-by: Nicolas Saenz Julienne >>> --- >>>   include/linux/dma-direct.h | 8 ++++++++ >>>   1 file changed, 8 insertions(+) >>> >>> diff --git a/include/linux/dma-direct.h b/include/linux/dma-direct.h >>> index adf993a3bd58..6ad9e9ea7564 100644 >>> --- a/include/linux/dma-direct.h >>> +++ b/include/linux/dma-direct.h >>> @@ -3,6 +3,7 @@ >>>   #define _LINUX_DMA_DIRECT_H 1 >>>     #include >>> +#include /* for min_low_pfn */ >>>   #include >>>     #ifdef CONFIG_ARCH_HAS_PHYS_TO_DMA >>> @@ -27,6 +28,13 @@ static inline bool dma_capable(struct device >>> *dev, dma_addr_t addr, size_t size) >>>       if (!dev->dma_mask) >>>           return false; >>>   +#ifndef CONFIG_ARCH_DMA_ADDR_T_64BIT >>> +    /* Check if DMA address overflowed */ >>> +    if (min(addr, addr + size - 1) < >>> +        __phys_to_dma(dev, (phys_addr_t)(min_low_pfn << PAGE_SHIFT))) >>> +        return false; >>> +#endif >>> + >>>       return addr + size - 1 <= >>>           min_not_zero(*dev->dma_mask, dev->bus_dma_mask); >>>   } >> Hello Christoph, >> >> Thanks a lot for your patch! Unfortunately this patch doesn't solve >> the issue. >> >> Error messages: >> >> [    6.041163] bttv: driver version 0.9.19 loaded >> [    6.041167] bttv: using 8 buffers with 2080k (520 pages) each for >> capture >> [    6.041559] bttv: Bt8xx card found (0) >> [    6.041609] bttv: 0: Bt878 (rev 17) at 1000:04:05.0, irq: 19, >> latency: 128, mmio: 0xc20001000 >> [    6.041622] bttv: 0: using: Typhoon TView RDS + FM Stereo / KNC1 >> TV Station RDS [card=53,insmod option] >> [    6.042216] bttv: 0: tuner type=5 >> [    6.111994] bttv: 0: audio absent, no audio device found! >> [    6.176425] bttv: 0: Setting PLL: 28636363 => 35468950 (needs up >> to 100ms) >> [    6.200005] bttv: PLL set ok >> [    6.209351] bttv: 0: registered device video0 >> [    6.211576] bttv: 0: registered device vbi0 >> [    6.214897] bttv: 0: registered device radio0 >> [  114.218806] bttv 1000:04:05.0: overflow 0x00000000ff507000+4096 of >> DMA mask ffffffff bus mask df000000 >> [  114.218848] Modules linked in: rfcomm bnep tuner_simple >> tuner_types tea5767 tuner tda7432 tvaudio msp3400 bttv tea575x >> tveeprom videobuf_dma_sg videobuf_core rc_core videodev mc btusb >> btrtl btbcm btintel bluetooth uio_pdrv_genirq uio ecdh_generic ecc >> [  114.219012] [c0000001ecddf720] [80000000008ff6e8] >> .buffer_prepare+0x150/0x268 [bttv] >> [  114.219029] [c0000001ecddf860] [80000000008fff6c] >> .bttv_qbuf+0x50/0x64 [bttv] >> >> ----- >> >> Trace: >> >> [  462.783184] Call Trace: >> [  462.783187] [c0000001c6c67420] [c0000000000b3358] >> .report_addr+0xb8/0xc0 (unreliable) >> [  462.783192] [c0000001c6c67490] [c0000000000b351c] >> .dma_direct_map_page+0xf0/0x128 >> [  462.783195] [c0000001c6c67530] [c0000000000b35b0] >> .dma_direct_map_sg+0x5c/0xac >> [  462.783205] [c0000001c6c675e0] [8000000000862e88] >> .__videobuf_iolock+0x660/0x6d8 [videobuf_dma_sg] >> [  462.783220] [c0000001c6c676b0] [8000000000854274] >> .videobuf_iolock+0x98/0xb4 [videobuf_core] >> [  462.783271] [c0000001c6c67720] [80000000008686e8] >> .buffer_prepare+0x150/0x268 [bttv] >> [  462.783276] [c0000001c6c677c0] [8000000000854afc] >> .videobuf_qbuf+0x2b8/0x428 [videobuf_core] >> [  462.783288] [c0000001c6c67860] [8000000000868f6c] >> .bttv_qbuf+0x50/0x64 [bttv] >> [  462.783383] [c0000001c6c678e0] [80000000007bf208] >> .v4l_qbuf+0x54/0x60 [videodev] >> [  462.783402] [c0000001c6c67970] [80000000007c1eac] >> .__video_do_ioctl+0x30c/0x3f8 [videodev] >> [  462.783421] [c0000001c6c67a80] [80000000007c3c08] >> .video_usercopy+0x18c/0x3dc [videodev] >> [  462.783440] [c0000001c6c67c00] [80000000007bb14c] >> .v4l2_ioctl+0x60/0x78 [videodev] >> [  462.783460] [c0000001c6c67c90] [80000000007d3c48] >> .v4l2_compat_ioctl32+0x9b4/0x1850 [videodev] >> [  462.783468] [c0000001c6c67d70] [c0000000001ad9cc] >> .__se_compat_sys_ioctl+0x284/0x127c >> [  462.783473] [c0000001c6c67e20] [c00000000000067c] >> system_call+0x60/0x6c >> [  462.783475] Instruction dump: >> [  462.783477] 40fe0044 60000000 892255d0 2f890000 40fe0020 3c82ffc5 >> 39200001 60000000 >> [  462.783483] 38842029 992255d0 485ad0d9 60000000 <0fe00000> >> 38210070 e8010010 7c0803a6 >> [  462.783490] ---[ end trace b677d4a00458e277 ]--- >> >> ----- >> >> dmesg fsl p5040: https://bugzilla.kernel.org/attachment.cgi?id=285813 >> >> Kernel 5.4-rc6 config for the Cyrus+ board and for the QEMU ppce500 >> board (CPU: P5040 and P5020): >> https://bugzilla.kernel.org/attachment.cgi?id=285815 >> >> Bug report: https://bugzilla.kernel.org/show_bug.cgi?id=205201 >> >> Thanks for your help, >> >> Christian > > Christoph, > > Do you have another patch for testing or shall I bisect? > > Thanks, > Christian Hi Christoph, I have seen that I have activated the kernel config option CONFIG_ARCH_DMA_ADDR_T_64BIT. That means your code in your patch won't work if this kernel option is enabled. +#ifndef CONFIG_ARCH_DMA_ADDR_T_64BIT +    /* Check if DMA address overflowed */ +    if (min(addr, addr + size - 1) < +        __phys_to_dma(dev, (phys_addr_t)(min_low_pfn << PAGE_SHIFT))) +        return false; +#endif I will delete the lines with ifndef and endif and will try it again. Cheers, Christian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96878C43331 for ; Mon, 11 Nov 2019 08:12:33 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5AC182075C for ; Mon, 11 Nov 2019 08:12:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=xenosoft.de header.i=@xenosoft.de header.b="rBebcfgB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5AC182075C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xenosoft.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 7862CB7D; Mon, 11 Nov 2019 08:12:31 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id E00EDACD for ; Mon, 11 Nov 2019 08:12:30 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mo4-p01-ob.smtp.rzone.de (mo4-p01-ob.smtp.rzone.de [85.215.255.50]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id D95FD712 for ; Mon, 11 Nov 2019 08:12:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1573459948; s=strato-dkim-0002; d=xenosoft.de; h=In-Reply-To:Date:Message-ID:References:Cc:To:From:Subject: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=3/MqObd2KBYhkLHMy8MLFEFld3owrwS9kDyklpFMgIE=; b=rBebcfgBBqHr3aMYlJYxHn96Rz8mXyQNdgn9JVE8ZA2774oyRQBrsfwTXKjNy0PJKA 9Mtthp8FuJyQeRHrWmuskZUkxYQWMWsCwY0y8Rhmro9AQj9SHQN5B2SKfrqqy4Nj0jpO fVHYEe3tEjY4y9V0sMWA+9RlNbsl++Pe8Q5+fAMrKI/3uvLpOwdsGlHMEAj+NErZyAf2 q4jzzgyDuMpJtBjcduGMXE6fNxW/ts5peAWfEI1bTxO6WCZkBJY+6nq8iQ7j7YV8gVUZ 5wpW0IYTkz6yKzFlFbIAUK1nZFSjA4oSBjWON+HnoTgnOcCcZws+nM343Ji/Fb9AEIFu NtaA== X-RZG-AUTH: ":L2QefEenb+UdBJSdRCXu93KJ1bmSGnhMdmOod1DhGM4l4Hio94KKxRySfLxnHfJ+Dkjp5DdBJSrwuuqxvPhUdStcud4ztdvxL67fR7ahIrEKaw==" X-RZG-CLASS-ID: mo00 Received: from [IPv6:2a02:8109:89c0:ebfc:7cd8:48a4:7aa4:e860] by smtp.strato.de (RZmta 44.29.0 AUTH) with ESMTPSA id q007c8vAB8CCS3t (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Mon, 11 Nov 2019 09:12:12 +0100 (CET) Subject: Re: Bug 205201 - overflow of DMA mask and bus mask From: Christian Zigotzky To: Christoph Hellwig References: <20181213112511.GA4574@lst.de> <008c981e-bdd2-21a7-f5f7-c57e4850ae9a@xenosoft.de> <20190103073622.GA24323@lst.de> <71A251A5-FA06-4019-B324-7AED32F7B714@xenosoft.de> <1b0c5c21-2761-d3a3-651b-3687bb6ae694@xenosoft.de> <3504ee70-02de-049e-6402-2d530bf55a84@xenosoft.de> <46025f1b-db20-ac23-7dcd-10bc43bbb6ee@xenosoft.de> <20191105162856.GA15402@lst.de> <2f3c81bd-d498-066a-12c0-0a7715cda18f@xenosoft.de> Message-ID: Date: Mon, 11 Nov 2019 09:12:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: Content-Language: de-DE Cc: linux-arch@vger.kernel.org, darren@stevens-zone.net, mad skateman , Benjamin Herrenschmidt , linux-kernel@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, Rob Herring , paulus@samba.org, rtd2@xtra.co.nz, "contact@a-eon.com" , linuxppc-dev X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org T24gMTAgTm92ZW1iZXIgMjAxOSBhdCAwODoyNyBhbSwgQ2hyaXN0aWFuIFppZ290emt5IHdyb3Rl Ogo+IE9uIDA3IE5vdmVtYmVyIDIwMTkgYXQgMTA6NTMgYW0sIENocmlzdGlhbiBaaWdvdHpreSB3 cm90ZToKPj4gT24gMDUgTm92ZW1iZXIgMjAxOSBhdCAwNToyOCBwbSwgQ2hyaXN0b3BoIEhlbGx3 aWcgd3JvdGU6Cj4+PiBPbiBUdWUsIE5vdiAwNSwgMjAxOSBhdCAwODo1NjoyN0FNICswMTAwLCBD aHJpc3RpYW4gWmlnb3R6a3kgd3JvdGU6Cj4+Pj4gSGkgQWxsLAo+Pj4+Cj4+Pj4gV2Ugc3RpbGwg aGF2ZSBETUEgcHJvYmxlbXMgd2l0aCBzb21lIFBDSSBkZXZpY2VzLiBTaW5jZSB0aGUgUG93ZXJQ QyAKPj4+PiB1cGRhdGVzCj4+Pj4gNC4yMS0xIFsxXSB3ZSBuZWVkIHRvIGRlY3JlYXNlIHRoZSBS QU0gdG8gMzUwME1CIChtZW09MzUwME0pIGlmIHdlIAo+Pj4+IHdhbnQgdG8KPj4+PiB3b3JrIHdp dGggb3VyIFBDSSBkZXZpY2VzLiBUaGUgRlNMIFA1MDIwIGFuZCBQNTA0MCBoYXZlIHRoZXNlIHBy b2JsZW1zCj4+Pj4gY3VycmVudGx5Lgo+Pj4+Cj4+Pj4gRXJyb3IgbWVzc2FnZToKPj4+Pgo+Pj4+ IFvCoMKgIDI1LjY1NDg1Ml0gYnR0diAxMDAwOjA0OjA1LjA6IG92ZXJmbG93IDB4MDAwMDAwMDBm ZTA3NzAwMCs0MDk2IAo+Pj4+IG9mIERNQQo+Pj4+IG1hc2sgZmZmZmZmZmYgYnVzIG1hc2sgZGYw MDAwMDAKPj4+Pgo+Pj4+IEFsbCA1LnggTGludXgga2VybmVscyBjYW4ndCBpbml0aWFsaXplIGEg U0NTSSBQQ0kgY2FyZCBhbnltb3JlIHNvIAo+Pj4+IGJvb3RpbmcKPj4+PiBvZiBhIExpbnV4IHVz ZXJsYW5kIGlzbid0IHBvc3NpYmxlLgo+Pj4+Cj4+Pj4gUExFQVNFIGNoZWNrIHRoZSBETUEgY2hh bmdlcyBpbiB0aGUgUG93ZXJQQyB1cGRhdGVzIDQuMjEtMSBbMV0uIFRoZSAKPj4+PiBrZXJuZWwK Pj4+PiA0LjIwIHdvcmtzIHdpdGggYWxsIFBDSSBkZXZpY2VzIHdpdGhvdXQgbGltaXRhdGlvbiBv ZiBSQU0uCj4+PiBDYW4geW91IHNlbmQgbWUgdGhlIC5jb25maWcgYW5kIGEgZG1lc2c/wqAgQW5k IGluIHRoZSBtZWFudGltZSB0cnkgdGhlCj4+PiBwYXRjaCBiZWxvdz8KPj4+Cj4+PiAtLS0KPj4+ ID5Gcm9tIDRkNjU5YjczMTFiZDQxNDFmZGQzZWVlYjgwZmEyZDc2MDJlYTAxZDQgTW9uIFNlcCAx NyAwMDowMDowMCAyMDAxCj4+PiBGcm9tOiBOaWNvbGFzIFNhZW56IEp1bGllbm5lIDxuc2Flbnpq dWxpZW5uZUBzdXNlLmRlPgo+Pj4gRGF0ZTogRnJpLCAxOCBPY3QgMjAxOSAxMzowMDo0MyArMDIw MAo+Pj4gU3ViamVjdDogZG1hLWRpcmVjdDogY2hlY2sgZm9yIG92ZXJmbG93cyBvbiAzMiBiaXQg RE1BIGFkZHJlc3Nlcwo+Pj4KPj4+IEFzIHNlZW4gb24gdGhlIG5ldyBSYXNwYmVycnkgUGkgNCBh bmQgc3RhMngxMSdzIERNQSBpbXBsZW1lbnRhdGlvbiAKPj4+IGl0IGlzCj4+PiBwb3NzaWJsZSBm b3IgYSBkZXZpY2UgY29uZmlndXJlZCB3aXRoIDMyIGJpdCBETUEgYWRkcmVzc2VzIGFuZCBhIAo+ Pj4gcGFydGlhbAo+Pj4gRE1BIG1hcHBpbmcgbG9jYXRlZCBhdCB0aGUgZW5kIG9mIHRoZSBhZGRy ZXNzIHNwYWNlIHRvIG92ZXJmbG93LiBJdAo+Pj4gaGFwcGVucyB3aGVuIGEgaGlnaGVyIHBoeXNp Y2FsIGFkZHJlc3MsIG5vdCBETUFhYmxlLCBpcyB0cmFuc2xhdGVkIHRvCj4+PiBpdCdzIERNQSBj b3VudGVycGFydC4KPj4+Cj4+PiBGb3IgZXhhbXBsZSB0aGUgUmFzcGJlcnJ5IFBpIDQsIGNvbmZp Z3VyYWJsZSB1cCB0byA0IEdCIG9mIG1lbW9yeSwgaGFzCj4+PiBhbiBpbnRlcmNvbm5lY3QgY2Fw YWJsZSBvZiBhZGRyZXNzaW5nIHRoZSBsb3dlciAxIEdCIG9mIHBoeXNpY2FsIG1lbW9yeQo+Pj4g d2l0aCBhIERNQSBvZmZzZXQgb2YgMHhjMDAwMDAwMC4gSXQgdHJhbnNwaXJlcyB0aGF0LCBhbnkg YXR0ZW1wdCB0bwo+Pj4gdHJhbnNsYXRlIHBoeXNpY2FsIGFkZHJlc3NlcyBoaWdoZXIgdGhhbiB0 aGUgZmlyc3QgR0Igd2lsbCByZXN1bHQgaW4gYW4KPj4+IG92ZXJmbG93IHdoaWNoIGRtYV9jYXBh YmxlKCkgY2FuJ3QgZGV0ZWN0IGFzIGl0IG9ubHkgY2hlY2tzIGZvcgo+Pj4gYWRkcmVzc2VzIGJp Z2dlciB0aGVuIHRoZSBtYXhpbXVtIGFsbG93ZWQgRE1BIGFkZHJlc3MuCj4+Pgo+Pj4gRml4IHRo aXMgYnkgdmVyaWZ5aW5nIGluIGRtYV9jYXBhYmxlKCkgaWYgdGhlIERNQSBhZGRyZXNzIHJhbmdl IAo+Pj4gcHJvdmlkZWQKPj4+IGlzIGF0IGFueSBwb2ludCBsb3dlciB0aGFuIHRoZSBtaW5pbXVt IHBvc3NpYmxlIERNQSBhZGRyZXNzIG9uIHRoZSBidXMuCj4+Pgo+Pj4gU2lnbmVkLW9mZi1ieTog Tmljb2xhcyBTYWVueiBKdWxpZW5uZSA8bnNhZW56anVsaWVubmVAc3VzZS5kZT4KPj4+IC0tLQo+ Pj4gwqAgaW5jbHVkZS9saW51eC9kbWEtZGlyZWN0LmggfCA4ICsrKysrKysrCj4+PiDCoCAxIGZp bGUgY2hhbmdlZCwgOCBpbnNlcnRpb25zKCspCj4+Pgo+Pj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUv bGludXgvZG1hLWRpcmVjdC5oIGIvaW5jbHVkZS9saW51eC9kbWEtZGlyZWN0LmgKPj4+IGluZGV4 IGFkZjk5M2EzYmQ1OC4uNmFkOWU5ZWE3NTY0IDEwMDY0NAo+Pj4gLS0tIGEvaW5jbHVkZS9saW51 eC9kbWEtZGlyZWN0LmgKPj4+ICsrKyBiL2luY2x1ZGUvbGludXgvZG1hLWRpcmVjdC5oCj4+PiBA QCAtMyw2ICszLDcgQEAKPj4+IMKgICNkZWZpbmUgX0xJTlVYX0RNQV9ESVJFQ1RfSCAxCj4+PiDC oCDCoCAjaW5jbHVkZSA8bGludXgvZG1hLW1hcHBpbmcuaD4KPj4+ICsjaW5jbHVkZSA8bGludXgv bWVtYmxvY2suaD4gLyogZm9yIG1pbl9sb3dfcGZuICovCj4+PiDCoCAjaW5jbHVkZSA8bGludXgv bWVtX2VuY3J5cHQuaD4KPj4+IMKgIMKgICNpZmRlZiBDT05GSUdfQVJDSF9IQVNfUEhZU19UT19E TUEKPj4+IEBAIC0yNyw2ICsyOCwxMyBAQCBzdGF0aWMgaW5saW5lIGJvb2wgZG1hX2NhcGFibGUo c3RydWN0IGRldmljZSAKPj4+ICpkZXYsIGRtYV9hZGRyX3QgYWRkciwgc2l6ZV90IHNpemUpCj4+ PiDCoMKgwqDCoMKgIGlmICghZGV2LT5kbWFfbWFzaykKPj4+IMKgwqDCoMKgwqDCoMKgwqDCoCBy ZXR1cm4gZmFsc2U7Cj4+PiDCoCArI2lmbmRlZiBDT05GSUdfQVJDSF9ETUFfQUREUl9UXzY0QklU Cj4+PiArwqDCoMKgIC8qIENoZWNrIGlmIERNQSBhZGRyZXNzIG92ZXJmbG93ZWQgKi8KPj4+ICvC oMKgwqAgaWYgKG1pbihhZGRyLCBhZGRyICsgc2l6ZSAtIDEpIDwKPj4+ICvCoMKgwqDCoMKgwqDC oCBfX3BoeXNfdG9fZG1hKGRldiwgKHBoeXNfYWRkcl90KShtaW5fbG93X3BmbiA8PCBQQUdFX1NI SUZUKSkpCj4+PiArwqDCoMKgwqDCoMKgwqAgcmV0dXJuIGZhbHNlOwo+Pj4gKyNlbmRpZgo+Pj4g Kwo+Pj4gwqDCoMKgwqDCoCByZXR1cm4gYWRkciArIHNpemUgLSAxIDw9Cj4+PiDCoMKgwqDCoMKg wqDCoMKgwqAgbWluX25vdF96ZXJvKCpkZXYtPmRtYV9tYXNrLCBkZXYtPmJ1c19kbWFfbWFzayk7 Cj4+PiDCoCB9Cj4+IEhlbGxvIENocmlzdG9waCwKPj4KPj4gVGhhbmtzIGEgbG90IGZvciB5b3Vy IHBhdGNoISBVbmZvcnR1bmF0ZWx5IHRoaXMgcGF0Y2ggZG9lc24ndCBzb2x2ZSAKPj4gdGhlIGlz c3VlLgo+Pgo+PiBFcnJvciBtZXNzYWdlczoKPj4KPj4gW8KgwqDCoCA2LjA0MTE2M10gYnR0djog ZHJpdmVyIHZlcnNpb24gMC45LjE5IGxvYWRlZAo+PiBbwqDCoMKgIDYuMDQxMTY3XSBidHR2OiB1 c2luZyA4IGJ1ZmZlcnMgd2l0aCAyMDgwayAoNTIwIHBhZ2VzKSBlYWNoIGZvciAKPj4gY2FwdHVy ZQo+PiBbwqDCoMKgIDYuMDQxNTU5XSBidHR2OiBCdDh4eCBjYXJkIGZvdW5kICgwKQo+PiBbwqDC oMKgIDYuMDQxNjA5XSBidHR2OiAwOiBCdDg3OCAocmV2IDE3KSBhdCAxMDAwOjA0OjA1LjAsIGly cTogMTksIAo+PiBsYXRlbmN5OiAxMjgsIG1taW86IDB4YzIwMDAxMDAwCj4+IFvCoMKgwqAgNi4w NDE2MjJdIGJ0dHY6IDA6IHVzaW5nOiBUeXBob29uIFRWaWV3IFJEUyArIEZNIFN0ZXJlbyAvIEtO QzEgCj4+IFRWIFN0YXRpb24gUkRTIFtjYXJkPTUzLGluc21vZCBvcHRpb25dCj4+IFvCoMKgwqAg Ni4wNDIyMTZdIGJ0dHY6IDA6IHR1bmVyIHR5cGU9NQo+PiBbwqDCoMKgIDYuMTExOTk0XSBidHR2 OiAwOiBhdWRpbyBhYnNlbnQsIG5vIGF1ZGlvIGRldmljZSBmb3VuZCEKPj4gW8KgwqDCoCA2LjE3 NjQyNV0gYnR0djogMDogU2V0dGluZyBQTEw6IDI4NjM2MzYzID0+IDM1NDY4OTUwIChuZWVkcyB1 cCAKPj4gdG8gMTAwbXMpCj4+IFvCoMKgwqAgNi4yMDAwMDVdIGJ0dHY6IFBMTCBzZXQgb2sKPj4g W8KgwqDCoCA2LjIwOTM1MV0gYnR0djogMDogcmVnaXN0ZXJlZCBkZXZpY2UgdmlkZW8wCj4+IFvC oMKgwqAgNi4yMTE1NzZdIGJ0dHY6IDA6IHJlZ2lzdGVyZWQgZGV2aWNlIHZiaTAKPj4gW8KgwqDC oCA2LjIxNDg5N10gYnR0djogMDogcmVnaXN0ZXJlZCBkZXZpY2UgcmFkaW8wCj4+IFvCoCAxMTQu MjE4ODA2XSBidHR2IDEwMDA6MDQ6MDUuMDogb3ZlcmZsb3cgMHgwMDAwMDAwMGZmNTA3MDAwKzQw OTYgb2YgCj4+IERNQSBtYXNrIGZmZmZmZmZmIGJ1cyBtYXNrIGRmMDAwMDAwCj4+IFvCoCAxMTQu MjE4ODQ4XSBNb2R1bGVzIGxpbmtlZCBpbjogcmZjb21tIGJuZXAgdHVuZXJfc2ltcGxlIAo+PiB0 dW5lcl90eXBlcyB0ZWE1NzY3IHR1bmVyIHRkYTc0MzIgdHZhdWRpbyBtc3AzNDAwIGJ0dHYgdGVh NTc1eCAKPj4gdHZlZXByb20gdmlkZW9idWZfZG1hX3NnIHZpZGVvYnVmX2NvcmUgcmNfY29yZSB2 aWRlb2RldiBtYyBidHVzYiAKPj4gYnRydGwgYnRiY20gYnRpbnRlbCBibHVldG9vdGggdWlvX3Bk cnZfZ2VuaXJxIHVpbyBlY2RoX2dlbmVyaWMgZWNjCj4+IFvCoCAxMTQuMjE5MDEyXSBbYzAwMDAw MDFlY2RkZjcyMF0gWzgwMDAwMDAwMDA4ZmY2ZThdIAo+PiAuYnVmZmVyX3ByZXBhcmUrMHgxNTAv MHgyNjggW2J0dHZdCj4+IFvCoCAxMTQuMjE5MDI5XSBbYzAwMDAwMDFlY2RkZjg2MF0gWzgwMDAw MDAwMDA4ZmZmNmNdIAo+PiAuYnR0dl9xYnVmKzB4NTAvMHg2NCBbYnR0dl0KPj4KPj4gLS0tLS0K Pj4KPj4gVHJhY2U6Cj4+Cj4+IFvCoCA0NjIuNzgzMTg0XSBDYWxsIFRyYWNlOgo+PiBbwqAgNDYy Ljc4MzE4N10gW2MwMDAwMDAxYzZjNjc0MjBdIFtjMDAwMDAwMDAwMGIzMzU4XSAKPj4gLnJlcG9y dF9hZGRyKzB4YjgvMHhjMCAodW5yZWxpYWJsZSkKPj4gW8KgIDQ2Mi43ODMxOTJdIFtjMDAwMDAw MWM2YzY3NDkwXSBbYzAwMDAwMDAwMDBiMzUxY10gCj4+IC5kbWFfZGlyZWN0X21hcF9wYWdlKzB4 ZjAvMHgxMjgKPj4gW8KgIDQ2Mi43ODMxOTVdIFtjMDAwMDAwMWM2YzY3NTMwXSBbYzAwMDAwMDAw MDBiMzViMF0gCj4+IC5kbWFfZGlyZWN0X21hcF9zZysweDVjLzB4YWMKPj4gW8KgIDQ2Mi43ODMy MDVdIFtjMDAwMDAwMWM2YzY3NWUwXSBbODAwMDAwMDAwMDg2MmU4OF0gCj4+IC5fX3ZpZGVvYnVm X2lvbG9jaysweDY2MC8weDZkOCBbdmlkZW9idWZfZG1hX3NnXQo+PiBbwqAgNDYyLjc4MzIyMF0g W2MwMDAwMDAxYzZjNjc2YjBdIFs4MDAwMDAwMDAwODU0Mjc0XSAKPj4gLnZpZGVvYnVmX2lvbG9j aysweDk4LzB4YjQgW3ZpZGVvYnVmX2NvcmVdCj4+IFvCoCA0NjIuNzgzMjcxXSBbYzAwMDAwMDFj NmM2NzcyMF0gWzgwMDAwMDAwMDA4Njg2ZThdIAo+PiAuYnVmZmVyX3ByZXBhcmUrMHgxNTAvMHgy NjggW2J0dHZdCj4+IFvCoCA0NjIuNzgzMjc2XSBbYzAwMDAwMDFjNmM2NzdjMF0gWzgwMDAwMDAw MDA4NTRhZmNdIAo+PiAudmlkZW9idWZfcWJ1ZisweDJiOC8weDQyOCBbdmlkZW9idWZfY29yZV0K Pj4gW8KgIDQ2Mi43ODMyODhdIFtjMDAwMDAwMWM2YzY3ODYwXSBbODAwMDAwMDAwMDg2OGY2Y10g Cj4+IC5idHR2X3FidWYrMHg1MC8weDY0IFtidHR2XQo+PiBbwqAgNDYyLjc4MzM4M10gW2MwMDAw MDAxYzZjNjc4ZTBdIFs4MDAwMDAwMDAwN2JmMjA4XSAKPj4gLnY0bF9xYnVmKzB4NTQvMHg2MCBb dmlkZW9kZXZdCj4+IFvCoCA0NjIuNzgzNDAyXSBbYzAwMDAwMDFjNmM2Nzk3MF0gWzgwMDAwMDAw MDA3YzFlYWNdIAo+PiAuX192aWRlb19kb19pb2N0bCsweDMwYy8weDNmOCBbdmlkZW9kZXZdCj4+ IFvCoCA0NjIuNzgzNDIxXSBbYzAwMDAwMDFjNmM2N2E4MF0gWzgwMDAwMDAwMDA3YzNjMDhdIAo+ PiAudmlkZW9fdXNlcmNvcHkrMHgxOGMvMHgzZGMgW3ZpZGVvZGV2XQo+PiBbwqAgNDYyLjc4MzQ0 MF0gW2MwMDAwMDAxYzZjNjdjMDBdIFs4MDAwMDAwMDAwN2JiMTRjXSAKPj4gLnY0bDJfaW9jdGwr MHg2MC8weDc4IFt2aWRlb2Rldl0KPj4gW8KgIDQ2Mi43ODM0NjBdIFtjMDAwMDAwMWM2YzY3Yzkw XSBbODAwMDAwMDAwMDdkM2M0OF0gCj4+IC52NGwyX2NvbXBhdF9pb2N0bDMyKzB4OWI0LzB4MTg1 MCBbdmlkZW9kZXZdCj4+IFvCoCA0NjIuNzgzNDY4XSBbYzAwMDAwMDFjNmM2N2Q3MF0gW2MwMDAw MDAwMDAxYWQ5Y2NdIAo+PiAuX19zZV9jb21wYXRfc3lzX2lvY3RsKzB4Mjg0LzB4MTI3Ywo+PiBb wqAgNDYyLjc4MzQ3M10gW2MwMDAwMDAxYzZjNjdlMjBdIFtjMDAwMDAwMDAwMDAwNjdjXSAKPj4g c3lzdGVtX2NhbGwrMHg2MC8weDZjCj4+IFvCoCA0NjIuNzgzNDc1XSBJbnN0cnVjdGlvbiBkdW1w Ogo+PiBbwqAgNDYyLjc4MzQ3N10gNDBmZTAwNDQgNjAwMDAwMDAgODkyMjU1ZDAgMmY4OTAwMDAg NDBmZTAwMjAgM2M4MmZmYzUgCj4+IDM5MjAwMDAxIDYwMDAwMDAwCj4+IFvCoCA0NjIuNzgzNDgz XSAzODg0MjAyOSA5OTIyNTVkMCA0ODVhZDBkOSA2MDAwMDAwMCA8MGZlMDAwMDA+IAo+PiAzODIx MDA3MCBlODAxMDAxMCA3YzA4MDNhNgo+PiBbwqAgNDYyLjc4MzQ5MF0gLS0tWyBlbmQgdHJhY2Ug YjY3N2Q0YTAwNDU4ZTI3NyBdLS0tCj4+Cj4+IC0tLS0tCj4+Cj4+IGRtZXNnIGZzbCBwNTA0MDog aHR0cHM6Ly9idWd6aWxsYS5rZXJuZWwub3JnL2F0dGFjaG1lbnQuY2dpP2lkPTI4NTgxMwo+Pgo+ PiBLZXJuZWwgNS40LXJjNiBjb25maWcgZm9yIHRoZSBDeXJ1cysgYm9hcmQgYW5kIGZvciB0aGUg UUVNVSBwcGNlNTAwIAo+PiBib2FyZCAoQ1BVOiBQNTA0MCBhbmQgUDUwMjApOiAKPj4gaHR0cHM6 Ly9idWd6aWxsYS5rZXJuZWwub3JnL2F0dGFjaG1lbnQuY2dpP2lkPTI4NTgxNQo+Pgo+PiBCdWcg cmVwb3J0OiBodHRwczovL2J1Z3ppbGxhLmtlcm5lbC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNTIw MQo+Pgo+PiBUaGFua3MgZm9yIHlvdXIgaGVscCwKPj4KPj4gQ2hyaXN0aWFuCj4KPiBDaHJpc3Rv cGgsCj4KPiBEbyB5b3UgaGF2ZSBhbm90aGVyIHBhdGNoIGZvciB0ZXN0aW5nIG9yIHNoYWxsIEkg YmlzZWN0Pwo+Cj4gVGhhbmtzLAo+IENocmlzdGlhbgoKSGkgQ2hyaXN0b3BoLAoKSSBoYXZlIHNl ZW4gdGhhdCBJIGhhdmUgYWN0aXZhdGVkIHRoZSBrZXJuZWwgY29uZmlnIG9wdGlvbiAKQ09ORklH X0FSQ0hfRE1BX0FERFJfVF82NEJJVC4gVGhhdCBtZWFucyB5b3VyIGNvZGUgaW4geW91ciBwYXRj aCB3b24ndCAKd29yayBpZiB0aGlzIGtlcm5lbCBvcHRpb24gaXMgZW5hYmxlZC4KCisjaWZuZGVm IENPTkZJR19BUkNIX0RNQV9BRERSX1RfNjRCSVQKK8KgwqDCoCAvKiBDaGVjayBpZiBETUEgYWRk cmVzcyBvdmVyZmxvd2VkICovCivCoMKgwqAgaWYgKG1pbihhZGRyLCBhZGRyICsgc2l6ZSAtIDEp IDwKK8KgwqDCoMKgwqDCoMKgIF9fcGh5c190b19kbWEoZGV2LCAocGh5c19hZGRyX3QpKG1pbl9s b3dfcGZuIDw8IFBBR0VfU0hJRlQpKSkKK8KgwqDCoMKgwqDCoMKgIHJldHVybiBmYWxzZTsKKyNl bmRpZgoKSSB3aWxsIGRlbGV0ZSB0aGUgbGluZXMgd2l0aCBpZm5kZWYgYW5kIGVuZGlmIGFuZCB3 aWxsIHRyeSBpdCBhZ2Fpbi4KCkNoZWVycywKQ2hyaXN0aWFuCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmlvbW11IG1haWxpbmcgbGlzdAppb21tdUBsaXN0 cy5saW51eC1mb3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3RzLmxpbnV4Zm91bmRhdGlvbi5vcmcv bWFpbG1hbi9saXN0aW5mby9pb21tdQ==