From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 347D7C433EF for ; Mon, 20 Sep 2021 15:20:09 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D9ECB610F9 for ; Mon, 20 Sep 2021 15:20:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D9ECB610F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:56660 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSL5U-0002fm-3a for qemu-devel@archiver.kernel.org; Mon, 20 Sep 2021 11:20:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44418) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSKh5-00086h-DT for qemu-devel@nongnu.org; Mon, 20 Sep 2021 10:54:55 -0400 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]:45896) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mSKh2-0004FO-RZ for qemu-devel@nongnu.org; Mon, 20 Sep 2021 10:54:55 -0400 Received: by mail-pj1-x1031.google.com with SMTP id mv7-20020a17090b198700b0019c843e7233so144793pjb.4 for ; Mon, 20 Sep 2021 07:54:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=dHjjHUGCsuyxTXVnN10py8RUGOL8/zZ7UoA9n+O4IKs=; b=GloKLUuwLsTpUjr2V/95NA86QQGRTxKr7nQo2bTBrToOXZmPr1Qy83nOQ3g+EJ31za dnL85+vIIG8PyhIEdMvMhKmazatDeQeYxMqpwMCyEQCx0CnTnh02CtwUVdDu3H9jbE1d gUKRD8I8mAmcqcRouVsII0ipKCM5jzxQCMkHQ5djyTJRPX9isOtlPbXxyyIy6cMhkfS1 DM1XKCVJMbpCV2a3V+jGYu34m9M6hGEXpwtcHo75IX7UyhQbOztuE+Ma0Dc/HaJSxjYY 9R6V3r9iNYA0MsgKH2xF0ezZAeIcL931lcSmCJ6JG+6I16/kxbqrR2OOb3rXBt2jmRpG YUZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=dHjjHUGCsuyxTXVnN10py8RUGOL8/zZ7UoA9n+O4IKs=; b=tAqPuon+nTtwEIwa+o0JNimUvFAINnHRF+C/RHjFpBfQzCNKqXGh0mLcms3BNLRHfc eDOx/V29c8xKjECdPqPY4nLB+yVeP7FELxjhFdcIRhknBaEc+/OfNapjEtQi2oqrLcGR SipMZqMw0IngPpCmadqspOiyHLKH5QK47cc7meygkWFsC+D0ubjWc1I3vZd8KRmPFYlO //Bh0ZSTP5UbCn/xqIxi9Xjn23LLN/IuzZ5gkwscri2kOnTXvzh6QdMxVazF3gSfOor8 Gsg18SaOPJ+855H+D/nHeR9vSJvthybxVyDLRLQoolGAM9OwYbqbb8K4EWOAjIF/nZHG +qQw== X-Gm-Message-State: AOAM532AtKBr9kNHvTM5cPmf96bj0nSjcWwaz/9m4ZrA7cq0Vc4vTUz3 emNDoy6IqCKKA5tOdLaIzvx/QeM09spXOQ== X-Google-Smtp-Source: ABdhPJxvwfBESTHhpd4YWnVQDUoxfQSCpNmb0LgbmGYRDPfOn2wPiWw6G8U3UzBGmn+9W6MVfI6vGQ== X-Received: by 2002:a17:90b:38cc:: with SMTP id nn12mr4144286pjb.108.1632149689622; Mon, 20 Sep 2021 07:54:49 -0700 (PDT) Received: from [192.168.1.11] ([71.212.134.125]) by smtp.gmail.com with ESMTPSA id e13sm10445452pfn.212.2021.09.20.07.54.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Sep 2021 07:54:49 -0700 (PDT) Subject: Re: [PATCH 12/30] tcg/loongarch: Implement not/and/or/xor/nor/andc/orc ops To: WANG Xuerui , qemu-devel@nongnu.org References: <20210920080451.408655-1-git@xen0n.name> <20210920080451.408655-13-git@xen0n.name> From: Richard Henderson Message-ID: Date: Mon, 20 Sep 2021 07:54:47 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210920080451.408655-13-git@xen0n.name> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::1031; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1031.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/20/21 1:04 AM, WANG Xuerui wrote: > + case INDEX_op_andc_i32: > + case INDEX_op_andc_i64: > + tcg_out_opc_andn(s, a0, a1, a2); > + break; You may want to add the constant case here, implemented with andi, with the constant inverted, similarly to the negation of the N constraint. We do not (but probably should) canonicalize andc/orc/eqv constants to and/or/xor during optimization... Reviewed-by: Richard Henderson r~