From: Edward Cree <ecree@solarflare.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>,
Paul Chaignon <paul.chaignon@orange.com>,
Alexei Starovoitov <ast@kernel.org>, <netdev@vger.kernel.org>,
<bpf@vger.kernel.org>, Xiao Han <xiao.han@orange.com>,
<paul.chaignon@gmail.com>, Martin KaFai Lau <kafai@fb.com>,
Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>
Subject: Re: [PATCH bpf] bpf: report verifier bugs as warnings
Date: Wed, 3 Apr 2019 21:24:24 +0100 [thread overview]
Message-ID: <af569c49-7131-dd06-bd2e-df100a11d4f9@solarflare.com> (raw)
In-Reply-To: <20190403173029.lfwhblklss62yone@ast-mbp.dhcp.thefacebook.com>
On 03/04/2019 18:30, Alexei Starovoitov wrote:
> verbose_and_warn() doesn't fit these two practical cases of warn + verbose.
> Hence I see no reason to combine warn and verbose into single helper.
> They're perfectly fine being separate.
Makes sense.
So presumably the right patch would be to add more appropriate (concise
and less context-dependent) WARN messages alongside the verbose()s that
Paul's patch changed?
next prev parent reply other threads:[~2019-04-03 20:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-02 11:58 [PATCH bpf] bpf: report verifier bugs as warnings Paul Chaignon
2019-04-02 14:37 ` Daniel Borkmann
2019-04-02 17:39 ` Alexei Starovoitov
2019-04-03 14:40 ` Paul Chaignon
2019-04-03 15:52 ` Edward Cree
2019-04-03 17:30 ` Alexei Starovoitov
2019-04-03 20:24 ` Edward Cree [this message]
2019-04-03 22:41 ` Daniel Borkmann
2019-04-04 17:45 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af569c49-7131-dd06-bd2e-df100a11d4f9@solarflare.com \
--to=ecree@solarflare.com \
--cc=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kafai@fb.com \
--cc=netdev@vger.kernel.org \
--cc=paul.chaignon@gmail.com \
--cc=paul.chaignon@orange.com \
--cc=songliubraving@fb.com \
--cc=xiao.han@orange.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.