All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jonas Dreßler" <verdre@v0yd.nl>
To: Dominique MARTINET <dominique.martinet@atmark-techno.com>,
	Sharvari Harisangam <sharvari.harisangam@nxp.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	Amitkumar Karwar <amitkarwar@gmail.com>,
	Takashi Iwai <tiwai@suse.de>, Tsuchiya Yuto <kitakar@gmail.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Arnd Bergmann <arnd@arndb.de>, Lee Jones <lee.jones@linaro.org>,
	Kalle Valo <kvalo@codeaurora.org>,
	Xinming Hu <huxinming820@gmail.com>,
	Ganapathi Bhat <ganapathi017@gmail.com>
Subject: Re: [EXT] Re: mwifiex cmd timeout on one pci variant
Date: Tue, 14 Sep 2021 12:11:46 +0200	[thread overview]
Message-ID: <af5cff45-da9d-26b7-fd00-c4e91344cfc1@v0yd.nl> (raw)
In-Reply-To: <YThQiMn7YHzPRwnJ@atmark-techno.com>

Hi Dominique,

regarding the firmware version, as you can see in the commit updating 
the firmware binaries 
(https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/commit/mrvl/pcie8897_uapsta.bin?id=1a5773c0c89ee44cee51a285d5c7c1063cdb0891), 
indeed the version numbering differs between the different versions of 
the card (usb/usb, pcie/usb, pcie/uart(?)).

Anyway, if you manage to find newer firmware for any of those versions, 
I'd be happy if you could point me to that, apparently they just fixed a 
critical vulnerability in the Windows firmware again (see 
https://support.microsoft.com/en-us/surface/surface-pro-5th-gen-update-history-5203144a-90c1-63df-ce0b-7ec7ff32ff10), 
I wouldn't be surprised if our firmware is also affected by that.

About the command timeout, I have no idea why the fix isn't working for 
you, but well, my analysis of the issue is also just a (not exactly 
educated) guess, so it might as well be a completely different problem 
and my fix is just a lucky hack.

I'd kinda hope though that my proposed patches finally wake up some 
people at NXP and motivate them to take a look at that firmware repo again.

Jonas

On 9/8/21 7:56 AM, Dominique MARTINET wrote:
> Sharvari Harisangam wrote on Wed, Sep 08, 2021 at 05:45:53AM +0000:
>> Use firmware from https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/mrvl
>> for mwifiex driver.
> 
> Thanks, that's the first firmware I was using; it's currently at
> 16.68.1.p179 which is why I'm surprised Jonas said the latest would be
> 15.68.19.p21.
> 
> I think it's just a different variant of the driver now though,
> a binary grep matches 15.68.19.p21 for pcie8897_uapsta.bin but I my
> driver loads pcieuart8997_combo_v4.bin
> I hadn't noticed the first number didn't match, but that likely confirms
> it.
> 
> Sorry for the noise on firmware version, I'm still interested in
> understanding why the command timeouts.
> 


  reply	other threads:[~2021-09-14 10:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-08  4:43 mwifiex cmd timeout on one pci variant Dominique MARTINET
2021-09-08  5:36 ` Dominique MARTINET
2021-09-08  5:45   ` [EXT] " Sharvari Harisangam
2021-09-08  5:56     ` Dominique MARTINET
2021-09-14 10:11       ` Jonas Dreßler [this message]
2021-09-15  1:43         ` Dominique MARTINET
2021-09-15 10:06           ` Jonas Dreßler
2021-09-08 16:56 ` Brian Norris
2021-09-08 23:48   ` Dominique MARTINET

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af5cff45-da9d-26b7-fd00-c4e91344cfc1@v0yd.nl \
    --to=verdre@v0yd.nl \
    --cc=amitkarwar@gmail.com \
    --cc=arnd@arndb.de \
    --cc=dominique.martinet@atmark-techno.com \
    --cc=ganapathi017@gmail.com \
    --cc=geert+renesas@glider.be \
    --cc=huxinming820@gmail.com \
    --cc=kitakar@gmail.com \
    --cc=kvalo@codeaurora.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=sharvari.harisangam@nxp.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.