All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Alexander Kochetkov <al.kochet@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Philippe Reynes <tremyfr@gmail.com>,
	Peter Chen <peter.chen@nxp.com>,
	Wei Yongjun <weiyongjun1@huawei.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: arc_emac: switch to phy_start()/phy_stop()
Date: Wed, 19 Apr 2017 21:22:26 +0300	[thread overview]
Message-ID: <af660812-20f9-76fc-ee04-38a6714faabe@cogentembedded.com> (raw)
In-Reply-To: <1492612195-16601-1-git-send-email-al.kochet@gmail.com>

On 04/19/2017 05:29 PM, Alexander Kochetkov wrote:

> The patch replace phy_start_aneg() with phy_start(). phy_start() call

    Replaces.

> phy_start_aneg() as a part of startup sequence and allow recover from
> error (PHY_HALTED) state.
>
> Also added call phy_stop() to arc_emac_remove() to stop PHY state machine

    To arc_emac_stop() maybe?

> when MAC is down.

> Signed-off-by: Alexander Kochetkov <al.kochet@gmail.com>
> ---
>  drivers/net/ethernet/arc/emac_main.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/arc/emac_main.c b/drivers/net/ethernet/arc/emac_main.c
> index abc9f2a..188676d 100644
> --- a/drivers/net/ethernet/arc/emac_main.c
> +++ b/drivers/net/ethernet/arc/emac_main.c
[...]
> @@ -556,6 +556,8 @@ static int arc_emac_stop(struct net_device *ndev)
>  	napi_disable(&priv->napi);
>  	netif_stop_queue(ndev);
>
> +	phy_stop(ndev->phydev);
> +
>  	/* Disable interrupts */
>  	arc_reg_clr(priv, R_ENABLE, RXINT_MASK | TXINT_MASK | ERR_MASK);
>

MBR, Sergei

  reply	other threads:[~2017-04-19 18:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-19 14:29 [PATCH] net: arc_emac: switch to phy_start()/phy_stop() Alexander Kochetkov
2017-04-19 18:22 ` Sergei Shtylyov [this message]
2017-04-19 21:08 ` Florian Fainelli
2017-04-19 21:19   ` Alexander Kochetkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af660812-20f9-76fc-ee04-38a6714faabe@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=al.kochet@gmail.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=peter.chen@nxp.com \
    --cc=tremyfr@gmail.com \
    --cc=weiyongjun1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.