From: Jens Axboe <axboe@kernel.dk>
To: Jeff Layton <jlayton@kernel.org>
Cc: linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
willy@infradead.org, darrick.wong@oracle.com, tytso@mit.edu,
bfoster@redhat.com
Subject: Re: [PATCH RESEND] loop: clear wb_err in bd_inode when detaching backing file
Date: Mon, 21 May 2018 12:36:59 -0600 [thread overview]
Message-ID: <af70acb0-b636-b6a8-feca-a575c8e7c317@kernel.dk> (raw)
In-Reply-To: <20180521183503.6029-1-jlayton@kernel.org>
On 5/21/18 12:35 PM, Jeff Layton wrote:
> From: Jeff Layton <jlayton@redhat.com>
>
> When a loop block device encounters a writeback error, that error will
> get propagated to the bd_inode's wb_err field. If we then detach the
> backing file from it, attach another and fsync it, we'll get back the
> writeback error that we had from the previous backing file.
>
> This is a bit of a grey area as POSIX doesn't cover loop devices, but it
> is somewhat counterintuitive.
>
> If we detach a backing file from the loopdev while there are still
> unreported errors, take it as a sign that we're no longer interested in
> the previous file, and clear out the wb_err in the loop blockdev.
Applied, thanks Jeff.
--
Jens Axboe
prev parent reply other threads:[~2018-05-21 18:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-21 18:35 [PATCH RESEND] loop: clear wb_err in bd_inode when detaching backing file Jeff Layton
2018-05-21 18:36 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af70acb0-b636-b6a8-feca-a575c8e7c317@kernel.dk \
--to=axboe@kernel.dk \
--cc=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=jlayton@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.