From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50040) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fzixY-0006MT-8Y for qemu-devel@nongnu.org; Tue, 11 Sep 2018 09:44:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fzixX-0008Uw-Ft for qemu-devel@nongnu.org; Tue, 11 Sep 2018 09:44:04 -0400 References: <20180907121319.8607-1-marcandre.lureau@redhat.com> <20180907121319.8607-2-marcandre.lureau@redhat.com> <0ac178fc-b237-2263-b32f-cd5bf91cea2b@redhat.com> From: Paolo Bonzini Message-ID: Date: Tue, 11 Sep 2018 15:43:48 +0200 MIME-Version: 1.0 In-Reply-To: <0ac178fc-b237-2263-b32f-cd5bf91cea2b@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 1/3] util: add qemu_write_pidfile() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , qemu-devel@nongnu.org Cc: Fam Zheng , qemu-block@nongnu.org, Stefan Weil , Michael Roth On 07/09/2018 16:03, Eric Blake wrote: > On 09/07/2018 07:13 AM, Marc-Andr=C3=A9 Lureau wrote: >> There are variants of qemu_create_pidfile() in qemu-pr-helper and >> qemu-ga. Let's have a common implementation in libqemuutil. >> >=20 > Unrelated to this patch, but a question that this raises: should > 'qemu-nbd' also have a mode for creating a pid file, since it has --for= k > for daemonizing the server process? Yes, it's probably a good idea. --fork mode is used mostly with -c/-d, but why not. Paolo