From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62C0CC4332B for ; Wed, 17 Mar 2021 14:03:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0C2FF64F70 for ; Wed, 17 Mar 2021 14:03:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231675AbhCQODE (ORCPT ); Wed, 17 Mar 2021 10:03:04 -0400 Received: from mga04.intel.com ([192.55.52.120]:12268 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231582AbhCQOCs (ORCPT ); Wed, 17 Mar 2021 10:02:48 -0400 IronPort-SDR: cgRl2aDde4l/YrCh/UsJbHhtpNq6DwKuyAh96RV1vmLF5lu/E3e68WA8x3uvlrvgXuCoGvLp0N h1pNFLUNP4Zw== X-IronPort-AV: E=McAfee;i="6000,8403,9925"; a="187096014" X-IronPort-AV: E=Sophos;i="5.81,256,1610438400"; d="scan'208";a="187096014" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2021 07:02:48 -0700 IronPort-SDR: N26sReSqZARVAAYucfXKIl+FzwROYWD5HOSN4dBKbUvNS7aoqPXtAGsWFOK8O+f/H1fC3k/Ph6 lzWlaho3z2rA== X-IronPort-AV: E=Sophos;i="5.81,256,1610438400"; d="scan'208";a="379296513" Received: from trentod-mobl.amr.corp.intel.com (HELO [10.212.29.205]) ([10.212.29.205]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2021 07:02:44 -0700 Subject: Re: [PATCH v3] ASoC: Intel: sof_rt5682: Add ALC1015Q-VB speaker amp support To: Brent Lu , alsa-devel@alsa-project.org, Jack Yu Cc: Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Jie Yang , Kai Vehmanen , Guennadi Liakhovetski , Rander Wang , Yong Zhi , Libin Yang , Ranjani Sridharan , Sathyanarayana Nujella , Dharageswari R , Kuninori Morimoto , Fred Oh , Tzung-Bi Shih , linux-kernel@vger.kernel.org References: <20210317110824.20814-1-brent.lu@intel.com> From: Pierre-Louis Bossart Message-ID: Date: Wed, 17 Mar 2021 09:02:42 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210317110824.20814-1-brent.lu@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/17/21 6:08 AM, Brent Lu wrote: > This patch adds jsl_rt5682_rt1015p which supports the RT5682 headset > codec and ALC1015Q-VB speaker amplifier combination on JasperLake > platform. > > This driver also supports ALC1015Q-CG if running in auto-mode. > Following table shows the audio interface support of the two > amplifiers. > > | ALC1015Q-CG | ALC1015Q-VB > ===================================== > I2C | Yes | No > Auto-mode | 48K, 64fs | 16k, 32fs > | 48k, 32fs > | 48k, 64fs > > Signed-off-by: Brent Lu The code is looks fine, but Jack Yu added a separate patch that makes RTL1019 equivalent to RTL1015, so should this patch also handle the RTL1019 case? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 809C5C433DB for ; Wed, 17 Mar 2021 14:03:59 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6D5C764F67 for ; Wed, 17 Mar 2021 14:03:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6D5C764F67 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id DF8CC18A8; Wed, 17 Mar 2021 15:03:04 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz DF8CC18A8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1615989835; bh=ScA1sXwxDy/jOvbbgM+xIjZyxNiTmZ1kE67/gKzq2ec=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=hroxcErBhAS88hWCmsjQ/8oaSttz7AkSJ6WYcbMqoz+FCg89UfvlV582/KZSnIR7X XBdthu1w8Y7cPisrHhCv14cR228A3kvX8mZTWPPRewsGYYnsj9e0PZu/qYFqXJmeJU 4+pbxCyrj8U4ly7rLbhuEWLyKuAbftXiySpHs4hc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 6E7FEF8013F; Wed, 17 Mar 2021 15:03:04 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 5FC95F8021C; Wed, 17 Mar 2021 15:03:03 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 4005DF80148 for ; Wed, 17 Mar 2021 15:02:51 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 4005DF80148 IronPort-SDR: 8NyneM84H2WtXgXP2Rcr0Ig9WVbieF1jIlAIiIHCMCoz+wF0snSTiJm/R+0Nmr7DqFQjSE77Bb a115KRSl1uSw== X-IronPort-AV: E=McAfee;i="6000,8403,9925"; a="189513811" X-IronPort-AV: E=Sophos;i="5.81,256,1610438400"; d="scan'208";a="189513811" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2021 07:02:48 -0700 IronPort-SDR: N26sReSqZARVAAYucfXKIl+FzwROYWD5HOSN4dBKbUvNS7aoqPXtAGsWFOK8O+f/H1fC3k/Ph6 lzWlaho3z2rA== X-IronPort-AV: E=Sophos;i="5.81,256,1610438400"; d="scan'208";a="379296513" Received: from trentod-mobl.amr.corp.intel.com (HELO [10.212.29.205]) ([10.212.29.205]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2021 07:02:44 -0700 Subject: Re: [PATCH v3] ASoC: Intel: sof_rt5682: Add ALC1015Q-VB speaker amp support To: Brent Lu , alsa-devel@alsa-project.org, Jack Yu References: <20210317110824.20814-1-brent.lu@intel.com> From: Pierre-Louis Bossart Message-ID: Date: Wed, 17 Mar 2021 09:02:42 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210317110824.20814-1-brent.lu@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: Oder Chiou , Guennadi Liakhovetski , Cezary Rojewski , Dharageswari R , Sathyanarayana Nujella , Kai Vehmanen , linux-kernel@vger.kernel.org, Jie Yang , Takashi Iwai , Kuninori Morimoto , Liam Girdwood , Fred Oh , Tzung-Bi Shih , Mark Brown , Ranjani Sridharan , Libin Yang , Rander Wang , Yong Zhi X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 3/17/21 6:08 AM, Brent Lu wrote: > This patch adds jsl_rt5682_rt1015p which supports the RT5682 headset > codec and ALC1015Q-VB speaker amplifier combination on JasperLake > platform. > > This driver also supports ALC1015Q-CG if running in auto-mode. > Following table shows the audio interface support of the two > amplifiers. > > | ALC1015Q-CG | ALC1015Q-VB > ===================================== > I2C | Yes | No > Auto-mode | 48K, 64fs | 16k, 32fs > | 48k, 32fs > | 48k, 64fs > > Signed-off-by: Brent Lu The code is looks fine, but Jack Yu added a separate patch that makes RTL1019 equivalent to RTL1015, so should this patch also handle the RTL1019 case?