From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 00/13] cxgbe: add CXGBE VF PMD and updates
Date: Mon, 26 Mar 2018 21:51:56 +0100
Message-ID: <af9d1a4f-41fe-7fbf-9348-7a6d71d581cf@intel.com>
References: <cover.1520720053.git.rahul.lakkireddy@chelsio.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: kumaras@chelsio.com, nirranjan@chelsio.com, indranil@chelsio.com
To: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by dpdk.org (Postfix) with ESMTP id 328FF2BD3
 for <dev@dpdk.org>; Mon, 26 Mar 2018 22:51:59 +0200 (CEST)
In-Reply-To: <cover.1520720053.git.rahul.lakkireddy@chelsio.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 3/10/2018 10:48 PM, Rahul Lakkireddy wrote:
> Patches 1 - 9 add support for cxgbe VF driver.  Patches 10 - 12 fix
> bugs and convert license in cxgbe files to SPDX License Tag.  Patch
> 13 adds compile time option to keep outer vlan tag in Q-in-Q packet.
> 
> Patch 1 adds minimal cxgbe VF driver.

Can you please update driver documentation with new supported device?

> 
> Patch 2 adds firmware mailbox support for VF.
> 
> Patch 3 adds base functions to enable VF ports in subsequent patches.
> 
> Patch 4 adds cxgbe VF probe to initialize VF devices.
> 
> Patch 5 initializes SGE and queues for VF.
> 
> Patch 6 enables RSS for VF.
> 
> Patch 7 updates TX and RX path for VF.
> 
> Patch 8 adds support for VF port statistics.
> 
> Patch 9 adds support to set mac address.
> 
> Patch 10 fixes bug where the other ports under same PF are not closed
> properly.
> 
> Patch 11 exports RSS hash functions in device info and adds check
> to prevent configuring unsupported hash functions.
> 
> Patch 12 converts all cxgbe files to use SPDX license tag.
> 
> Patch 13 adds compile time option to keep outer vlan tag in Q-in-Q
> packet.

We are trying to reduce the config options, is it possible to provide this
functionality with a runtime option (devargs) ?

Or there is already an offload option DEV_RX_OFFLOAD_QINQ_STRIP, I guess this is
different (is it?), if so does it make sense to have another offload option to
cover your case?


> 
> Thanks,
> Rahul
> 
> Kumar Sanghvi (10):
>   cxgbe: add skeleton VF driver
>   cxgbe: add VF firmware mailbox support
>   cxgbe: add base for enabling VF ports
>   cxgbe: add probe to initialize VF devices
>   cxgbe: initialize SGE and queues for VF
>   cxgbe: enable RSS for VF
>   cxgbe: update TX and RX path for VF
>   cxgbe: add VF port statistics
>   cxgbe: add support to set mac address
>   cxgbe: add option to keep outer VLAN tag in Q-in-Q
> 
> Rahul Lakkireddy (3):
>   cxgbe: fix check to close other ports properly
>   cxgbe: export supported RSS hash functions
>   cxgbe: convert to SPDX license tags

<...>