From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Fady Bader <fady@mellanox.com>, <dev@dpdk.org>
Cc: <thomas@monjalon.net>, <tbashar@mellanox.com>,
<talshn@mellanox.com>, <yohadt@mellanox.com>,
<dmitry.kozliuk@gmail.com>, <olivier.matz@6wind.com>,
<mdr@ashroe.eu>, <nhorman@tuxdriver.com>
Subject: Re: [dpdk-dev] [PATCH 3/5] mempool: use generic memory management
Date: Sun, 31 May 2020 16:06:10 +0300 [thread overview]
Message-ID: <afa05b64-5295-9bb2-1389-011e337721b4@solarflare.com> (raw)
In-Reply-To: <20200531124151.16848-4-fady@mellanox.com>
On 5/31/20 3:41 PM, Fady Bader wrote:
> mempool used Unix memory management calls, which are not supported
> on Windows.
> Used generic memory management instead.
>
> Signed-off-by: Fady Bader <fady@mellanox.com>
LGTM, but I've expected rte_eal_ prefix, not just rte_.
Anyway, these functions are added early and it is out-of-scope
of the patch.
Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
next prev parent reply other threads:[~2020-05-31 13:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-31 12:41 [dpdk-dev] [PATCH 0/5] build mempool on Windows Fady Bader
2020-05-31 12:41 ` [dpdk-dev] [PATCH 1/5] mempool: disable tracing for Windows Fady Bader
2020-05-31 13:02 ` Andrew Rybchenko
2020-06-01 1:54 ` Dmitry Kozlyuk
2020-05-31 13:49 ` Jerin Jacob
2020-05-31 12:41 ` [dpdk-dev] [PATCH 2/5] eal: disable function versioning on Windows Fady Bader
2020-05-31 12:41 ` [dpdk-dev] [PATCH 3/5] mempool: use generic memory management Fady Bader
2020-05-31 13:06 ` Andrew Rybchenko [this message]
2020-05-31 12:41 ` [dpdk-dev] [PATCH 4/5] eal: export needed functions for mempool Fady Bader
2020-05-31 12:41 ` [dpdk-dev] [PATCH 5/5] mempool: mempool build on Windows Fady Bader
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afa05b64-5295-9bb2-1389-011e337721b4@solarflare.com \
--to=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=fady@mellanox.com \
--cc=mdr@ashroe.eu \
--cc=nhorman@tuxdriver.com \
--cc=olivier.matz@6wind.com \
--cc=talshn@mellanox.com \
--cc=tbashar@mellanox.com \
--cc=thomas@monjalon.net \
--cc=yohadt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.