From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D954BC433DB for ; Wed, 17 Feb 2021 16:29:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9073264E02 for ; Wed, 17 Feb 2021 16:29:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233905AbhBQQ3G (ORCPT ); Wed, 17 Feb 2021 11:29:06 -0500 Received: from pv50p00im-hyfv10011601.me.com ([17.58.6.43]:54225 "EHLO pv50p00im-hyfv10011601.me.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234176AbhBQQ20 (ORCPT ); Wed, 17 Feb 2021 11:28:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; t=1613579250; bh=IbKyhojyJio149yJ9wHcjts+6gz8THb0g6hToz/sQdw=; h=Subject:To:From:Message-ID:Date:MIME-Version:Content-Type; b=j+3EAgShAuR9K5gZBG+wwjIYRQqF57MXaXDSWlaUkCWwC+Vr9xZzaaui24qRtSo9V m2W5mllQNgYG0vL+GoXkDWog8zC9aCmuWo89ZMvi45OmO/AfAZDxPvsHdJwkTMWc34 SW7nIpyK/q8J/viKdK8hA9NK7iZJNWdEyEzUXL0jXcOiozdkGlLxPVY18wDGox5RDt 1iNOogVFoihDHenPcOmap05/qNDKmq+T4G5PfdhE32UksAY1mPWv3Acm2iyqmGs0Qk 99ptTUO/ZeK8+zY+U1yb+tYZxeNRl//eRF+1T78mDSt/2Aml7V6YZkoz0Wf1hCb4fU ++5XO37jc+mJQ== Received: from [192.168.31.114] (unknown [45.250.51.33]) by pv50p00im-hyfv10011601.me.com (Postfix) with ESMTPSA id 05DAE380617; Wed, 17 Feb 2021 16:27:28 +0000 (UTC) Subject: Re: [PATCH] staging: wlan-ng: Fixed incorrect type warning in p80211netdev.c To: Greg KH Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org References: <20210217154255.112115-1-pritthijit.nath@icloud.com> From: Pritthijit Nath Message-ID: Date: Wed, 17 Feb 2021 21:57:25 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.761 definitions=2021-02-17_13:2021-02-16,2021-02-17 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-2006250000 definitions=main-2102170124 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/02/21 9:23 pm, Greg KH wrote: > On Wed, Feb 17, 2021 at 09:12:55PM +0530, Pritthijit Nath wrote: >> This change fixes a sparse warning "incorrect type in argument 1 >> (different address spaces)". >> >> Signed-off-by: Pritthijit Nath >> --- >> drivers/staging/wlan-ng/p80211netdev.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/staging/wlan-ng/p80211netdev.c b/drivers/staging/wlan-ng/p80211netdev.c >> index 6f9666dc0277..70570e8a5ad2 100644 >> --- a/drivers/staging/wlan-ng/p80211netdev.c >> +++ b/drivers/staging/wlan-ng/p80211netdev.c >> @@ -569,7 +569,7 @@ static int p80211knetdev_do_ioctl(struct net_device *dev, >> goto bail; >> } >> >> - msgbuf = memdup_user(req->data, req->len); >> + msgbuf = memdup_user((void __user *)req->data, req->len); > > Odd. Why isn't data tagged as a __user pointer to start with? > > thanks, > > greg k-h > In lines 540-548 -> ... static int p80211knetdev_do_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) { int result = 0; struct p80211ioctl_req *req = (struct p80211ioctl_req *)ifr; struct wlandevice *wlandev = dev->ml_priv; u8 *msgbuf; netdev_dbg(dev, "rx'd ioctl, cmd=%d, len=%d\n", cmd, req->len); ... it can be seen that *req is essentially coming from an explicit cast of *ifr. ifr->data itself is of char* type. So, imo, an explicit __user pointer cast is required. The patch above was based on the __user pointer cast done in lines 580-586 -> ... if (result == 0) { if (copy_to_user ((void __user *)req->data, msgbuf, req->len)) { result = -EFAULT; } } kfree(msgbuf); ... and lines 550-556 -> #ifdef SIOCETHTOOL if (cmd == SIOCETHTOOL) { result = p80211netdev_ethtool(wlandev, (void __user *)ifr->ifr_data); goto bail; } #endif From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95234C433DB for ; Wed, 17 Feb 2021 16:27:40 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3E9D464DE0 for ; Wed, 17 Feb 2021 16:27:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E9D464DE0 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=icloud.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id EC31B6F5F6 for ; Wed, 17 Feb 2021 16:27:39 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id z6h-PT5I_pB8 for ; Wed, 17 Feb 2021 16:27:39 +0000 (UTC) Received: by smtp3.osuosl.org (Postfix, from userid 1001) id 30C806F5FE; Wed, 17 Feb 2021 16:27:39 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 0C63E6F555; Wed, 17 Feb 2021 16:27:33 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 91B601BF429 for ; Wed, 17 Feb 2021 16:27:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 8E4DC87184 for ; Wed, 17 Feb 2021 16:27:32 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BQ5Jlajl3MkY for ; Wed, 17 Feb 2021 16:27:31 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from pv50p00im-hyfv10011601.me.com (pv50p00im-hyfv10011601.me.com [17.58.6.43]) by hemlock.osuosl.org (Postfix) with ESMTPS id 84B4B852FF for ; Wed, 17 Feb 2021 16:27:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; t=1613579250; bh=IbKyhojyJio149yJ9wHcjts+6gz8THb0g6hToz/sQdw=; h=Subject:To:From:Message-ID:Date:MIME-Version:Content-Type; b=j+3EAgShAuR9K5gZBG+wwjIYRQqF57MXaXDSWlaUkCWwC+Vr9xZzaaui24qRtSo9V m2W5mllQNgYG0vL+GoXkDWog8zC9aCmuWo89ZMvi45OmO/AfAZDxPvsHdJwkTMWc34 SW7nIpyK/q8J/viKdK8hA9NK7iZJNWdEyEzUXL0jXcOiozdkGlLxPVY18wDGox5RDt 1iNOogVFoihDHenPcOmap05/qNDKmq+T4G5PfdhE32UksAY1mPWv3Acm2iyqmGs0Qk 99ptTUO/ZeK8+zY+U1yb+tYZxeNRl//eRF+1T78mDSt/2Aml7V6YZkoz0Wf1hCb4fU ++5XO37jc+mJQ== Received: from [192.168.31.114] (unknown [45.250.51.33]) by pv50p00im-hyfv10011601.me.com (Postfix) with ESMTPSA id 05DAE380617; Wed, 17 Feb 2021 16:27:28 +0000 (UTC) Subject: Re: [PATCH] staging: wlan-ng: Fixed incorrect type warning in p80211netdev.c To: Greg KH References: <20210217154255.112115-1-pritthijit.nath@icloud.com> From: Pritthijit Nath Message-ID: Date: Wed, 17 Feb 2021 21:57:25 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369, 18.0.761 definitions=2021-02-17_13:2021-02-16, 2021-02-17 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-2006250000 definitions=main-2102170124 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On 17/02/21 9:23 pm, Greg KH wrote: > On Wed, Feb 17, 2021 at 09:12:55PM +0530, Pritthijit Nath wrote: >> This change fixes a sparse warning "incorrect type in argument 1 >> (different address spaces)". >> >> Signed-off-by: Pritthijit Nath >> --- >> drivers/staging/wlan-ng/p80211netdev.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/staging/wlan-ng/p80211netdev.c b/drivers/staging/wlan-ng/p80211netdev.c >> index 6f9666dc0277..70570e8a5ad2 100644 >> --- a/drivers/staging/wlan-ng/p80211netdev.c >> +++ b/drivers/staging/wlan-ng/p80211netdev.c >> @@ -569,7 +569,7 @@ static int p80211knetdev_do_ioctl(struct net_device *dev, >> goto bail; >> } >> >> - msgbuf = memdup_user(req->data, req->len); >> + msgbuf = memdup_user((void __user *)req->data, req->len); > > Odd. Why isn't data tagged as a __user pointer to start with? > > thanks, > > greg k-h > In lines 540-548 -> ... static int p80211knetdev_do_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) { int result = 0; struct p80211ioctl_req *req = (struct p80211ioctl_req *)ifr; struct wlandevice *wlandev = dev->ml_priv; u8 *msgbuf; netdev_dbg(dev, "rx'd ioctl, cmd=%d, len=%d\n", cmd, req->len); ... it can be seen that *req is essentially coming from an explicit cast of *ifr. ifr->data itself is of char* type. So, imo, an explicit __user pointer cast is required. The patch above was based on the __user pointer cast done in lines 580-586 -> ... if (result == 0) { if (copy_to_user ((void __user *)req->data, msgbuf, req->len)) { result = -EFAULT; } } kfree(msgbuf); ... and lines 550-556 -> #ifdef SIOCETHTOOL if (cmd == SIOCETHTOOL) { result = p80211netdev_ethtool(wlandev, (void __user *)ifr->ifr_data); goto bail; } #endif _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel