From: Jeff Layton <jlayton@kernel.org>
To: Xiubo Li <xiubli@redhat.com>, idryomov@gmail.com
Cc: lhenriques@suse.de, vshankar@redhat.com, ceph-devel@vger.kernel.org
Subject: Re: [PATCH] ceph: remove useless CEPHFS_FEATURES_CLIENT_REQUIRED
Date: Thu, 26 May 2022 06:37:24 -0400 [thread overview]
Message-ID: <afb34ae5b243ccea7e799b45812c47ad6efa0541.camel@kernel.org> (raw)
In-Reply-To: <20220526060721.735547-1-xiubli@redhat.com>
On Thu, 2022-05-26 at 14:07 +0800, Xiubo Li wrote:
> This macro was added but never be used. And check the ceph code
> there has another CEPHFS_FEATURES_MDS_REQUIRED but always be empty.
>
> We should clean up all this related code, which make no sense but
> introducing confusion.
>
> Signed-off-by: Xiubo Li <xiubli@redhat.com>
> ---
> fs/ceph/mds_client.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/ceph/mds_client.h b/fs/ceph/mds_client.h
> index 636fcf4503e0..d8ec2ac93da3 100644
> --- a/fs/ceph/mds_client.h
> +++ b/fs/ceph/mds_client.h
> @@ -42,7 +42,6 @@ enum ceph_feature_type {
> CEPHFS_FEATURE_DELEG_INO, \
> CEPHFS_FEATURE_METRIC_COLLECT, \
> }
> -#define CEPHFS_FEATURES_CLIENT_REQUIRED {}
>
> /*
> * Some lock dependencies:
Reviewed-by: Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2022-05-26 10:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-26 6:07 [PATCH] ceph: remove useless CEPHFS_FEATURES_CLIENT_REQUIRED Xiubo Li
2022-05-26 10:37 ` Jeff Layton [this message]
2022-05-27 9:20 ` Luís Henriques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afb34ae5b243ccea7e799b45812c47ad6efa0541.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=lhenriques@suse.de \
--cc=vshankar@redhat.com \
--cc=xiubli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.