From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E3601C433EF for ; Sat, 27 Nov 2021 02:47:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 8B22B409B7; Sat, 27 Nov 2021 02:47:05 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VN-GN2fYcWeL; Sat, 27 Nov 2021 02:47:04 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp4.osuosl.org (Postfix) with ESMTPS id 855B4409B4; Sat, 27 Nov 2021 02:47:04 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 6F0FAC0012; Sat, 27 Nov 2021 02:47:04 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id AA475C000A for ; Sat, 27 Nov 2021 02:47:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 95D9E82C84 for ; Sat, 27 Nov 2021 02:47:03 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp1.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=mediatek.com Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id O34St2AIRxQI for ; Sat, 27 Nov 2021 02:47:02 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by smtp1.osuosl.org (Postfix) with ESMTPS id 0B8B082C5E for ; Sat, 27 Nov 2021 02:47:01 +0000 (UTC) X-UUID: 63097bdb89564466aacb8ffc82d8cb9c-20211127 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=ujgxNDgOxn13iafpFO6sRZICJ73MLq1oFrLOiv1fYeY=; b=bPmANuoT3cfKXUNqiiCIKIBt36G5QsT5X1foyd6PeX8RDglm4eoXsdsdzOiQLfyxvLnjJUNQQ7x+RBMns+IqBm5AIbKu7ltcdy/u9XRkTjZNLyVeNg2nXZyZCj/z9wMAZRwagN5KI/8k1+yQZ73y7AJ7TWxNAecP+bhl8z43yow=; X-UUID: 63097bdb89564466aacb8ffc82d8cb9c-20211127 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1665839108; Sat, 27 Nov 2021 10:46:57 +0800 Received: from mtkexhb02.mediatek.inc (172.21.101.103) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 27 Nov 2021 10:46:55 +0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkexhb02.mediatek.inc (172.21.101.103) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 27 Nov 2021 10:46:55 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sat, 27 Nov 2021 10:46:54 +0800 Message-ID: Subject: Re: [PATCH 2/2] iommu/mediatek: always check runtime PM status in tlb flush range callback From: Yong Wu To: Dafna Hirschfeld , Date: Sat, 27 Nov 2021 10:46:54 +0800 In-Reply-To: <20211122104400.4160-3-dafna.hirschfeld@collabora.com> References: <20211122104400.4160-1-dafna.hirschfeld@collabora.com> <20211122104400.4160-3-dafna.hirschfeld@collabora.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N Cc: Sebastian Reichel , open list , "moderated list:MEDIATEK IOMMU DRIVER" , Matthias Brugger , kernel@collabora.com, Will Deacon , "moderated list:ARM/Mediatek SoC support" , linux-media@vger.kernel.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Mon, 2021-11-22 at 12:44 +0200, Dafna Hirschfeld wrote: > From: Sebastian Reichel > > In case of v4l2_reqbufs() it is possible, that a TLB flush is done > without runtime PM being enabled. In that case the "Partial TLB flush > timed out, falling back to full flush" warning is printed. > > Commit c0b57581b73b ("iommu/mediatek: Add power-domain operation") > introduced has_pm as optimization to avoid checking runtime PM > when there is no power domain attached. But without the PM domain > there is still the device driver's runtime PM suspend handler, which > disables the clock. Thus flushing should also be avoided when there > is no PM domain involved. > > Signed-off-by: Sebastian Reichel > Reviewed-by: Dafna Hirschfeld Reviewed-by: Yong Wu > --- > drivers/iommu/mtk_iommu.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c > index 28dc4b95b6d9..b0535fcfd1d7 100644 > --- a/drivers/iommu/mtk_iommu.c > +++ b/drivers/iommu/mtk_iommu.c > @@ -227,16 +227,13 @@ static void > mtk_iommu_tlb_flush_range_sync(unsigned long iova, size_t size, > size_t granule, > struct mtk_iommu_data *data) > { > - bool has_pm = !!data->dev->pm_domain; > unsigned long flags; > int ret; > u32 tmp; > > for_each_m4u(data) { > - if (has_pm) { > - if (pm_runtime_get_if_in_use(data->dev) <= 0) > - continue; > - } > + if (pm_runtime_get_if_in_use(data->dev) <= 0) > + continue; > > spin_lock_irqsave(&data->tlb_lock, flags); > writel_relaxed(F_INVLD_EN1 | F_INVLD_EN0, > @@ -261,8 +258,7 @@ static void > mtk_iommu_tlb_flush_range_sync(unsigned long iova, size_t size, > writel_relaxed(0, data->base + REG_MMU_CPE_DONE); > spin_unlock_irqrestore(&data->tlb_lock, flags); > > - if (has_pm) > - pm_runtime_put(data->dev); > + pm_runtime_put(data->dev); > } > } > _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 82EF5C433F5 for ; Sat, 27 Nov 2021 02:47:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kVaJFa2ZEyQPdT11WGS+rv+Xs5eLDg8OMyHLFg1LDpE=; b=BmteKYbgatelWL xhFc8pi7M+qbmkIcXta0OfGVnuaPihhUmVrkqYnBIfoDTPaXhBx9QRDm5xwYGj0NfCHN3nnnE0vPM dt5BWe0Yk5HfamdKXCCs9TxYEgfljiy8T3L1diQZXNV8ec4RTY2YKyTD5UAR9ijDQf8LNi4SGZvlj Zw9aMVhP84+rANiBSt9D4ZFd3t7ZoCKnXvwsmXTrClCnCwRJKG0OKNdPCxL74V94yPyIawupf9P/7 x9LDk2eNIZMGUiknBVzhRoapH7AbtUM9aw4DyN2lwT7Zde/YFGsWlND+vQ+ImNEc5xud7twcLxbLB ZyBoJgD8p/MatFGWnbEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqnkB-00Cl6F-Gw; Sat, 27 Nov 2021 02:47:15 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqnk9-00Cl5h-J2; Sat, 27 Nov 2021 02:47:14 +0000 X-UUID: 3bd24908f79b4529a9d4f27f4e5857fa-20211126 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=ujgxNDgOxn13iafpFO6sRZICJ73MLq1oFrLOiv1fYeY=; b=bPmANuoT3cfKXUNqiiCIKIBt36G5QsT5X1foyd6PeX8RDglm4eoXsdsdzOiQLfyxvLnjJUNQQ7x+RBMns+IqBm5AIbKu7ltcdy/u9XRkTjZNLyVeNg2nXZyZCj/z9wMAZRwagN5KI/8k1+yQZ73y7AJ7TWxNAecP+bhl8z43yow=; X-UUID: 3bd24908f79b4529a9d4f27f4e5857fa-20211126 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 268191276; Fri, 26 Nov 2021 19:47:09 -0700 Received: from mtkexhb02.mediatek.inc (172.21.101.103) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 26 Nov 2021 18:47:08 -0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkexhb02.mediatek.inc (172.21.101.103) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 27 Nov 2021 10:46:55 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sat, 27 Nov 2021 10:46:54 +0800 Message-ID: Subject: Re: [PATCH 2/2] iommu/mediatek: always check runtime PM status in tlb flush range callback From: Yong Wu To: Dafna Hirschfeld , CC: Sebastian Reichel , , Joerg Roedel , Will Deacon , Matthias Brugger , "moderated list:MEDIATEK IOMMU DRIVER" , "moderated list:ARM/Mediatek SoC support" , "open list" , Date: Sat, 27 Nov 2021 10:46:54 +0800 In-Reply-To: <20211122104400.4160-3-dafna.hirschfeld@collabora.com> References: <20211122104400.4160-1-dafna.hirschfeld@collabora.com> <20211122104400.4160-3-dafna.hirschfeld@collabora.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211126_184713_655584_68FF4730 X-CRM114-Status: GOOD ( 20.10 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Mon, 2021-11-22 at 12:44 +0200, Dafna Hirschfeld wrote: > From: Sebastian Reichel > > In case of v4l2_reqbufs() it is possible, that a TLB flush is done > without runtime PM being enabled. In that case the "Partial TLB flush > timed out, falling back to full flush" warning is printed. > > Commit c0b57581b73b ("iommu/mediatek: Add power-domain operation") > introduced has_pm as optimization to avoid checking runtime PM > when there is no power domain attached. But without the PM domain > there is still the device driver's runtime PM suspend handler, which > disables the clock. Thus flushing should also be avoided when there > is no PM domain involved. > > Signed-off-by: Sebastian Reichel > Reviewed-by: Dafna Hirschfeld Reviewed-by: Yong Wu > --- > drivers/iommu/mtk_iommu.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c > index 28dc4b95b6d9..b0535fcfd1d7 100644 > --- a/drivers/iommu/mtk_iommu.c > +++ b/drivers/iommu/mtk_iommu.c > @@ -227,16 +227,13 @@ static void > mtk_iommu_tlb_flush_range_sync(unsigned long iova, size_t size, > size_t granule, > struct mtk_iommu_data *data) > { > - bool has_pm = !!data->dev->pm_domain; > unsigned long flags; > int ret; > u32 tmp; > > for_each_m4u(data) { > - if (has_pm) { > - if (pm_runtime_get_if_in_use(data->dev) <= 0) > - continue; > - } > + if (pm_runtime_get_if_in_use(data->dev) <= 0) > + continue; > > spin_lock_irqsave(&data->tlb_lock, flags); > writel_relaxed(F_INVLD_EN1 | F_INVLD_EN0, > @@ -261,8 +258,7 @@ static void > mtk_iommu_tlb_flush_range_sync(unsigned long iova, size_t size, > writel_relaxed(0, data->base + REG_MMU_CPE_DONE); > spin_unlock_irqrestore(&data->tlb_lock, flags); > > - if (has_pm) > - pm_runtime_put(data->dev); > + pm_runtime_put(data->dev); > } > } > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34B1CC433FE for ; Sat, 27 Nov 2021 02:49:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351440AbhK0CwP (ORCPT ); Fri, 26 Nov 2021 21:52:15 -0500 Received: from mailgw02.mediatek.com ([210.61.82.184]:53750 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S234464AbhK0CuN (ORCPT ); Fri, 26 Nov 2021 21:50:13 -0500 X-UUID: 63097bdb89564466aacb8ffc82d8cb9c-20211127 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=ujgxNDgOxn13iafpFO6sRZICJ73MLq1oFrLOiv1fYeY=; b=bPmANuoT3cfKXUNqiiCIKIBt36G5QsT5X1foyd6PeX8RDglm4eoXsdsdzOiQLfyxvLnjJUNQQ7x+RBMns+IqBm5AIbKu7ltcdy/u9XRkTjZNLyVeNg2nXZyZCj/z9wMAZRwagN5KI/8k1+yQZ73y7AJ7TWxNAecP+bhl8z43yow=; X-UUID: 63097bdb89564466aacb8ffc82d8cb9c-20211127 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1665839108; Sat, 27 Nov 2021 10:46:57 +0800 Received: from mtkexhb02.mediatek.inc (172.21.101.103) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 27 Nov 2021 10:46:55 +0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkexhb02.mediatek.inc (172.21.101.103) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 27 Nov 2021 10:46:55 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sat, 27 Nov 2021 10:46:54 +0800 Message-ID: Subject: Re: [PATCH 2/2] iommu/mediatek: always check runtime PM status in tlb flush range callback From: Yong Wu To: Dafna Hirschfeld , CC: Sebastian Reichel , , Joerg Roedel , Will Deacon , Matthias Brugger , "moderated list:MEDIATEK IOMMU DRIVER" , "moderated list:ARM/Mediatek SoC support" , "open list" , Date: Sat, 27 Nov 2021 10:46:54 +0800 In-Reply-To: <20211122104400.4160-3-dafna.hirschfeld@collabora.com> References: <20211122104400.4160-1-dafna.hirschfeld@collabora.com> <20211122104400.4160-3-dafna.hirschfeld@collabora.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org T24gTW9uLCAyMDIxLTExLTIyIGF0IDEyOjQ0ICswMjAwLCBEYWZuYSBIaXJzY2hmZWxkIHdyb3Rl Og0KPiBGcm9tOiBTZWJhc3RpYW4gUmVpY2hlbCA8c2ViYXN0aWFuLnJlaWNoZWxAY29sbGFib3Jh LmNvbT4NCj4gDQo+IEluIGNhc2Ugb2YgdjRsMl9yZXFidWZzKCkgaXQgaXMgcG9zc2libGUsIHRo YXQgYSBUTEIgZmx1c2ggaXMgZG9uZQ0KPiB3aXRob3V0IHJ1bnRpbWUgUE0gYmVpbmcgZW5hYmxl ZC4gSW4gdGhhdCBjYXNlIHRoZSAiUGFydGlhbCBUTEIgZmx1c2gNCj4gdGltZWQgb3V0LCBmYWxs aW5nIGJhY2sgdG8gZnVsbCBmbHVzaCIgd2FybmluZyBpcyBwcmludGVkLg0KPiANCj4gQ29tbWl0 IGMwYjU3NTgxYjczYiAoImlvbW11L21lZGlhdGVrOiBBZGQgcG93ZXItZG9tYWluIG9wZXJhdGlv biIpDQo+IGludHJvZHVjZWQgaGFzX3BtIGFzIG9wdGltaXphdGlvbiB0byBhdm9pZCBjaGVja2lu ZyBydW50aW1lIFBNDQo+IHdoZW4gdGhlcmUgaXMgbm8gcG93ZXIgZG9tYWluIGF0dGFjaGVkLiBC dXQgd2l0aG91dCB0aGUgUE0gZG9tYWluDQo+IHRoZXJlIGlzIHN0aWxsIHRoZSBkZXZpY2UgZHJp dmVyJ3MgcnVudGltZSBQTSBzdXNwZW5kIGhhbmRsZXIsIHdoaWNoDQo+IGRpc2FibGVzIHRoZSBj bG9jay4gVGh1cyBmbHVzaGluZyBzaG91bGQgYWxzbyBiZSBhdm9pZGVkIHdoZW4gdGhlcmUNCj4g aXMgbm8gUE0gZG9tYWluIGludm9sdmVkLg0KPiANCj4gU2lnbmVkLW9mZi1ieTogU2ViYXN0aWFu IFJlaWNoZWwgPHNlYmFzdGlhbi5yZWljaGVsQGNvbGxhYm9yYS5jb20+DQo+IFJldmlld2VkLWJ5 OiBEYWZuYSBIaXJzY2hmZWxkIDxkYWZuYS5oaXJzY2hmZWxkQGNvbGxhYm9yYS5jb20+DQoNClJl dmlld2VkLWJ5OiBZb25nIFd1IDx5b25nLnd1QG1lZGlhdGVrLmNvbT4NCg0KPiAtLS0NCj4gIGRy aXZlcnMvaW9tbXUvbXRrX2lvbW11LmMgfCAxMCArKystLS0tLS0tDQo+ICAxIGZpbGUgY2hhbmdl ZCwgMyBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvaW9tbXUvbXRrX2lvbW11LmMgYi9kcml2ZXJzL2lvbW11L210a19pb21tdS5jDQo+IGlu ZGV4IDI4ZGM0Yjk1YjZkOS4uYjA1MzVmY2ZkMWQ3IDEwMDY0NA0KPiAtLS0gYS9kcml2ZXJzL2lv bW11L210a19pb21tdS5jDQo+ICsrKyBiL2RyaXZlcnMvaW9tbXUvbXRrX2lvbW11LmMNCj4gQEAg LTIyNywxNiArMjI3LDEzIEBAIHN0YXRpYyB2b2lkDQo+IG10a19pb21tdV90bGJfZmx1c2hfcmFu Z2Vfc3luYyh1bnNpZ25lZCBsb25nIGlvdmEsIHNpemVfdCBzaXplLA0KPiAgCQkJCQkgICBzaXpl X3QgZ3JhbnVsZSwNCj4gIAkJCQkJICAgc3RydWN0IG10a19pb21tdV9kYXRhICpkYXRhKQ0KPiAg ew0KPiAtCWJvb2wgaGFzX3BtID0gISFkYXRhLT5kZXYtPnBtX2RvbWFpbjsNCj4gIAl1bnNpZ25l ZCBsb25nIGZsYWdzOw0KPiAgCWludCByZXQ7DQo+ICAJdTMyIHRtcDsNCj4gIA0KPiAgCWZvcl9l YWNoX200dShkYXRhKSB7DQo+IC0JCWlmIChoYXNfcG0pIHsNCj4gLQkJCWlmIChwbV9ydW50aW1l X2dldF9pZl9pbl91c2UoZGF0YS0+ZGV2KSA8PSAwKQ0KPiAtCQkJCWNvbnRpbnVlOw0KPiAtCQl9 DQo+ICsJCWlmIChwbV9ydW50aW1lX2dldF9pZl9pbl91c2UoZGF0YS0+ZGV2KSA8PSAwKQ0KPiAr CQkJY29udGludWU7DQo+ICANCj4gIAkJc3Bpbl9sb2NrX2lycXNhdmUoJmRhdGEtPnRsYl9sb2Nr LCBmbGFncyk7DQo+ICAJCXdyaXRlbF9yZWxheGVkKEZfSU5WTERfRU4xIHwgRl9JTlZMRF9FTjAs DQo+IEBAIC0yNjEsOCArMjU4LDcgQEAgc3RhdGljIHZvaWQNCj4gbXRrX2lvbW11X3RsYl9mbHVz aF9yYW5nZV9zeW5jKHVuc2lnbmVkIGxvbmcgaW92YSwgc2l6ZV90IHNpemUsDQo+ICAJCXdyaXRl bF9yZWxheGVkKDAsIGRhdGEtPmJhc2UgKyBSRUdfTU1VX0NQRV9ET05FKTsNCj4gIAkJc3Bpbl91 bmxvY2tfaXJxcmVzdG9yZSgmZGF0YS0+dGxiX2xvY2ssIGZsYWdzKTsNCj4gIA0KPiAtCQlpZiAo aGFzX3BtKQ0KPiAtCQkJcG1fcnVudGltZV9wdXQoZGF0YS0+ZGV2KTsNCj4gKwkJcG1fcnVudGlt ZV9wdXQoZGF0YS0+ZGV2KTsNCj4gIAl9DQo+ICB9DQo+ICANCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 07D1FC433EF for ; Sat, 27 Nov 2021 02:49:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bEi2WXvdiLIt3mnHdXB12RVFtx2Oy1y9RFGDC5s0ts8=; b=CV/1fjCqVu+CwK Ccv+kF/rZhKqrColF+KPKvLREQ8fEuTOG+mK9QeRa4PITP32BDUYarSKbiJDCX3/gCP/Z34ofFw6q uhX4Vu6ucmGktVcw2fYPtrk4odT/LzDZq9UCwU78uSdsxPdgClwvZCYRnGOyroJd+QmTQ/BYsbagt 9nG2qPupYmqo/j0BEbETq7E+OxZKm3QjMCB/DzF8LqablG0dpwqkBqnZxZYyUJAeVK4RWikoOnxI3 L4Rfq7Wvo0h7chyV2LuCsUR8wMELILRPK9SREE4zGrAicMee2pYUVG2nXc/ZCGdkhjprd2//HAkQF o95YMdAz10Q0uNHhNKcw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqnkD-00Cl6N-9Y; Sat, 27 Nov 2021 02:47:17 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqnk9-00Cl5h-J2; Sat, 27 Nov 2021 02:47:14 +0000 X-UUID: 3bd24908f79b4529a9d4f27f4e5857fa-20211126 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=ujgxNDgOxn13iafpFO6sRZICJ73MLq1oFrLOiv1fYeY=; b=bPmANuoT3cfKXUNqiiCIKIBt36G5QsT5X1foyd6PeX8RDglm4eoXsdsdzOiQLfyxvLnjJUNQQ7x+RBMns+IqBm5AIbKu7ltcdy/u9XRkTjZNLyVeNg2nXZyZCj/z9wMAZRwagN5KI/8k1+yQZ73y7AJ7TWxNAecP+bhl8z43yow=; X-UUID: 3bd24908f79b4529a9d4f27f4e5857fa-20211126 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 268191276; Fri, 26 Nov 2021 19:47:09 -0700 Received: from mtkexhb02.mediatek.inc (172.21.101.103) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 26 Nov 2021 18:47:08 -0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkexhb02.mediatek.inc (172.21.101.103) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 27 Nov 2021 10:46:55 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sat, 27 Nov 2021 10:46:54 +0800 Message-ID: Subject: Re: [PATCH 2/2] iommu/mediatek: always check runtime PM status in tlb flush range callback From: Yong Wu To: Dafna Hirschfeld , CC: Sebastian Reichel , , Joerg Roedel , Will Deacon , Matthias Brugger , "moderated list:MEDIATEK IOMMU DRIVER" , "moderated list:ARM/Mediatek SoC support" , "open list" , Date: Sat, 27 Nov 2021 10:46:54 +0800 In-Reply-To: <20211122104400.4160-3-dafna.hirschfeld@collabora.com> References: <20211122104400.4160-1-dafna.hirschfeld@collabora.com> <20211122104400.4160-3-dafna.hirschfeld@collabora.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211126_184713_655584_68FF4730 X-CRM114-Status: GOOD ( 20.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 2021-11-22 at 12:44 +0200, Dafna Hirschfeld wrote: > From: Sebastian Reichel > > In case of v4l2_reqbufs() it is possible, that a TLB flush is done > without runtime PM being enabled. In that case the "Partial TLB flush > timed out, falling back to full flush" warning is printed. > > Commit c0b57581b73b ("iommu/mediatek: Add power-domain operation") > introduced has_pm as optimization to avoid checking runtime PM > when there is no power domain attached. But without the PM domain > there is still the device driver's runtime PM suspend handler, which > disables the clock. Thus flushing should also be avoided when there > is no PM domain involved. > > Signed-off-by: Sebastian Reichel > Reviewed-by: Dafna Hirschfeld Reviewed-by: Yong Wu > --- > drivers/iommu/mtk_iommu.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c > index 28dc4b95b6d9..b0535fcfd1d7 100644 > --- a/drivers/iommu/mtk_iommu.c > +++ b/drivers/iommu/mtk_iommu.c > @@ -227,16 +227,13 @@ static void > mtk_iommu_tlb_flush_range_sync(unsigned long iova, size_t size, > size_t granule, > struct mtk_iommu_data *data) > { > - bool has_pm = !!data->dev->pm_domain; > unsigned long flags; > int ret; > u32 tmp; > > for_each_m4u(data) { > - if (has_pm) { > - if (pm_runtime_get_if_in_use(data->dev) <= 0) > - continue; > - } > + if (pm_runtime_get_if_in_use(data->dev) <= 0) > + continue; > > spin_lock_irqsave(&data->tlb_lock, flags); > writel_relaxed(F_INVLD_EN1 | F_INVLD_EN0, > @@ -261,8 +258,7 @@ static void > mtk_iommu_tlb_flush_range_sync(unsigned long iova, size_t size, > writel_relaxed(0, data->base + REG_MMU_CPE_DONE); > spin_unlock_irqrestore(&data->tlb_lock, flags); > > - if (has_pm) > - pm_runtime_put(data->dev); > + pm_runtime_put(data->dev); > } > } > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel