From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jia He Subject: Re: [PATCH v8 3/3] ring: introduce new header file to support C11 memory model Date: Fri, 19 Jan 2018 10:22:53 +0800 Message-ID: References: <1516161831-28719-1-git-send-email-hejianet@gmail.com> <23810751-921d-4e3a-bac6-95d251cc122f@gmail.com> <3399617.YsM4r4Ydhj@xps> <1629453.JGSeBPTEmg@xps> Mime-Version: 1.0 Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Cc: dev@dpdk.org, Jerin Jacob , Jianbo Liu , Jan Viktorin , Olivier Matz , konstantin.ananyev@intel.com, hemant.agrawal@nxp.com To: Thomas Monjalon , Jia He Return-path: Received: from mail-pf0-f177.google.com (mail-pf0-f177.google.com [209.85.192.177]) by dpdk.org (Postfix) with ESMTP id E19DE1B2E5 for ; Fri, 19 Jan 2018 03:22:57 +0100 (CET) Received: by mail-pf0-f177.google.com with SMTP id j3so246868pfh.8 for ; Thu, 18 Jan 2018 18:22:57 -0800 (PST) In-Reply-To: <1629453.JGSeBPTEmg@xps> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/19/2018 7:52 AM, Thomas Monjalon Wrote: > 17/01/2018 10:09, Thomas Monjalon: >> 17/01/2018 09:47, Jia He: >>> Hi Thomas >>> >>> On 1/17/2018 4:24 PM, Thomas Monjalon Wrote: >>>> 17/01/2018 05:03, Jia He: >>>>> To support C11 memory model barrier, 2 options are suggested by Jerin: >>>>> 1. use rte_smp_rmb >>>>> 2. use load_acquire/store_release(refer to [1]). >>>>> CONFIG_RTE_RING_USE_C11_MEM_MODEL is provided, and by default it is "n" >>>>> on any architectures so far. >>>> In previous patches, it was enabled for ARM. >>>> You decided to not enable it at all? >>> Sorry, maybe I misunderstand your previous mail. >>> >This config option should be added in the common file (as disabled). >>> Do you mean CONFIG_RTE_RING_USE_C11_MEM_MODEL=n in comm_base and >>> "y" in armv8 config? >> Yes, exactly > Please, could you send a v9? > Thanks >>This double license may be an issue. >>Hemant, comment? Ok£¬ should I remove the double license info before Hemant's confirmation? -- Cheers, Jia