Re: [PATCH] Lenovo X13 Yoga OLED panel brightness fix

[Lyude Paul <lyude@redhat.com>]

ok-actually, I'm not sure dim will actually allow me to push this because this
never hit dri-devel as a properly formatted patch (because of the --------------
---------- you put at the top of the branch confusing things)

Can you try again without adding any comments, and ideally see if lenovo can
make it so you can just use git send-email? (unfortunately you're really not
going to be able to work around this if you'll need to be submitting patches
more regularly in the future I'm afraid)

On Mon, 2020-05-18 at 18:43 -0400, Lyude Paul wrote:
> Yeah, git send-email is kinda :(, but unfortunately the entire kernel uses
> this
> workflow. Hopefully freedesktop's gitlab efforts will change this someday...
> 
> also - in the future, if you don't want comments to appear in the patch when
> they're applied put them below the ---, e.g. the one before the Reviewed-by:
> tag.
> 
> Anyway-I'll go ahead and push this, thanks for keeping this list up to date!
> 
> On Mon, 2020-05-18 at 00:06 +0000, Mark Pearson wrote:
> > Hi,
> > 
> > Patch to fix an issue controlling the brightness of the OLED panel on the
> > Lenovo X13 Yoga 
> > Please let me know any feedback or questions.
> > Note - apologies if this message has shown up before - I had some mail
> > client
> > issues.
> > 
> > Mark Pearson
> > ---------------------------------
> > 
> > Add another panel that needs the edid quirk to the list so that brightness 
> > control works correctly. Fixes issue seen on Lenovo X13 Yoga with OLED panel
> > 
> > Co-developed-by: jendrina@lenovo.com
> > Signed-off-by: jendrina@lenovo.com
> > Signed-off-by: Mark Pearson <mpearson@lenovo.com>
> > Reviewed-by: Lyude Paul <lyude@redhat.com>
> > ---
> > drivers/gpu/drm/drm_dp_helper.c | 1 +
> > 1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/gpu/drm/drm_dp_helper.c
> > b/drivers/gpu/drm/drm_dp_helper.c
> > index c6fbe6e6bc9d..41f0e797ce8c 100644
> > --- a/drivers/gpu/drm/drm_dp_helper.c
> > +++ b/drivers/gpu/drm/drm_dp_helper.c
> > @@ -1313,6 +1313,7 @@ static const struct edid_quirk edid_quirk_list[] = {
> >                { MFG(0x06, 0xaf), PROD_ID(0xeb, 0x41),
> > BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
> >                { MFG(0x4d, 0x10), PROD_ID(0xc7, 0x14),
> > BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
> >                { MFG(0x4d, 0x10), PROD_ID(0xe6, 0x14),
> > BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
> > +             { MFG(0x4c, 0x83), PROD_ID(0x47, 0x41),
> > BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
> > };
> > 
> >  #undef MFG

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel