From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED302C433EF for ; Wed, 23 Feb 2022 18:12:33 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2107E40E5A; Wed, 23 Feb 2022 19:12:33 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 8743040DF6 for ; Wed, 23 Feb 2022 19:12:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645639951; x=1677175951; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=Dc94nHaEKMrLy+sv2OToNsYyRFv8Wic8lI7BksWlyl4=; b=naRjuB8a3i/eRhyOIvknfAj8UEOxdD+PW/PRl+ZOGzIn4hAYRSVQVzS9 o2JZke+yW234xbs9xvlb3emCni0e98OjXfcA0IyqAu2y6nPZsd2/4CvFp vPK5FyycMgMQ6aEv4p3Jk64SaLIgMjN9v8777lHsK0xgTyit2SGXztTqK wVvN+HiTxOCNCZkZ4rGd576CKH0OGc+CuI0od7j0mwxppGgNA3Y+x/gn8 L2iBLKcDU7g8+gFNWxyyfVHeiH9god85k4dANaFyhuZpO4Y0LY0HiUc6O b+jvIr1Lm8TfjcfITKnObrME9J5yvATXPHPZwnWZTDV/qv4xCRlvL/H79 Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10267"; a="276667199" X-IronPort-AV: E=Sophos;i="5.88,391,1635231600"; d="scan'208";a="276667199" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2022 10:12:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,391,1635231600"; d="scan'208";a="548378067" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga008.jf.intel.com with ESMTP; 23 Feb 2022 10:12:29 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Wed, 23 Feb 2022 10:12:28 -0800 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 23 Feb 2022 10:12:28 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Wed, 23 Feb 2022 10:12:28 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.175) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 23 Feb 2022 10:12:27 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oFhRh2B2VM66KscmxuWqjZ/mc8cq0+gs+CxzQIjE8k6Fv4wyyro1MUpwEmygfepzRr0bsBK+fetXYL8MFhdPEjQcsVIowlRbs39pimxNflma3LkbTtleOAr+A5276c+fzltoUPkwO3hSOEv6pq8kXlSykpGNKrojYAd+87G6SmjELUC09SPhJmk25RxQoYF9DuN4t1ix6ZScSNSOuZ4WBJqkXNDjzgGMugltJLis6Qxvjq2uj5KEkKTWdEbrLnODBfrPxHBCFo6akCATCJHQ7kpwN9Y7y9sqbTpwvbtiUDuG/cT5o5/5T2lNfBKfm3F/Gl18gfSrPBZwaht66aRXSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PrV31DHI9dym6NC3p7ii0XmYBUrsVGgihZss+ULU0A4=; b=UDz83whiU5powPPC3EWaY4zGdWmJFqZj7YEYALCUBqedNT59Flq93fuOFQNTMjLNc8tFt8gQZs+6+dd+FPm4pU6JwP/AwUl6FQ0o5JBV2jNYJv2G00osRl7DBgsR7Xk2QABR2AUIhfsRovvxyR8JN9orAZIGJugUSnawuhNHoC8FUsF5Qi8LaOgurZK7dWGxVpsAIVzt88637OCmgBin/LIKYVqwxAEB9dEYgOOHVDSVVB9JhMySIvngR3th6sievnod9CgwCX/FU6ww3VM3NkkewpeHUWsL/YzA3C+AJgyVhccIlRSosav15CFafe6l4xtAb08467F4Enmb+8o97Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by BN6PR11MB1604.namprd11.prod.outlook.com (2603:10b6:405:e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Wed, 23 Feb 2022 18:12:26 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4995.027; Wed, 23 Feb 2022 18:12:26 +0000 Message-ID: Date: Wed, 23 Feb 2022 18:12:19 +0000 Subject: Re: [PATCH v3 04/21] net/ena: remove unused offloads variables Content-Language: en-US To: =?UTF-8?Q?Micha=c5=82_Krawczyk?= CC: dev , "Brandes, Shai" , , Artur Rojek , Dawid Gorecki , Igor Chauskin , Kevin Traynor , Luca Boccassi References: <20220222181146.28882-1-mk@semihalf.com> <20220223121944.24156-1-mk@semihalf.com> <20220223121944.24156-5-mk@semihalf.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0205.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a5::12) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 54ebfb9b-4d52-4b39-4d7b-08d9f6f80beb X-MS-TrafficTypeDiagnostic: BN6PR11MB1604:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rPREJRYL+FtNfvbFcquMMcUE/YYRM8j6VyyRnwGxRYvUXa67lqqz53MvIlV0notht9Uz4NdMwFqN2TJWMwBdgsQ2i2MTH7oVDc9X9OCizxs2lcWMj0slAleHK5p2ypCWnim+RmTz6TlZ74ORyoi936BqxdcrXsA/IdUAOM/Sbos/Rz7/FS0Idu9uoQf3Y4+5EIWAEhw1pelECf2yy6CvAIFAWvuZMjWnlsAd9P8VGMyQ2rYFAjqwJtEeka0GS1zRzxU6XMn2SPFcjSxbYZJDLIa6dMmvzHS83v4YBlTOfHmkzRhrSjjnf6JhUtHga4rnvNlDTRhNMQnAQUxKbWe7AbsCQ/H5Ez951s13eqVzvTLC9FB9ytg53d/FUpn2/Z9toynRV6dqwEL0F8+rgQ2XdiuunL4xNtdfAtk/ysFcVTVzGOw5iHSXr0wa1PdoOfBe6bS3MiXr70kGWjZBeaNW6WYTNB8LDuS/xi3nivPOKk7yoIts/Npbsccr0LKIfHe00HJKL6GcAAJS7Gd5j7P/f3BNPDr2GMRhioxHZesG/BlnigdfCXwHU0+QvZ1ORPFMF2zLLTrvx1NeMof2AIojwZqn982GD4EQWiLbjQ5rGa+iAEyY0RzL9PguAK9tN5t+HYqPAQ7kZSWd7GW9Unc9CSkaSFpT3stx0weOk+cznQI/68rAajr4leyWP5Qav/RYt/f4iw0rAIVvg7vCjpYTPQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(44832011)(36756003)(4326008)(8676002)(316002)(38100700002)(86362001)(4744005)(66476007)(2906002)(31696002)(186003)(8936002)(6916009)(31686004)(5660300002)(66946007)(66556008)(54906003)(6486002)(53546011)(6506007)(6666004)(2616005)(26005)(508600001)(6512007)(82960400001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Znh3QXJWOHdaZ2M5dGlPWi82aTdKRUxRMG80TGswVXJ1VzZLRFMwRGNMeHVm?= =?utf-8?B?MkZTK3FDeHlQbTRhb3BnbEhXZmEyWG1BSU93SnBDZytwb05oeEFadXc3WVFi?= =?utf-8?B?ZXBuQU54K3hiWTJxVXE2VHh6VnFPRWJjN2dLQlVScnZISWxxK3p4NTdhNjE2?= =?utf-8?B?Zm9oQkU0R3NRY2oxbElxRWU4L21sU2xTWkdpbWxPOC9XOGE0MVRjQ2FJTXNS?= =?utf-8?B?VTBRRGQ4ZTdFZFlOTmRQNUZzM2Q4VzMzakg1NmJLNSszTGRTd1FibTRNeGZl?= =?utf-8?B?b3NBU1dtQTZzeEhLbXNGYmxmR1N4d1d4V0gzNFZFaldjSzZZL2F2Z3pLcVRy?= =?utf-8?B?cTA3THlQVWV5UENSN0dNb3B5azhRZ2o5WEV4M0NEb0JKSmF6cE5Sa01EbnNw?= =?utf-8?B?cThJeGNxSkl4anJrQ0xuWXRoc1dJMTQxZTM2eDFxQ2VKTU05VEUzbXRSU1Ji?= =?utf-8?B?NHhtOVNEZndSbk9LZXM1UmhPcXlKb0Fqa2ZsTEJKbzBDcnI0a0tFbFJMN0NV?= =?utf-8?B?dUxrOVZmT05sVW15L3JGV3VjeWRuVG52MTFhaFJONFBOc05DWDRxbnhKc3Fz?= =?utf-8?B?ZjB0QVZ6eGpMUWdzYWkvWnI5QVpSL2RydGhJS2pidFFNOVEyUVhWR09VSTBY?= =?utf-8?B?U1F0VFU5WHFmY0RZbFVoSkhZVkVnVkc4Zld6YlZjU01tSUl6Sk5wcmkxUjQy?= =?utf-8?B?NE03NlcvWDcxRDBZS0NCWXhINEFLSmRTM2xyczV0bGRUenRMaG5USTByNTMr?= =?utf-8?B?YTd3aUhqd2I1OWJiZFQzakNNTC9vRkdDSHkzWlRjeVROTFBQWURXc25lRDBh?= =?utf-8?B?V1RCaWN0UTJQdEtlU2d3eXd6VFpLY1dBMXhwMzJXUTAwN3JwT2ZZWGFCcHJG?= =?utf-8?B?L0pzRFVrRWZTZjBINUZzUVl5NTlJdWpjS2pPYUVuMWZaSXZTb2JFUU1tTm44?= =?utf-8?B?a2hCSGhra1hwaHUzOHdwdjJzMGNzb3hKaGRrOVIyZUJ5TFNXUmF1M05UZytn?= =?utf-8?B?YVEwWXdtSXdCK0hidVRaRUJPSHBrUTlJTlFzRHNpVjErdDNYbmt1R1hrSms0?= =?utf-8?B?MUtjekRoRHdVS0MrMlZaU0tXLzJBZEJheFEwNGFHZnZlQmErY0NqRXpwM1F4?= =?utf-8?B?NG9HVEpLOU9yUElrcXhGQ00vc1c2eGxJUUJJeGNvS2kxK0FvLy9VS1ZxOGJS?= =?utf-8?B?N0ttV1A5QVJNSGQ0dy84OE43Y0ZQWmwyQytDQ3FxRTNDK2k5YzRmUnVWTnpw?= =?utf-8?B?OURtMnNyeFdNM2tSQkp6c1VLR0lnYVFDazlkSE9jS2x2bThEbnozbTFiM3hn?= =?utf-8?B?S3U0Mk9aQ1JvcytBaCtwazR1Q25FUm9McWliejFwd0U3OWVlUm1uS3F2eUd3?= =?utf-8?B?UzVTb1IzSDVtV1VSMXJKNk1GYm43aGhSZWs2ay95bHQxSmV4TFI3YlYybjdr?= =?utf-8?B?a29tdklEZlZxR2F0bWM1UFpncTJvaUFjTXhzeitZc0IxMU12dVZMR1Y4UjV6?= =?utf-8?B?aVE2K2VjN1ltT2JnOURRKzZ1NjErSzg0ZHU5MThjQ1Fma1M0OXQ0bTl0RTkz?= =?utf-8?B?VGVQNE14ZkptRXF0ZDN2NGI3by9Zc0NGK1p3WXE3aFdmbWNmdW5BMUtkcm1o?= =?utf-8?B?b3BzLzRCdWxlR092UnhIY0p4QXdUWWgzVXgzL29RcVdDQkNVTWdpc0hqVGMz?= =?utf-8?B?NWs0RVloeXpNbnBhTW9MK0tna3N3MjZiZjYyOWYxRTVNUXYrRVh0VTE3Q2VR?= =?utf-8?B?TnFLUjVBTWorc0tWUmtZdGFnTlhCeVFaSmY1NnBFQUJPVktwazhHKzh1STM2?= =?utf-8?B?YjFCdnYxYTFBZTdjMW9KUHFZWG10UTRUTm1kMFpQOWpmN1BJV1FqcUdmWmxo?= =?utf-8?B?K0NJdEJnQmpvcmJqYWJXaTVtSEVuWnlSZGJmbVloYUd2bjBKN09aYXdTcmxJ?= =?utf-8?B?U1FGMGtJRG1aWWxHcjN2bXc4QjVlUzNqRE5HdjMxV0FhbjY0UC85Z2VLNWMv?= =?utf-8?B?UTFpRUJYcEtNeDg2Nmt6akdPcDdGZVNXdDNGcEkwd2dZc0xEOUVGbUdpbkZr?= =?utf-8?B?a2pWQnQrTUpRa3hkNkZONFJKeEpqV3BCa1c0OEVkOUEzWGdha0FGNEgvc1RF?= =?utf-8?B?dm14NnJ0QmxBN3JzZjFucCtEZTRyMjhUbFYzWWtneGhCN3lCaDVGM3pLY1ZG?= =?utf-8?Q?ze5OFba9EQf+rsF+TY01YX8=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 54ebfb9b-4d52-4b39-4d7b-08d9f6f80beb X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 18:12:26.5198 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nGOkObiK+SrX2C29z5MRTZTST1qOgkZOLDWrVMzIrptVrSzoUs0V/RwYC78oaVu29gFervCOdtPSMiZBYyOEEg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1604 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/23/2022 5:47 PM, Michał Krawczyk wrote: > śr., 23 lut 2022 o 18:25 Ferruh Yigit napisał(a): >> >> On 2/23/2022 12:19 PM, Michal Krawczyk wrote: >>> Those variables are being set, but never read. As they seem to be >>> leftover from the old offloads API and don't have any purpose right >>> now, they are simply being removed. >>> >> >> It can be good to add fixes tag, both for >> - document in which commit old offload flags because useless >> - backport the change to LTS, I can see the changes don't do >> much but backporting them can help to reduce future conflicts >> for future fixes (cc'ed LTS maintainers for comment) >> > > Good note - I'm ok with adding the fixline. Thanks! > >> If agreed please send the fixes line, I can amend it in next-net. > > Fixes: a4996bd89c42 ("ethdev: new Rx/Tx offloads API") > Cc: stable@dpdk.org > done, thanks.