From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45790) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5aAA-0005xI-9m for qemu-devel@nongnu.org; Wed, 25 May 2016 10:51:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b5aA8-0001an-9o for qemu-devel@nongnu.org; Wed, 25 May 2016 10:51:57 -0400 References: <1464179363-19821-1-git-send-email-kwolf@redhat.com> <1464179363-19821-6-git-send-email-kwolf@redhat.com> From: Max Reitz Message-ID: Date: Wed, 25 May 2016 16:51:46 +0200 MIME-Version: 1.0 In-Reply-To: <1464179363-19821-6-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ll42hOWDXVUW8oTEIKmFXhqumwi38udot" Subject: Re: [Qemu-devel] [PATCH v3 05/15] block: Convert block job core to BlockBackend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: berto@igalia.com, jcody@redhat.com, jsnow@redhat.com, qemu-devel@nongnu.org, eblake@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ll42hOWDXVUW8oTEIKmFXhqumwi38udot From: Max Reitz To: Kevin Wolf , qemu-block@nongnu.org Cc: berto@igalia.com, jcody@redhat.com, jsnow@redhat.com, qemu-devel@nongnu.org, eblake@redhat.com Message-ID: Subject: Re: [PATCH v3 05/15] block: Convert block job core to BlockBackend References: <1464179363-19821-1-git-send-email-kwolf@redhat.com> <1464179363-19821-6-git-send-email-kwolf@redhat.com> In-Reply-To: <1464179363-19821-6-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 25.05.2016 14:29, Kevin Wolf wrote: > This adds a new BlockBackend field to the BlockJob struct, which > coexists with the BlockDriverState while converting the individual jobs= =2E >=20 > When creating a block job, a new BlockBackend is created on top of the > given BlockDriverState, and it is destroyed when the BlockJob ends. The= > reference to the BDS is now held by the BlockBackend instead of calling= > bdrv_ref/unref manually. >=20 > We have to be careful when we use bdrv_replace_in_backing_chain() in > block jobs because this changes the BDS that job->blk points to. At the= > moment block jobs are too tightly coupled with their BDS, so that movin= g > a job to another BDS isn't easily possible; therefore, we need to just > manually undo this change afterwards. >=20 > Signed-off-by: Kevin Wolf > Reviewed-by: Eric Blake > Reviewed-by: Alberto Garcia > --- > block/mirror.c | 3 +++ > blockjob.c | 37 ++++++++++++++++++++----------------- > include/block/blockjob.h | 3 ++- > 3 files changed, 25 insertions(+), 18 deletions(-) Reviewed-by: Max Reitz --ll42hOWDXVUW8oTEIKmFXhqumwi38udot Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXRbwCAAoJEDuxQgLoOKytcu4H/i4Pch2JTlVXoWYjm5YH2OBp +q1vBfal3ZjAOpVN+AYX5zv9GEqBfieCpQx/3Y2FOlm6F2d35EJApx0Zjn8EkNgW WmNTURhBHfcBHv4PGC+pHeiMo25Q588gzxs/vk8z3WXPiQv5BgIoQKpvc7GxmwWm mxlwOTJ33j2ewPeHPEWTnCyak2YZQij0vj6HjYs1d2go0oOKmNzyPz2dNn/pb1WF v/qAS4k46uNdl9zfiibspjVA0bVhB0709ZNNcMg4POdubiZValCwxRTplmxuzs4S 4itKOXz85+oZ+0VErBIHUC/TLSrPYt+oB/geGk8/jC7tskYFaTz0x4KRgLseXMM= =Icr/ -----END PGP SIGNATURE----- --ll42hOWDXVUW8oTEIKmFXhqumwi38udot--