From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932511AbcHIV4X (ORCPT ); Tue, 9 Aug 2016 17:56:23 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:36524 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932338AbcHIV4V (ORCPT ); Tue, 9 Aug 2016 17:56:21 -0400 Subject: Re: [RFCv2][PATCH 2/5] arm: Implement ARCH_HAS_FORCE_CACHE To: Laura Abbott , Sumit Semwal , John Stultz , =?UTF-8?Q?Arve_Hj=c3=b8nnev=c3=a5g?= , Riley Andrews References: <1470678577-14010-1-git-send-email-labbott@redhat.com> <1470678577-14010-3-git-send-email-labbott@redhat.com> Cc: devel@driverdev.osuosl.org, Jon Medhurst , Android Kernel Team , Greg Kroah-Hartman , Daniel Vetter , Will Deacon , Russell King , linux-kernel@vger.kernel.org, linaro-mm-sig@lists.linaro.org, Rohit kumar , Bryan Huntsman , Jeremy Gebben , Eun Taik Lee , Catalin Marinas , Liviu Dudau , Mitchel Humpherys , linux-arm-kernel@lists.infradead.org From: Florian Fainelli Message-ID: Date: Tue, 9 Aug 2016 14:56:17 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1470678577-14010-3-git-send-email-labbott@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/08/2016 10:49 AM, Laura Abbott wrote: > arm may need the kernel_force_cache APIs to guarantee data consistency. > Implement versions of these APIs based on the DMA APIs. > > Signed-off-by: Laura Abbott > --- > arch/arm/include/asm/cacheflush.h | 4 ++ > arch/arm/mm/dma-mapping.c | 119 -------------------------------------- > arch/arm/mm/flush.c | 115 ++++++++++++++++++++++++++++++++++++ Why is the code moved between dma-mapping.c and flush.c? It was not obvious while looking at these patches why this is needed. -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 From: f.fainelli@gmail.com (Florian Fainelli) Date: Tue, 9 Aug 2016 14:56:17 -0700 Subject: [RFCv2][PATCH 2/5] arm: Implement ARCH_HAS_FORCE_CACHE In-Reply-To: <1470678577-14010-3-git-send-email-labbott@redhat.com> References: <1470678577-14010-1-git-send-email-labbott@redhat.com> <1470678577-14010-3-git-send-email-labbott@redhat.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 08/08/2016 10:49 AM, Laura Abbott wrote: > arm may need the kernel_force_cache APIs to guarantee data consistency. > Implement versions of these APIs based on the DMA APIs. > > Signed-off-by: Laura Abbott > --- > arch/arm/include/asm/cacheflush.h | 4 ++ > arch/arm/mm/dma-mapping.c | 119 -------------------------------------- > arch/arm/mm/flush.c | 115 ++++++++++++++++++++++++++++++++++++ Why is the code moved between dma-mapping.c and flush.c? It was not obvious while looking at these patches why this is needed. -- Florian