From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754263AbdLHPme (ORCPT ); Fri, 8 Dec 2017 10:42:34 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:51669 "EHLO huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1753760AbdLHPmc (ORCPT ); Fri, 8 Dec 2017 10:42:32 -0500 Subject: Re: [RFC PATCH 2/5] perf jevents: add support for arch recommended events To: Jiri Olsa References: <1512490399-94107-1-git-send-email-john.garry@huawei.com> <1512490399-94107-3-git-send-email-john.garry@huawei.com> <20171206133607.GA12508@krava> <20171208122918.GE2799@krava> CC: , , , , , , , , , , , , , , , From: John Garry Message-ID: Date: Fri, 8 Dec 2017 15:42:10 +0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20171208122918.GE2799@krava> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.238] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/12/2017 12:29, Jiri Olsa wrote: > On Wed, Dec 06, 2017 at 03:20:14PM +0000, John Garry wrote: >> On 06/12/2017 13:36, Jiri Olsa wrote: >>> On Wed, Dec 06, 2017 at 12:13:16AM +0800, John Garry wrote: >>>> For some architectures (like arm64), there are architecture- >>>> defined recommended events. Vendors may not be obliged to >>>> follow the recommendation and may implement their own pmu >>>> event for a specific event code. >>>> >>>> This patch adds support for parsing events from arch-defined >>>> recommended JSONs, and then fixing up vendor events when >>>> they have implemented these events as recommended. >>> >>> in the previous patch you added the vendor support, so >>> you have arch|vendor|platform key for the event list >>> and perf have the most current/local event list >>> >>> why would you need to fix it? if there's new event list, >>> the table gets updated, perf is rebuilt.. I'm clearly >>> missing something ;-) >> >> The 2 patches are quite separate. In the first patch, I just added support >> for the vendor subdirectory. >> >> So this patch is not related to rebuilding when adding a new event list or >> dependency checking. >> >> Here we are trying to allow the vendor to just specify that an event is >> supported as standard in their platform, without duplicating all the >> standard event fields in their JSON. When processing the vendor JSONs, the >> jevents tool can figure which events are standard and create the proper >> event entries in the pmu events table, referencing the architecture JSON. > Hi jirka, > I think we should keep this simple and mangle this with some pointer logic > > now you have arch/vendor/platform directory structure.. I'm glad that there seems to be no objection to this, as I feel that this was a problem. why don't > you add events for every such directory? I understand there will > be duplications, but we already have them for other archs and it's > not big deal: The amount of duplication was the concern. As mentioned earlier, it would be anticipated that every vendor would implement these events as recommended, so a copy for every platform from every vendor. We're looking for a way to avoid this. Actually having a scalable JSON standard format for pmu events, which allows us to define common events per architecture / vendor and reference them per platform JSON could be useful. Here we're dealing with trade-off between duplication (simplicity) vs complexity (or over-engineering). > > [jolsa@krava perf]$ grep -r L2_RQSTS.DEMAND_DATA_RD_MISS pmu-events/arch/* > pmu-events/arch/x86/broadwell/cache.json: "EventName": "L2_RQSTS.DEMAND_DATA_RD_MISS", > pmu-events/arch/x86/haswell/cache.json: "EventName": "L2_RQSTS.DEMAND_DATA_RD_MISS", > pmu-events/arch/x86/broadwellde/cache.json: "EventName": "L2_RQSTS.DEMAND_DATA_RD_MISS", > pmu-events/arch/x86/haswellx/cache.json: "EventName": "L2_RQSTS.DEMAND_DATA_RD_MISS", > pmu-events/arch/x86/skylake/cache.json: "EventName": "L2_RQSTS.DEMAND_DATA_RD_MISS", > pmu-events/arch/x86/skylakex/cache.json: "EventName": "L2_RQSTS.DEMAND_DATA_RD_MISS", > pmu-events/arch/x86/broadwellx/cache.json: "EventName": "L2_RQSTS.DEMAND_DATA_RD_MISS", > > thanks, > jirka Cheers, John > > . > From mboxrd@z Thu Jan 1 00:00:00 1970 From: john.garry@huawei.com (John Garry) Date: Fri, 8 Dec 2017 15:42:10 +0000 Subject: [RFC PATCH 2/5] perf jevents: add support for arch recommended events In-Reply-To: <20171208122918.GE2799@krava> References: <1512490399-94107-1-git-send-email-john.garry@huawei.com> <1512490399-94107-3-git-send-email-john.garry@huawei.com> <20171206133607.GA12508@krava> <20171208122918.GE2799@krava> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 08/12/2017 12:29, Jiri Olsa wrote: > On Wed, Dec 06, 2017 at 03:20:14PM +0000, John Garry wrote: >> On 06/12/2017 13:36, Jiri Olsa wrote: >>> On Wed, Dec 06, 2017 at 12:13:16AM +0800, John Garry wrote: >>>> For some architectures (like arm64), there are architecture- >>>> defined recommended events. Vendors may not be obliged to >>>> follow the recommendation and may implement their own pmu >>>> event for a specific event code. >>>> >>>> This patch adds support for parsing events from arch-defined >>>> recommended JSONs, and then fixing up vendor events when >>>> they have implemented these events as recommended. >>> >>> in the previous patch you added the vendor support, so >>> you have arch|vendor|platform key for the event list >>> and perf have the most current/local event list >>> >>> why would you need to fix it? if there's new event list, >>> the table gets updated, perf is rebuilt.. I'm clearly >>> missing something ;-) >> >> The 2 patches are quite separate. In the first patch, I just added support >> for the vendor subdirectory. >> >> So this patch is not related to rebuilding when adding a new event list or >> dependency checking. >> >> Here we are trying to allow the vendor to just specify that an event is >> supported as standard in their platform, without duplicating all the >> standard event fields in their JSON. When processing the vendor JSONs, the >> jevents tool can figure which events are standard and create the proper >> event entries in the pmu events table, referencing the architecture JSON. > Hi jirka, > I think we should keep this simple and mangle this with some pointer logic > > now you have arch/vendor/platform directory structure.. I'm glad that there seems to be no objection to this, as I feel that this was a problem. why don't > you add events for every such directory? I understand there will > be duplications, but we already have them for other archs and it's > not big deal: The amount of duplication was the concern. As mentioned earlier, it would be anticipated that every vendor would implement these events as recommended, so a copy for every platform from every vendor. We're looking for a way to avoid this. Actually having a scalable JSON standard format for pmu events, which allows us to define common events per architecture / vendor and reference them per platform JSON could be useful. Here we're dealing with trade-off between duplication (simplicity) vs complexity (or over-engineering). > > [jolsa at krava perf]$ grep -r L2_RQSTS.DEMAND_DATA_RD_MISS pmu-events/arch/* > pmu-events/arch/x86/broadwell/cache.json: "EventName": "L2_RQSTS.DEMAND_DATA_RD_MISS", > pmu-events/arch/x86/haswell/cache.json: "EventName": "L2_RQSTS.DEMAND_DATA_RD_MISS", > pmu-events/arch/x86/broadwellde/cache.json: "EventName": "L2_RQSTS.DEMAND_DATA_RD_MISS", > pmu-events/arch/x86/haswellx/cache.json: "EventName": "L2_RQSTS.DEMAND_DATA_RD_MISS", > pmu-events/arch/x86/skylake/cache.json: "EventName": "L2_RQSTS.DEMAND_DATA_RD_MISS", > pmu-events/arch/x86/skylakex/cache.json: "EventName": "L2_RQSTS.DEMAND_DATA_RD_MISS", > pmu-events/arch/x86/broadwellx/cache.json: "EventName": "L2_RQSTS.DEMAND_DATA_RD_MISS", > > thanks, > jirka Cheers, John > > . >