From: Bart Van Assche <bvanassche@acm.org>
To: Daniel Wagner <dwagner@suse.de>, linux-block@vger.kernel.org
Cc: Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH] blk-mq: Update blk_mq_map_queue() documentation
Date: Thu, 6 Feb 2020 19:56:42 -0800 [thread overview]
Message-ID: <afd91072-ca4f-52d7-3bad-e46f20a19d18@acm.org> (raw)
In-Reply-To: <20200206175005.7426-1-dwagner@suse.de>
On 2020-02-06 09:50, Daniel Wagner wrote:
> Commit 8ccdf4a37752 ("blk-mq: save queue mapping result into ctx
> directly") changed the last argument name from cpu to ctx but missed
> to update the documentation.
>
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> ---
> block/blk-mq.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/blk-mq.h b/block/blk-mq.h
> index eaaca8fc1c28..76921a970c32 100644
> --- a/block/blk-mq.h
> +++ b/block/blk-mq.h
> @@ -97,7 +97,7 @@ static inline struct blk_mq_hw_ctx *blk_mq_map_queue_type(struct request_queue *
> * blk_mq_map_queue() - map (cmd_flags,type) to hardware queue
> * @q: request queue
> * @flags: request command flags
> - * @cpu: cpu ctx
> + * @ctx: software queue state
> */
> static inline struct blk_mq_hw_ctx *blk_mq_map_queue(struct request_queue *q,
> unsigned int flags,
Just "software queue" instead of "software queue state" probably would
have been more clear. I think that's the name that is used elsewhere in
the block layer. Anyway:
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
prev parent reply other threads:[~2020-02-07 3:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 17:50 [PATCH] blk-mq: Update blk_mq_map_queue() documentation Daniel Wagner
2020-02-07 3:56 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afd91072-ca4f-52d7-3bad-e46f20a19d18@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=dwagner@suse.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.