All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.com>
To: linux-btrfs@vger.kernel.org
Cc: David Sterba <dsterba@suse.com>
Subject: [PATCH 13/16] btrfs: remove redundant read-only check from btrfs_cancel_balance
Date: Tue,  3 Apr 2018 20:34:31 +0200	[thread overview]
Message-ID: <afdb0e99249c050b26a200ccbbc772a1ef90c1a4.1522780026.git.dsterba@suse.com> (raw)
In-Reply-To: <cover.1522780026.git.dsterba@suse.com>

Balance cannot be started on a read-only filesystem and will have to
finish/exit before eg. going to read-only via remount. Cancelling does
not need to check for that.

In case the filesystem is forcibly set to read-only after an error,
balance will finish anyway and if the cancel call is too fast it will
just wait for that to happen. Again does not have to check.

Signed-off-by: David Sterba <dsterba@suse.com>
---
 fs/btrfs/volumes.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index a0420af1fad9..2956e7b4cb9f 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -4053,9 +4053,6 @@ int btrfs_pause_balance(struct btrfs_fs_info *fs_info)
 
 int btrfs_cancel_balance(struct btrfs_fs_info *fs_info)
 {
-	if (sb_rdonly(fs_info->sb))
-		return -EROFS;
-
 	mutex_lock(&fs_info->balance_mutex);
 	if (!fs_info->balance_ctl) {
 		mutex_unlock(&fs_info->balance_mutex);
-- 
2.16.2


  parent reply	other threads:[~2018-04-03 18:36 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-03 18:34 [PATCH 00/16 v1] Kill fs_info::volume_mutex David Sterba
2018-04-03 18:34 ` [PATCH 01/16] btrfs: squeeze btrfs_dev_replace_continue_on_mount to its caller David Sterba
2018-04-05  9:40   ` Anand Jain
2018-04-03 18:34 ` [PATCH 02/16] btrfs: make success path out of btrfs_init_dev_replace_tgtdev more clear David Sterba
2018-04-05  9:40   ` Anand Jain
2018-04-03 18:34 ` [PATCH 03/16] btrfs: export and rename free_device David Sterba
2018-04-05  9:41   ` Anand Jain
2018-04-03 18:34 ` [PATCH 04/16] btrfs: move btrfs_init_dev_replace_tgtdev to dev-replace.c and make static David Sterba
2018-04-05  9:41   ` Anand Jain
2018-04-03 18:34 ` [PATCH 05/16] btrfs: move volume_mutex to callers of btrfs_rm_device David Sterba
2018-04-05  9:41   ` Anand Jain
2018-04-05 14:28     ` David Sterba
2018-04-03 18:34 ` [PATCH 06/16] btrfs: move clearing of EXCL_OP out of __cancel_balance David Sterba
2018-04-05  9:42   ` Anand Jain
2018-04-05 14:04     ` David Sterba
2018-04-03 18:34 ` [PATCH 07/16] btrfs: add proper safety check before resuming dev-replace David Sterba
2018-04-06 20:06   ` Sasha Levin
2018-04-07  6:42   ` Anand Jain
2018-04-07 10:43     ` Anand Jain
2018-04-09 11:43       ` David Sterba
2018-04-03 18:34 ` [PATCH 08/16] btrfs: add sanity check when resuming balance after mount David Sterba
2018-04-06 20:06   ` Sasha Levin
2018-04-09  7:23   ` Anand Jain
2018-04-16  6:10   ` Anand Jain
2018-04-17 17:38     ` David Sterba
2018-04-03 18:34 ` [PATCH 09/16] btrfs: cleanup helpers that reset balance state David Sterba
2018-04-09  7:43   ` Anand Jain
2018-04-03 18:34 ` [PATCH 10/16] btrfs: remove wrong use of volume_mutex from btrfs_dev_replace_start David Sterba
2018-04-09  8:39   ` Anand Jain
2018-04-09  8:54     ` Nikolay Borisov
2018-04-09  9:31       ` Anand Jain
2018-04-09 11:53     ` David Sterba
2018-04-09 14:44       ` Anand Jain
2018-04-09 14:55   ` Anand Jain
2018-04-03 18:34 ` [PATCH 11/16] btrfs: kill btrfs_fs_info::volume_mutex David Sterba
2018-04-09 14:52   ` Anand Jain
2018-04-13  5:30   ` Anand Jain
2018-04-13 13:15     ` David Sterba
2018-04-03 18:34 ` [PATCH 12/16] btrfs: track running balance in a simpler way David Sterba
2018-04-03 18:34 ` David Sterba [this message]
2018-04-16  9:43   ` [PATCH 13/16] btrfs: remove redundant read-only check from btrfs_cancel_balance Anand Jain
2018-04-17 17:47     ` David Sterba
2018-04-03 18:34 ` [PATCH 14/16] btrfs: drop lock parameter from update_ioctl_balance_args and rename David Sterba
2018-04-03 18:34 ` [PATCH 15/16] btrfs: use mutex in btrfs_resume_balance_async David Sterba
2018-04-03 18:34 ` [PATCH 16/16] btrfs: open code set_balance_control David Sterba
2018-04-09 15:24   ` Anand Jain
2018-04-05 14:31 ` [PATCH 00/16 v1] Kill fs_info::volume_mutex David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=afdb0e99249c050b26a200ccbbc772a1ef90c1a4.1522780026.git.dsterba@suse.com \
    --to=dsterba@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.