Re: [PATCH v4 2/3] display/blizzard: Remove redundant statement in blizzard_draw_line16_32()

From: Laurent Vivier <laurent@vivier.eu>
To: Chen Qun <kuhn.chenqun@huawei.com>,
	qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	philmd@redhat.com, zhang.zhanghailiang@huawei.com,
	Euler Robot <euler.robot@huawei.com>
Subject: Re: [PATCH v4 2/3] display/blizzard: Remove redundant statement in blizzard_draw_line16_32()
Date: Tue, 24 Mar 2020 09:38:59 +0100	[thread overview]
Message-ID: <aff5ca8a-af20-a3ba-4354-5c203a9eea81@vivier.eu> (raw)
In-Reply-To: <20200324082235.27980-3-kuhn.chenqun@huawei.com>

Le 24/03/2020 à 09:22, Chen Qun a écrit :
> Clang static code analyzer show warning:
>   hw/display/blizzard.c:940:9: warning: Value stored to 'data' is never read
>         data >>= 5;
>         ^        ~
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
> ---
> Cc: Andrzej Zaborowski <balrogg@gmail.com>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> ---
>  hw/display/blizzard.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/hw/display/blizzard.c b/hw/display/blizzard.c
> index 359e399c2a..62517bdf75 100644
> --- a/hw/display/blizzard.c
> +++ b/hw/display/blizzard.c
> @@ -937,7 +937,6 @@ static void blizzard_draw_line16_32(uint32_t *dest,
>          g = (data & 0x3f) << 2;
>          data >>= 6;
>          r = (data & 0x1f) << 3;
> -        data >>= 5;
>          *dest++ = rgb_to_pixel32(r, g, b);
>      }
>  }
> 

Perhaps it would be clearer to use extract32() to compute r, g and b?

Thanks,
Laurent