From mboxrd@z Thu Jan  1 00:00:00 1970
From: Heinrich Schuchardt <xypron.glpk@gmx.de>
Date: Mon, 22 Feb 2021 20:03:38 +0100
Subject: [PATCH 1/2] Re-embed the FDTs for the Malta targets.
In-Reply-To: <20210222170512.22601-2-reinoud@NetBSD.org>
References: <20210222170512.22601-1-reinoud@NetBSD.org>
 <20210222170512.22601-2-reinoud@NetBSD.org>
Message-ID: <aff6204b-1e92-6b90-d1f7-41e05bd90db4@gmx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de



On 2/22/21 6:05 PM, Reinoud Zandijk wrote:

Please, provide a commit message and a Signed-by line.

> ---
>   configs/malta64_defconfig   | 1 +
>   configs/malta64el_defconfig | 1 +
>   configs/malta_defconfig     | 1 +
>   configs/maltael_defconfig   | 1 +
>   4 files changed, 4 insertions(+)
>
> diff --git a/configs/malta64_defconfig b/configs/malta64_defconfig
> index 878dc6ee05..106c890faa 100644
> --- a/configs/malta64_defconfig
> +++ b/configs/malta64_defconfig
> @@ -21,6 +21,7 @@ CONFIG_CMD_DHCP=y
>   CONFIG_CMD_PING=y
>   CONFIG_CMD_DATE=y
>   # CONFIG_ISO_PARTITION is not set
> +CONFIG_OF_EMBED=y
>   CONFIG_ENV_IS_IN_FLASH=y
>   CONFIG_ENV_ADDR=0xFFFFFFFFBE3E0000
>   CONFIG_MTD_NOR_FLASH=y
> diff --git a/configs/malta64el_defconfig b/configs/malta64el_defconfig
> index 7dfe67355f..e61d61b26b 100644
> --- a/configs/malta64el_defconfig
> +++ b/configs/malta64el_defconfig
> @@ -23,6 +23,7 @@ CONFIG_CMD_DHCP=y
>   CONFIG_CMD_PING=y
>   CONFIG_CMD_DATE=y
>   # CONFIG_ISO_PARTITION is not set
> +CONFIG_OF_EMBED=y
>   CONFIG_ENV_IS_IN_FLASH=y
>   CONFIG_ENV_ADDR=0xFFFFFFFFBE3E0000
>   CONFIG_MTD_NOR_FLASH=y
> diff --git a/configs/malta_defconfig b/configs/malta_defconfig
> index 304f2198ba..c1dfa357d2 100644
> --- a/configs/malta_defconfig
> +++ b/configs/malta_defconfig
> @@ -20,6 +20,7 @@ CONFIG_CMD_DHCP=y
>   CONFIG_CMD_PING=y
>   CONFIG_CMD_DATE=y
>   # CONFIG_ISO_PARTITION is not set
> +CONFIG_OF_EMBED=y

This should not be used in a defconfig.

dts/Kconfig:83:

"Boards in the mainline U-Boot tree should not use it."

Best regards

Heinrich

>   CONFIG_ENV_IS_IN_FLASH=y
>   CONFIG_ENV_ADDR=0xBE3E0000
>   CONFIG_MTD_NOR_FLASH=y
> diff --git a/configs/maltael_defconfig b/configs/maltael_defconfig
> index 7436e4e943..0a8badcb84 100644
> --- a/configs/maltael_defconfig
> +++ b/configs/maltael_defconfig
> @@ -22,6 +22,7 @@ CONFIG_CMD_DHCP=y
>   CONFIG_CMD_PING=y
>   CONFIG_CMD_DATE=y
>   # CONFIG_ISO_PARTITION is not set
> +CONFIG_OF_EMBED=y
>   CONFIG_ENV_IS_IN_FLASH=y
>   CONFIG_ENV_ADDR=0xBE3E0000
>   CONFIG_MTD_NOR_FLASH=y
>