From: Jan Beulich <jbeulich@suse.com>
To: "Roger Pau Monné" <roger.pau@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
George Dunlap <George.Dunlap@eu.citrix.com>
Subject: Re: [PATCH 2/3] x86/shim: adjust Kconfig defaults
Date: Tue, 15 Sep 2020 14:15:46 +0200 [thread overview]
Message-ID: <affb0372-38ba-4a83-b736-5d9436195f32@suse.com> (raw)
In-Reply-To: <20200915104939.GJ753@Air-de-Roger>
On 15.09.2020 12:49, Roger Pau Monné wrote:
> On Mon, Sep 14, 2020 at 02:39:08PM +0200, Jan Beulich wrote:
>> Just like HVM, defaulting SHADOW_PAGING and TBOOT to Yes in shim-
>> exclusive mode makes no sense, as the respective code is dead there.
>>
>> Also adjust the shim default config file: It needs to specifiy values
>> only for settings where a non-default value is wanted.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
Thanks.
>> --- a/xen/arch/x86/Kconfig
>> +++ b/xen/arch/x86/Kconfig
>> @@ -116,9 +116,9 @@ config XEN_SHSTK
>> compatiblity can be provided via the PV Shim mechanism.
>>
>> config SHADOW_PAGING
>> - bool "Shadow Paging"
>> - default y
>> - ---help---
>> + bool "Shadow Paging"
>> + default y if !PV_SHIM_EXCLUSIVE
>
> I think you could also do: default !PV_SHIM_EXCLUSIVE?
Oh, yes, in this case I can indeed. I've mechanically used the form
wanted when the prompt isn't unconditionally visible. Will switch.
Jan
next prev parent reply other threads:[~2020-09-15 12:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 12:37 [PATCH 0/3] x86: shim building adjustments Jan Beulich
2020-09-14 12:38 ` [PATCH 1/3] x86/shim: fix build with PV_SHIM_EXCLUSIVE and SHADOW_PAGING Jan Beulich
2020-09-14 16:44 ` Roger Pau Monné
2020-09-15 8:00 ` Jan Beulich
2020-09-14 12:39 ` [PATCH 2/3] x86/shim: adjust Kconfig defaults Jan Beulich
2020-09-15 10:49 ` Roger Pau Monné
2020-09-15 12:15 ` Jan Beulich [this message]
2020-09-14 12:39 ` [PATCH 3/3] x86/shim: don't permit HVM and PV_SHIM_EXCLUSIVE at the same time Jan Beulich
2020-09-15 11:02 ` Roger Pau Monné
2020-09-15 12:19 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=affb0372-38ba-4a83-b736-5d9436195f32@suse.com \
--to=jbeulich@suse.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.