From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:38452) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1grsuW-0002yk-7A for qemu-devel@nongnu.org; Thu, 07 Feb 2019 18:16:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1grsuV-0003B4-Ec for qemu-devel@nongnu.org; Thu, 07 Feb 2019 18:16:48 -0500 Received: from zero.eik.bme.hu ([152.66.115.2]:40479) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1grsuU-00035f-Uk for qemu-devel@nongnu.org; Thu, 07 Feb 2019 18:16:47 -0500 Date: Fri, 8 Feb 2019 00:16:38 +0100 (CET) From: BALATON Zoltan In-Reply-To: <1549562254-41157-34-git-send-email-pbonzini@redhat.com> Message-ID: References: <1549562254-41157-1-git-send-email-pbonzini@redhat.com> <1549562254-41157-34-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Subject: Re: [Qemu-devel] [PATCH 33/51] ppc: Express dependencies of the Sam460EX machines with kconfig List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, thuth@redhat.com, philmd@redhat.com On Thu, 7 Feb 2019, Paolo Bonzini wrote: > From: Thomas Huth > > Most of the dependencies are now directly selected by the SAM460EX > switch. We can drop CONFIG_VGA_CIRRUS since this device is already > selected automatically when CONFIG_PCI_DEVICES is set. > > Reviewed-by: BALATON Zoltan > Reviewed-by: Paolo Bonzini > Signed-off-by: Thomas Huth > Signed-off-by: Paolo Bonzini > --- > default-configs/ppc-softmmu.mak | 8 -------- > hw/display/Kconfig | 1 + > hw/ppc/Kconfig | 11 +++++++++++ > 3 files changed, 12 insertions(+), 8 deletions(-) > > diff --git a/default-configs/ppc-softmmu.mak b/default-configs/ppc-softmmu.mak > index caaff60..fb43cba 100644 > --- a/default-configs/ppc-softmmu.mak > +++ b/default-configs/ppc-softmmu.mak > @@ -25,14 +25,6 @@ CONFIG_PCI_EXPRESS=y > > # For Sam460ex > CONFIG_SAM460EX=y > -CONFIG_USB_EHCI_SYSBUS=y > -CONFIG_SM501=y > -CONFIG_IDE_SII3112=y > -CONFIG_AT24C=y > -CONFIG_BITBANG_I2C=y > -CONFIG_M41T80=y > -CONFIG_VGA_CIRRUS=y > -CONFIG_SMBUS_EEPROM=y > > # For Macs > CONFIG_MAC_OLDWORLD=y > diff --git a/hw/display/Kconfig b/hw/display/Kconfig > index 0f659e9..69f8a7e 100644 > --- a/hw/display/Kconfig > +++ b/hw/display/Kconfig > @@ -29,6 +29,7 @@ config SII9022 > config SSD0303 > bool > depends on I2C > + select DDC What's SSD0303? It's not something sam460ex needs. Are you sure this hunk belongs to this patch? Regards, BALATON Zoltan > > config SSD0323 > bool > diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig > index fb77151..664fc31 100644 > --- a/hw/ppc/Kconfig > +++ b/hw/ppc/Kconfig > @@ -33,9 +33,20 @@ config PPC440 > > config PPC4XX > bool > + select BITBANG_I2C > + select PCI > > config SAM460EX > bool > + select PFLASH_CFI01 > + select IDE_SII3112 > + select M41T80 > + select PPC440 > + select SERIAL > + select SM501 > + select SMBUS_EEPROM > + select USB_EHCI_SYSBUS > + select USB_OHCI > > config PREP > bool >