From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:40538) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3QxI-00049A-75 for qemu-devel@nongnu.org; Mon, 11 Mar 2019 15:51:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h3QxG-0003Sd-E3 for qemu-devel@nongnu.org; Mon, 11 Mar 2019 15:51:24 -0400 Received: from zero.eik.bme.hu ([152.66.115.2]:25670) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h3QxE-0003GT-FD for qemu-devel@nongnu.org; Mon, 11 Mar 2019 15:51:21 -0400 Date: Mon, 11 Mar 2019 20:51:18 +0100 (CET) From: BALATON Zoltan In-Reply-To: <87ef7d8fh8.fsf@dusky.pond.sub.org> Message-ID: References: <20190311085024.13780-1-kraxel@redhat.com> <20190311085024.13780-5-kraxel@redhat.com> <87ef7d8fh8.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Subject: Re: [Qemu-devel] [PULL 4/5] hw/display: Add basic ATI VGA emulation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Gerd Hoffmann , qemu-devel@nongnu.org, Paolo Bonzini , Stefan Hajnoczi , "Daniel P. Berrange" On Mon, 11 Mar 2019, Markus Armbruster wrote: > Gerd Hoffmann writes: >> From: BALATON Zoltan >> >> At least two machines, the PPC mac99 and MIPS fulong2e, have an ATI >> gfx chip by default (Rage 128 Pro and M6/RV100 respectively) and >> guests running on these and the PMON2000 firmware of the fulong2e >> expect this to be available. Fortunately these are very similar chips >> so they can be mostly emulated in the same device model. This patch >> adds basic emulation of these ATI VGA chips. >> >> While this is incomplete and currently only enough to run the MIPS >> firmware and get framebuffer output with Linux, it allows the fulong2e >> board to work more like the real hardware and having it in QEMU in >> this state provides a way to experiment with it and allows others to >> contribute to improve it. It is compiled for all archs but only the >> fulong2e (which currently has no display output at all) is set to use >> it by default (in a separate patch). >> >> Signed-off-by: BALATON Zoltan >> Acked-by: Aleksandar Markovic >> Tested-by: Andrew Randrianasulu >> Tested-by: Howard Spoelstra >> Message-id: 0b1b7c22873a6e37627261b04fb687412b25ff4f.1552152100.git.balaton@eik.bme.hu >> Signed-off-by: Gerd Hoffmann > [...] >> diff --git a/hw/display/trace-events b/hw/display/trace-events >> index 37d3264bb2e6..80993cc4d913 100644 >> --- a/hw/display/trace-events >> +++ b/hw/display/trace-events >> @@ -138,3 +138,7 @@ vga_cirrus_write_blt(uint32_t offset, uint32_t val) "offset 0x%x, val 0x%x" >> sii9022_read_reg(uint8_t addr, uint8_t val) "addr 0x%02x, val 0x%02x" >> sii9022_write_reg(uint8_t addr, uint8_t val) "addr 0x%02x, val 0x%02x" >> sii9022_switch_mode(const char *mode) "mode: %s" >> + >> +# hw/display/ati*.c >> +ati_mm_read(unsigned int size, uint64_t addr, const char *name, uint64_t val) "%u 0x%"HWADDR_PRIx " %s -> 0x%"PRIx64 >> +ati_mm_write(unsigned int size, uint64_t addr, const char *name, uint64_t val) "%u 0x%"HWADDR_PRIx " %s <- 0x%"PRIx64 > > Blows up for me: > > Traceback (most recent call last): > File "/work/armbru/qemu/scripts/tracetool.py", line 152, in > main(sys.argv) > File "/work/armbru/qemu/scripts/tracetool.py", line 147, in main > binary=binary, probe_prefix=probe_prefix) > File "/work/armbru/qemu/scripts/tracetool/__init__.py", line 472, in generate > tracetool.format.generate(events, format, backend, group) > File "/work/armbru/qemu/scripts/tracetool/format/__init__.py", line 85, in generate > func(events, backend, group) > File "/work/armbru/qemu/scripts/tracetool/format/log_stap.py", line 121, in generate > fmt_str = "%d@%d " + e.name + " " + c_fmt_to_stap(e.fmt) + "\\n" > File "/work/armbru/qemu/scripts/tracetool/format/log_stap.py", line 64, in c_fmt_to_stap > bits.append(c_macro_to_format(macro)) > File "/work/armbru/qemu/scripts/tracetool/format/log_stap.py", line 36, in c_macro_to_format > raise Exception("Unhandled macro '%s'" % macro) > Exception: Unhandled macro 'HWADDR_PRIx' No idea. Nobody else reported a problem with this yet and the above error makes no sense to me. Cc'd some tracetool related people who hopefully can hint what might be wrong. Do you get error during build? What trace backend do you use? Regards, BALATON Zoltan