Re: Looking for issues/features for my first contribution

From: BALATON Zoltan <balaton@eik.bme.hu>
To: Aleksandar Markovic <aleksandar.m.mail@gmail.com>
Cc: Rajath Shashidhara <rajaths@cs.utexas.edu>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: Looking for issues/features for my first contribution
Date: Fri, 8 Nov 2019 22:54:38 +0100 (CET)	[thread overview]
Message-ID: <alpine.BSF.2.21.99999.352.1911082238100.43546@zero.eik.bme.hu> (raw)
In-Reply-To: <CAL1e-=iCJntxh3r05kJgKnARV=EsREL9rMKG6JZSTi-QGY9mZg@mail.gmail.com>

Hello,

On Fri, 8 Nov 2019, Aleksandar Markovic wrote:
>> [c] DS3231 also has programmable square-wave output + 32 KHz output pin.
>> M41T80 chip also supports this feature. However, qemu does not support
>> emulation of these features [2]. Do I take the same approach ?
>
> Hi, Rajath.
>
> I would rather have you amend M41T80, if there is a missing functionality.
>
> cc-in Zoltan the creator of M41T80 emulation, for his opinion.

The missing functionality (such as alarm timer, if I remember correctly) 
could be added, but I did not bother to fully implement it because the 
clients I was interested in only used the RTC part, so current 
implementation is sufficient for that. Not sure if anything would use the 
missing features but it would be nice to fully implement the chip.

I'm not sure what you plan to use DS3231 for but if clients only use part 
of the functions then maybe implementing those first might be enough but 
if you have time to correctly implement everything then that's probably 
even better.

If you or someone else is still looking for a relatively easy device to 
implement I have this:

https://osdn.net/projects/qmiga/wiki/SubprojectMac99I2C

The difficulty in that is that it has no docs but only open source drivers 
to figure out how it works but if someone likes a challenge it may improve 
mac99 emulation.

Regards,
BALATON Zoltan