From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE75FC433E0 for ; Sat, 16 May 2020 15:34:25 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A4B4D2065C for ; Sat, 16 May 2020 15:34:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A4B4D2065C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=eik.bme.hu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47990 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZypU-0003Kz-TL for qemu-devel@archiver.kernel.org; Sat, 16 May 2020 11:34:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37032) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZyog-0002sH-RN for qemu-devel@nongnu.org; Sat, 16 May 2020 11:33:34 -0400 Received: from zero.eik.bme.hu ([152.66.115.2]:44659) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZyoe-0006AJ-Gc for qemu-devel@nongnu.org; Sat, 16 May 2020 11:33:33 -0400 Received: from zero.eik.bme.hu (blah.eik.bme.hu [152.66.115.182]) by localhost (Postfix) with SMTP id 4CAA374594E; Sat, 16 May 2020 17:33:29 +0200 (CEST) Received: by zero.eik.bme.hu (Postfix, from userid 432) id 2D3A6745712; Sat, 16 May 2020 17:33:29 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by zero.eik.bme.hu (Postfix) with ESMTP id 2B8B9745702; Sat, 16 May 2020 17:33:29 +0200 (CEST) Date: Sat, 16 May 2020 17:33:29 +0200 (CEST) From: BALATON Zoltan To: Alexander Bulekov Subject: Re: [PATCH] ati-vga: Do not allow unaligned access via index register In-Reply-To: <20200516144706.zz54mgs7k7anq3cj@mozz.bu.edu> Message-ID: References: <20200516132352.39E9374594E@zero.eik.bme.hu> <20200516144706.zz54mgs7k7anq3cj@mozz.bu.edu> User-Agent: Alpine 2.22 (BSF 395 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Received-SPF: pass client-ip=152.66.115.2; envelope-from=balaton@eik.bme.hu; helo=zero.eik.bme.hu X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/16 11:33:29 X-ACL-Warn: Detected OS = FreeBSD 9.x or newer [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Gerd Hoffmann Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Sat, 16 May 2020, Alexander Bulekov wrote: > On 200516 1513, BALATON Zoltan wrote: >> According to docs bits 1 and 0 of MM_INDEX are hard coded to 0 so >> unaligned access via this register should not be possible. >> This also fixes problems reported in bug #1878134. >> >> Signed-off-by: BALATON Zoltan >> --- > > Hi Zoltan, > I applied this patch and confirmed that I cannot reproduce the crash in #1878134 > Thanks! > > Acked-by: Alexander Bulekov Thanks, so that should be Tested-by I think but I don't care much about tags so whatever works for me. Regards, BALATON Zoltan >> hw/display/ati.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/hw/display/ati.c b/hw/display/ati.c >> index f4c4542751..2ee23173b2 100644 >> --- a/hw/display/ati.c >> +++ b/hw/display/ati.c >> @@ -531,7 +531,7 @@ static void ati_mm_write(void *opaque, hwaddr addr, >> } >> switch (addr) { >> case MM_INDEX: >> - s->regs.mm_index = data; >> + s->regs.mm_index = data & ~3; >> break; >> case MM_DATA ... MM_DATA + 3: >> /* indexed access to regs or memory */ >> -- >> 2.21.3 >> >> > >