From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Schindelin Subject: Re: What's cooking in git.git (topics) Date: Mon, 21 Jul 2008 00:24:07 +0200 (CEST) Message-ID: References: <7vr69r8sqk.fsf@gitster.siamese.dyndns.org> <7vlk01hqzz.fsf@gitster.siamese.dyndns.org> <20080718175040.6117@nanako3.lavabit.com> <20080718182010.6117@nanako3.lavabit.com> <7v63r38r4r.fsf@gitster.siamese.dyndns.org> <7vabge30dh.fsf@gitster.siamese.dyndns.org> <20080720130407.GF10347@genesis.frugalware.org> <7vd4l88l77.fsf@gitster.siamese.dyndns.org> <7vd4l85nv5.fsf@gitster.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Miklos Vajna , Nanako Shiraishi , git@vger.kernel.org To: Junio C Hamano X-From: git-owner@vger.kernel.org Mon Jul 21 00:24:34 2008 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1KKhKU-0003kH-4h for gcvg-git-2@gmane.org; Mon, 21 Jul 2008 00:24:34 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752049AbYGTWXS (ORCPT ); Sun, 20 Jul 2008 18:23:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752084AbYGTWXS (ORCPT ); Sun, 20 Jul 2008 18:23:18 -0400 Received: from mail.gmx.net ([213.165.64.20]:57460 "HELO mail.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751668AbYGTWXS (ORCPT ); Sun, 20 Jul 2008 18:23:18 -0400 Received: (qmail invoked by alias); 20 Jul 2008 22:23:15 -0000 Received: from 88-107-142-10.dynamic.dsl.as9105.com (EHLO eeepc-johanness.st-andrews.ac.uk) [88.107.142.10] by mail.gmx.net (mp015) with SMTP; 21 Jul 2008 00:23:15 +0200 X-Authenticated: #1490710 X-Provags-ID: V01U2FsdGVkX19hMl9TDjNhYqF7zf0DiLuHdSmjP5enBOpOsWNGNc CLdjdLg1UFA6q6 X-X-Sender: user@eeepc-johanness In-Reply-To: <7vd4l85nv5.fsf@gitster.siamese.dyndns.org> User-Agent: Alpine 1.00 (DEB 882 2007-12-20) X-Y-GMX-Trusted: 0 X-FuHaFi: 0.59 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Hi, On Sun, 20 Jul 2008, Junio C Hamano wrote: > Johannes Schindelin writes: > > >> I personally think -sstrategy=string1,string2,... is simply a bad taste. > >> > >> Why force yourself to parse things by having the users to concatenate > >> something that the user could give us separated? If you care about the > >> order and association between strategy and their options, you can always > >> do: > >> > >> -s strategy1 -X option-1-for-strategy-1 -X option-2-for-strategy-1 \ > >> -s strategy2 -X option-1-for-strategy-2 ... > > > > You mean something like > > > > $ git merge -s subtree -X --path -X git-gui/ git-gui/master > > > > Wow. :-) > > I would envision it to be more like: > > $ git merge -s subtree -Xpath=git-gui git-gui/master > > which git-merge internally would turn into: > > $ git-merge-subtree --path=git-gui HEAD -- OURS THEIRS > > That way both the external command line (that the end users do care about) > and the internal one (that the strategy programmer would care about) look > a lot more sensible than your command line, don't they? I still find it a lot easier to explain $ git -s subtree=git-gui git-gui/master to a new user than your command line, especially since $ git -X path=git-gui -s subtree git-gui/master would be a not so obvious mistake, _and_ especially since the implementation of your option parsing would be rather ugly. But the subject has been discussed to death, and you seem to still prefer the -X way, so I give up. You win, Dscho "who can adapt even to a syntax he does not like"