From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Thomas Rast <trast@student.ethz.ch>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH v2 4/5] t3301: use test_must_fail instead of !
Date: Sat, 14 Feb 2009 22:26:47 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.1.00.0902142226200.10279@pacific.mpi-cbg.de> (raw)
In-Reply-To: <8c50889d27e5baec1cbbd9a5775fa80b986c6df6.1234642638.git.trast@student.ethz.ch>
Hi,
On Sat, 14 Feb 2009, Thomas Rast wrote:
> We should use test_must_fail to negate output status, so that
> segfaults can be caught. One instance of ! negation remains, but that
> actually tests the return code of 'grep'.
ACK.
Ciao,
Dscho
next prev parent reply other threads:[~2009-02-14 21:27 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-14 19:15 [PATCH 1/4] notes: only clean up message file when editing Thomas Rast
2009-02-14 19:15 ` [PATCH 2/4] notes: use GIT_EDITOR and core.editor over VISUAL/EDITOR Thomas Rast
2009-02-14 19:29 ` Johannes Schindelin
2009-02-14 19:15 ` [PATCH 3/4] t3301: fix confusing test for valid notes ref Thomas Rast
2009-02-14 19:32 ` Johannes Schindelin
2009-02-14 19:15 ` [PATCH 4/4] notes: refuse to edit notes outside refs/notes/ Thomas Rast
2009-02-14 19:33 ` Johannes Schindelin
2009-02-14 19:56 ` Thomas Rast
2009-02-14 20:23 ` [PATCH v2 1/5] notes: only clean up message file when editing Thomas Rast
2009-02-15 7:54 ` Junio C Hamano
2009-02-14 20:23 ` [PATCH v2 2/5] notes: use GIT_EDITOR and core.editor over VISUAL/EDITOR Thomas Rast
2009-02-14 20:23 ` [PATCH v2 3/5] t3301: fix confusing quoting in test for valid notes ref Thomas Rast
2009-02-14 20:23 ` [PATCH v2 4/5] t3301: use test_must_fail instead of ! Thomas Rast
2009-02-14 21:26 ` Johannes Schindelin [this message]
2009-02-15 7:52 ` Junio C Hamano
2009-02-15 16:11 ` Thomas Rast
2009-02-15 18:18 ` Jeff King
2009-02-15 22:07 ` Thomas Rast
2009-02-17 9:29 ` Mike Ralphson
2009-02-17 16:34 ` Jeff King
2009-02-17 18:00 ` Mike Ralphson
2009-02-17 20:27 ` Jeff King
2009-02-18 6:41 ` Jeff King
2009-02-18 10:14 ` Johannes Schindelin
2009-02-18 10:16 ` Jeff King
2009-02-18 11:53 ` Johannes Schindelin
2009-02-19 0:37 ` Jeff King
2009-02-19 0:46 ` Johannes Schindelin
2009-02-19 0:46 ` Jeff King
2009-02-17 8:44 ` Thomas Rast
2009-02-17 8:46 ` Thomas Rast
2009-02-17 16:56 ` Brandon Casey
2009-02-17 22:20 ` Junio C Hamano
2009-02-17 22:53 ` [PATCH] test suite: correct export var=val usage Jay Soffian
2009-02-17 23:47 ` Johannes Schindelin
2009-02-18 0:37 ` Jay Soffian
2009-02-17 22:54 ` Jay Soffian
2009-02-17 22:57 ` Jay Soffian
2009-02-18 10:06 ` Wincent Colaiuta
2009-02-18 13:19 ` Jay Soffian
2009-02-18 13:29 ` Jay Soffian
2009-02-18 13:34 ` Johannes Schindelin
2009-02-18 16:56 ` Wincent Colaiuta
2009-02-18 17:05 ` Thomas Rast
2009-02-18 20:55 ` [PATCH v2] " Jay Soffian
2009-02-14 20:23 ` [PATCH v2 5/5] notes: refuse to edit notes outside refs/notes/ Thomas Rast
2009-02-14 19:29 ` [PATCH 1/4] notes: only clean up message file when editing Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.00.0902142226200.10279@pacific.mpi-cbg.de \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.