From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Lj9ve-0005dz-8o
	for qemu-devel@nongnu.org; Mon, 16 Mar 2009 06:20:18 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Lj9vY-0005dn-Ia
	for qemu-devel@nongnu.org; Mon, 16 Mar 2009 06:20:16 -0400
Received: from [199.232.76.173] (port=56038 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Lj9vY-0005dk-Cm
	for qemu-devel@nongnu.org; Mon, 16 Mar 2009 06:20:12 -0400
Received: from mail.gmx.net ([213.165.64.20]:37912)
	by monty-python.gnu.org with smtp (Exim 4.60)
	(envelope-from <Johannes.Schindelin@gmx.de>) id 1Lj9vX-0005TP-RH
	for qemu-devel@nongnu.org; Mon, 16 Mar 2009 06:20:12 -0400
Date: Mon, 16 Mar 2009 11:22:38 +0100 (CET)
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [Qemu-devel] Re: SIGSEGV on Windows with KQEMU enabled
In-Reply-To: <200903150042.58341.paul@codesourcery.com>
Message-ID: <alpine.DEB.1.00.0903161120450.5741@eeepc-johanness>
References: <gosfo1$575$1@ger.gmane.org> <gpe5da$4i1$1@ger.gmane.org>
	<alpine.DEB.1.00.0903141315430.10279@pacific.mpi-cbg.de>
	<200903150042.58341.paul@codesourcery.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: Consul <void@aleksoft.net>, qemu-devel@nongnu.org

Hi,

On Sun, 15 Mar 2009, Paul Brook wrote:

> > > But really funny think is the change that triggers the bug is precisely
> > > this: -Monitor *cur_mon;
> > > +Monitor *cur_mon = NULL;
> > >
> > > Obviously, kqemu is happier having garbage in the cur_mon than NULL
> >
> > I rather expect that to _hide_ the bug.  The "garbage" might be a
> > left-over from the heap.
> 
> This change does precisely nothing. In C all global and static variables 
> are implicitly zero initialized.

True.  I assumed that the lack of indentation was a mailer-induced 
mistake, but looking at the source (which I did not have time to when 
replying myself), you're correct, this initialization is in BSS, and 
therefore implicitly NULL anyway.

So I agree that this change cannot be the regression (except if GCC4 has a 
bug in BSS initialization, which I doubt rather strongly).

Ciao,
Dscho