Re: [PATCH] Re: rebase -i: auto-squash commits

From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Teemu Likonen <tlikonen@iki.fi>
Cc: Junio C Hamano <gitster@pobox.com>,
	Nicolas Sebrecht <nicolas.s.dev@gmx.fr>,
	Nanako Shiraishi <nanako3@lavabit.com>,
	John Tapsell <johnflux@gmail.com>,
	git@vger.kernel.org
Subject: Re: [PATCH] Re: rebase -i: auto-squash commits
Date: Thu, 18 Jun 2009 10:29:58 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.1.00.0906181028140.4848@intel-tinevez-2-302> (raw)
In-Reply-To: <87vdmuhs75.fsf@iki.fi>

Hi,

On Thu, 18 Jun 2009, Teemu Likonen wrote:

> On 2009-06-18 10:06 (+0200), Johannes Schindelin wrote:
> 
> > I'd really rather stay with "fixup". And as I use single-letter
> > commands quite often, I'd also rather stay away from that magic "!".
> > And by "magic" I really mean that: people will not find that magic
> > intuitive at all.
> 
> I don't know about people but I do find "!" intuitive. It is squash
> after all so I like the idea of using small modifier character.

Mhm.

So let's just interpret the "!" in the most common meaning, namely to add 
an imperative.  Then it means "yes, I do want to squash".  Not 
"squash, but oh, BTW, I want to lose the second commit message 
completely, and I do not want to edit the commit message either".

Really, I do not see how anybody could find this intuitive at all.  Maybe 
after reading the manual, but kinda defeats the meaning of the word 
"intuitive".

Ciao,
Dscho