From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Walmsley Subject: Re: [PATCH 1/7] OMAP24xx/25xx clock: init osc_ck, sys_ck internal lists early Date: Tue, 14 Apr 2009 12:31:47 -0600 (MDT) Message-ID: References: <20090414182039.22344.49790.stgit@localhost.localdomain> <20090414182324.22344.71159.stgit@localhost.localdomain> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: Received: from utopia.booyaka.com ([72.9.107.138]:39654 "EHLO utopia.booyaka.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759070AbZDNSbt (ORCPT ); Tue, 14 Apr 2009 14:31:49 -0400 In-Reply-To: <20090414182324.22344.71159.stgit@localhost.localdomain> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: linux-arm-kernel@lists.arm.linux.org.uk Cc: Russell King , linux-omap@vger.kernel.org Modifying subject line since lists.arm.linux.org.uk mail server bounces subjects containing "xxx". - Paul On Tue, 14 Apr 2009, Paul Walmsley wrote: > Commit 3f0a820c4c0b4670fb5f164baa5582e23c2ef118 breaks OMAP2xxx boot > during initial propagate_rate() on osc_ck and sys_ck. Fix by calling > clk_init_one() for these clocks first. > > Resolves > > <1>Unable to handle kernel NULL pointer dereference at virtual address 00000000 > <1>pgd = c0004000 > <1>[00000000] *pgd=00000000 > Internal error: Oops: 5 [#1] > Modules linked in: > CPU: 0 Not tainted (2.6.29-omap1 #37) > PC is at propagate_rate+0x10/0x60 > LR is at omap2_clk_init+0x30/0x218 > ... > > Signed-off-by: Paul Walmsley > Tested-by: Jarkko Nikula > Cc: Russell King > --- > arch/arm/mach-omap2/clock24xx.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-omap2/clock24xx.c b/arch/arm/mach-omap2/clock24xx.c > index 1e839c5..3b7ecc6 100644 > --- a/arch/arm/mach-omap2/clock24xx.c > +++ b/arch/arm/mach-omap2/clock24xx.c > @@ -720,6 +720,8 @@ int __init omap2_clk_init(void) > > clk_init(&omap2_clk_functions); > > + clk_init_one(&osc_ck); > + clk_init_one(&sys_ck); > osc_ck.rate = omap2_osc_clk_recalc(&osc_ck); > propagate_rate(&osc_ck); > sys_ck.rate = omap2_sys_clk_recalc(&sys_ck); > >