From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759850AbZEGSua (ORCPT ); Thu, 7 May 2009 14:50:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751284AbZEGSuO (ORCPT ); Thu, 7 May 2009 14:50:14 -0400 Received: from smtp-out.google.com ([216.239.33.17]:36526 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752278AbZEGSuM (ORCPT ); Thu, 7 May 2009 14:50:12 -0400 DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=date:from:x-x-sender:to:cc:subject:in-reply-to:message-id: references:user-agent:mime-version:content-type:x-system-of-record; b=MmZnR6BDJ8oNZQ0ByWZlQ27VDhTtyNwIDrdB1kap/4FmBlhpWZSXcyr5cJN3AXshn Gy/OJlstMZiGLXfo4hdcA== Date: Thu, 7 May 2009 11:50:04 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: "Rafael J. Wysocki" cc: Andrew Morton , fengguang.wu@intel.com, linux-pm@lists.linux-foundation.org, pavel@ucw.cz, torvalds@linux-foundation.org, jens.axboe@oracle.com, alan-jenkins@tuffmail.co.uk, linux-kernel@vger.kernel.org, kernel-testers@vger.kernel.org Subject: Re: [PATCH 1/5] mm: Add __GFP_NO_OOM_KILL flag In-Reply-To: <200905072009.53406.rjw@sisk.pl> Message-ID: References: <200905060120.35698.rjw@sisk.pl> <20090505164028.e9d807a1.akpm@linux-foundation.org> <200905072009.53406.rjw@sisk.pl> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 7 May 2009, Rafael J. Wysocki wrote: > Unfortunately it fails too quickly with the combination as well, so it looks > like we can't use __GFP_NORETRY during hibernation. > If you know that no other tasks are in the oom killer at suspend time, you can do what I mentioned earlier: struct zone *z; for_each_populated_zone(z) zone_set_flag(z, ZONE_OOM_LOCKED); and then later for_each_populated_zone(z) zone_clear_flag(z, ZONE_OOM_LOCKED); The only race there is if a task is currently in the oom killer and will subsequently clear ZONE_OOM_LOCKED for its zonelist. From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Rientjes Subject: Re: [PATCH 1/5] mm: Add __GFP_NO_OOM_KILL flag Date: Thu, 7 May 2009 11:50:04 -0700 (PDT) Message-ID: References: <200905060120.35698.rjw@sisk.pl> <20090505164028.e9d807a1.akpm@linux-foundation.org> <200905072009.53406.rjw@sisk.pl> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=google.com; s=beta; t=1241722209; bh=LnJN0UQ5wf/gYnVlbtOyNtyxmeI=; h=DomainKey-Signature:Date:From:X-X-Sender:To:cc:Subject: In-Reply-To:Message-ID:References:User-Agent:MIME-Version: Content-Type:X-System-Of-Record; b=Ki0iD6Cdgx2HsOsJNTghYiImE9/6bFR p0fr0/3QDbVtOgZMHdUqn3rh7xm5vulkluyYyQ+TuL5sC7GvDjYC8Rg== In-Reply-To: <200905072009.53406.rjw-KKrjLPT3xs0@public.gmane.org> Sender: kernel-testers-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: TEXT/PLAIN; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Rafael J. Wysocki" Cc: Andrew Morton , fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, linux-pm-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, pavel-+ZI9xUNit7I@public.gmane.org, torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, jens.axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, alan-jenkins-cCz0Lq7MMjm9FHfhHBbuYA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On Thu, 7 May 2009, Rafael J. Wysocki wrote: > Unfortunately it fails too quickly with the combination as well, so it looks > like we can't use __GFP_NORETRY during hibernation. > If you know that no other tasks are in the oom killer at suspend time, you can do what I mentioned earlier: struct zone *z; for_each_populated_zone(z) zone_set_flag(z, ZONE_OOM_LOCKED); and then later for_each_populated_zone(z) zone_clear_flag(z, ZONE_OOM_LOCKED); The only race there is if a task is currently in the oom killer and will subsequently clear ZONE_OOM_LOCKED for its zonelist.