From: Steven Rostedt <rostedt@goodmis.org>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH] tracing: create events only when configed
Date: Tue, 26 May 2009 12:38:39 -0400 (EDT) [thread overview]
Message-ID: <alpine.DEB.2.00.0905261227470.26705@gandalf.stny.rr.com> (raw)
In-Reply-To: <4A167307.7020905@cn.fujitsu.com>
On Fri, 22 May 2009, Lai Jiangshan wrote:
>
> There some unneeded events in debugfs/tracing/ftrace/ when the
> corresponding CONFIG_XXXX=n.
>
> And when CONFIG_ENABLE_EVENT_TRACING=n, various events
> are still created.
>
> Now when CONFIG_ENABLE_EVENT_TRACING=n, various events are
> not created, trace_export.c is compiled only for creating
> TRACEPOINTs.
>
> [Impact:] cleanup
I have an issue with this patch. I purposely kept the
debugfs/tracing/ftrace events there since you may have a binary buffer
that you want to read that has those events but you are not running a
kernel that enabled them. But I guess the counter arguement for that is
then those events may not be the same offset as the kernel that ran it.
OK, maybe it would be fine to disable the events if the kernel does not
use them. We should also put the same #ifdef's around the structs to make
sure no other trace uses them.
Still seems a bit messy with all those ifdefs :-/
The second change with the CONFIG_ENABLE_EVENT_TRACER is something that we
are having issue with the make scripts. We want EVENT_TRACE enabled
anytime TRACING is enabled. We do _not_ want to disable it.
The config option is there to enable event_tracer when on other tracing is
enabled. But we can't get rid of the option when tracing is enabled,
because we run into circular dependecies. Here's what we want:
config TRACING
select CONFIG_EVENT_TRACER
config CONFIG_ENABLE_EVENT_TRACING
prompt "select event tracer"
depends on !TRACING
select CONFIG_EVENT_TRACER
but!
config CONFIG_EVENT_TRACER
select TRACING
Which we then get an error creating the kbuild system due to dependency
problems.
The event tracer prompt should not be there when tracing is selected,
since we already have events, but I have yet to figure out how to get rid
of it.
Thus, I'll be OK with the first part of your patch, but I'm against the
second part.
-- Steve
next prev parent reply other threads:[~2009-05-26 16:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-22 9:40 [PATCH] tracing: create events only when configed Lai Jiangshan
2009-05-24 21:05 ` Frederic Weisbecker
2009-05-25 1:03 ` Lai Jiangshan
2009-05-25 23:18 ` Frederic Weisbecker
2009-05-26 16:38 ` Steven Rostedt [this message]
2009-05-27 8:19 ` Lai Jiangshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.0905261227470.26705@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=fweisbec@gmail.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.